From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 212D0C2D0C6 for ; Wed, 11 Dec 2019 15:59:52 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EC2182077B for ; Wed, 11 Dec 2019 15:59:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EC2182077B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kaod.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:44986 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1if4P1-0005nM-1C for qemu-devel@archiver.kernel.org; Wed, 11 Dec 2019 10:59:51 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:60170) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1if4O1-0004vQ-N8 for qemu-devel@nongnu.org; Wed, 11 Dec 2019 10:58:50 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1if4O0-0004Ex-GL for qemu-devel@nongnu.org; Wed, 11 Dec 2019 10:58:49 -0500 Received: from 9.mo68.mail-out.ovh.net ([46.105.78.111]:43349) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1if4O0-0004C8-8d for qemu-devel@nongnu.org; Wed, 11 Dec 2019 10:58:48 -0500 Received: from player696.ha.ovh.net (unknown [10.108.1.121]) by mo68.mail-out.ovh.net (Postfix) with ESMTP id C440714D14E for ; Wed, 11 Dec 2019 16:58:45 +0100 (CET) Received: from kaod.org (lns-bzn-46-82-253-208-248.adsl.proxad.net [82.253.208.248]) (Authenticated sender: groug@kaod.org) by player696.ha.ovh.net (Postfix) with ESMTPSA id BA5DAD3C227F; Wed, 11 Dec 2019 15:58:38 +0000 (UTC) Date: Wed, 11 Dec 2019 16:58:37 +0100 From: Greg Kurz To: =?UTF-8?B?Q8OpZHJpYw==?= Le Goater Subject: Re: [PATCH] ppc/pnv: Make PnvXScomInterface an incomplete type Message-ID: <20191211165837.35375bd9@bahia.tlslab.ibm.com> In-Reply-To: References: <157607473444.179018.14127987124523137347.stgit@bahia.lan> X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Ovh-Tracer-Id: 1311954866988095883 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedufedrudelhedgjeekucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuqfggjfdpvefjgfevmfevgfenuceurghilhhouhhtmecuhedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhepfffhvffukfgjfhfogggtgfesthhqredtredtjeenucfhrhhomhepifhrvghgucfmuhhriicuoehgrhhouhhgsehkrghougdrohhrgheqnecukfhppedtrddtrddtrddtpdekvddrvdehfedrvddtkedrvdegkeenucfrrghrrghmpehmohguvgepshhmthhpqdhouhhtpdhhvghlohepphhlrgihvghrieeliedrhhgrrdhovhhhrdhnvghtpdhinhgvtheptddrtddrtddrtddpmhgrihhlfhhrohhmpehgrhhouhhgsehkrghougdrohhrghdprhgtphhtthhopehqvghmuhdquggvvhgvlhesnhhonhhgnhhurdhorhhgnecuvehluhhsthgvrhfuihiivgeptd X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 46.105.78.111 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org, David Gibson Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Wed, 11 Dec 2019 16:35:41 +0100 C=C3=A9dric Le Goater wrote: > On 11/12/2019 15:32, Greg Kurz wrote: > > PnvXScomInterface is an interface instance. It should never be > > dereferenced. Drop the dummy type definition for extra safety, > > which is the common practice with QOM interfaces. > >=20 > > Signed-off-by: Greg Kurz > > --- > > include/hw/ppc/pnv_xscom.h | 4 +--- > > 1 file changed, 1 insertion(+), 3 deletions(-) > >=20 > > diff --git a/include/hw/ppc/pnv_xscom.h b/include/hw/ppc/pnv_xscom.h > > index 1c1d76bf9be5..b738011ab205 100644 > > --- a/include/hw/ppc/pnv_xscom.h > > +++ b/include/hw/ppc/pnv_xscom.h > > @@ -22,9 +22,7 @@ > > =20 > > #include "qom/object.h" > > =20 > > -typedef struct PnvXScomInterface { > > - Object parent; > > -} PnvXScomInterface; > > +typedef struct PnvXScomInterface PnvXScomInterface; > > =20 > > #define TYPE_PNV_XSCOM_INTERFACE "pnv-xscom-interface" > > #define PNV_XSCOM_INTERFACE(obj) \ >=20 > We should use INTERFACE_CHECK() here. >=20 Heh you're right, I missed that :) I'll send a v2 right away. > C. >=20 > =20 >=20