From: Stefan Hajnoczi <stefanha@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Dr. David Alan Gilbert" <dgilbert@redhat.com>,
Vivek Goyal <vgoyal@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [PATCH] virtio-fs: fix MSI-X nvectors calculation
Date: Fri, 13 Dec 2019 11:29:32 +0000 [thread overview]
Message-ID: <20191213112932.GA1186952@stefanha-x1.localdomain> (raw)
In-Reply-To: <20191209110759.35227-1-stefanha@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 796 bytes --]
On Mon, Dec 09, 2019 at 11:07:59AM +0000, Stefan Hajnoczi wrote:
> The following MSI-X vectors are required:
> * VIRTIO Configuration Change
> * hiprio virtqueue
> * requests virtqueues
>
> Fix the calculation to reserve enough MSI-X vectors. Otherwise guest
> drivers fall back to a sub-optional configuration where all virtqueues
> share a single vector.
>
> This change does not break live migration compatibility since
> vhost-user-fs-pci devices are not migratable yet.
>
> Reported-by: Vivek Goyal <vgoyal@redhat.com>
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> ---
> hw/virtio/vhost-user-fs-pci.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
Thanks, applied to my block tree:
https://github.com/stefanha/qemu/commits/block
Stefan
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2019-12-13 21:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-09 11:07 [PATCH] virtio-fs: fix MSI-X nvectors calculation Stefan Hajnoczi
2019-12-09 14:39 ` Dr. David Alan Gilbert
2019-12-09 19:21 ` no-reply
2019-12-09 19:26 ` no-reply
2019-12-11 16:05 ` Michael S. Tsirkin
2019-12-13 10:55 ` Dr. David Alan Gilbert
2019-12-13 11:29 ` Stefan Hajnoczi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191213112932.GA1186952@stefanha-x1.localdomain \
--to=stefanha@redhat.com \
--cc=dgilbert@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=vgoyal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).