qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Alex Bennée" <alex.bennee@linaro.org>
To: qemu-devel@nongnu.org
Cc: fam@euphon.net, berrange@redhat.com,
	"Robert Foley" <robert.foley@linaro.org>,
	stefanb@linux.vnet.ibm.com,
	"Alex Bennée" <alex.bennee@linaro.org>,
	richard.henderson@linaro.org, f4bug@amsat.org, cota@braap.org,
	stefanha@redhat.com, marcandre.lureau@redhat.com,
	pbonzini@redhat.com, aurelien@aurel32.net
Subject: [PATCH  v1 11/16] Fix double free issue in qemu_set_log_filename().
Date: Mon, 16 Dec 2019 11:07:27 +0000	[thread overview]
Message-ID: <20191216110732.24027-12-alex.bennee@linaro.org> (raw)
In-Reply-To: <20191216110732.24027-1-alex.bennee@linaro.org>

From: Robert Foley <robert.foley@linaro.org>

After freeing the logfilename, we set logfilename to NULL, in case of an
error which returns without setting logfilename.

Signed-off-by: Robert Foley <robert.foley@linaro.org>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20191118211528.3221-2-robert.foley@linaro.org>
---
 util/log.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/util/log.c b/util/log.c
index 1ca13059eef..4316fe74eee 100644
--- a/util/log.c
+++ b/util/log.c
@@ -113,6 +113,7 @@ void qemu_set_log_filename(const char *filename, Error **errp)
 {
     char *pidstr;
     g_free(logfilename);
+    logfilename = NULL;
 
     pidstr = strstr(filename, "%");
     if (pidstr) {
-- 
2.20.1



  parent reply	other threads:[~2019-12-16 11:18 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-16 11:07 [PATCH v1 00/16] testing and logging changes for master Alex Bennée
2019-12-16 11:07 ` [PATCH v1 01/16] configure: allow disable of cross compilation containers Alex Bennée
2019-12-16 18:59   ` Philippe Mathieu-Daudé
2019-12-18 18:17   ` Richard Henderson
2019-12-16 11:07 ` [PATCH v1 02/16] tests/vm: Allow to set qemu-img path Alex Bennée
2019-12-16 11:07 ` [PATCH v1 03/16] travis.yml: Run tcg tests with tci Alex Bennée
2019-12-17 15:35   ` Richard Henderson
2019-12-16 11:07 ` [PATCH v1 04/16] iotests: Provide a function for checking the creation of huge files Alex Bennée
2019-12-16 11:07 ` [PATCH v1 05/16] iotests: Skip test 060 if it is not possible to create large files Alex Bennée
2019-12-16 11:07 ` [PATCH v1 06/16] iotests: Skip test 079 " Alex Bennée
2019-12-16 19:00   ` Philippe Mathieu-Daudé
2019-12-16 11:07 ` [PATCH v1 07/16] tests/hd-geo-test: Skip test when images can not be created Alex Bennée
2019-12-16 11:07 ` [PATCH v1 08/16] tests/test-util-filemonitor: Skip test on non-x86 Travis containers Alex Bennée
2019-12-16 11:07 ` [PATCH v1 09/16] travis.yml: Enable builds on arm64, ppc64le and s390x Alex Bennée
2019-12-16 11:07 ` [PATCH v1 10/16] ci: build out-of-tree Alex Bennée
2019-12-16 11:21   ` Li-Wen Hsu
2019-12-16 11:07 ` Alex Bennée [this message]
2019-12-16 11:07 ` [PATCH v1 12/16] Cleaned up flow of code in qemu_set_log(), to simplify and clarify Alex Bennée
2019-12-16 11:07 ` [PATCH v1 13/16] Add a mutex to guarantee single writer to qemu_logfile handle Alex Bennée
2019-12-16 11:07 ` [PATCH v1 14/16] qemu_log_lock/unlock now preserves the " Alex Bennée
2019-12-16 11:07 ` [PATCH v1 15/16] Add use of RCU for qemu_logfile Alex Bennée
2019-12-16 11:07 ` [PATCH v1 16/16] Added tests for close and change of logfile Alex Bennée

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191216110732.24027-12-alex.bennee@linaro.org \
    --to=alex.bennee@linaro.org \
    --cc=aurelien@aurel32.net \
    --cc=berrange@redhat.com \
    --cc=cota@braap.org \
    --cc=f4bug@amsat.org \
    --cc=fam@euphon.net \
    --cc=marcandre.lureau@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    --cc=robert.foley@linaro.org \
    --cc=stefanb@linux.vnet.ibm.com \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).