From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: "Paolo Bonzini" <pbonzini@redhat.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
qemu-devel@nongnu.org
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
"Li Zhijian" <lizhijian@cn.fujitsu.com>,
"Paul Burton" <pburton@wavecomp.com>,
"Jason Wang" <jasowang@redhat.com>,
"KONRAD Frederic" <frederic.konrad@adacore.com>,
"Gerd Hoffmann" <kraxel@redhat.com>,
"Edgar E. Iglesias" <edgar.iglesias@gmail.com>,
"Alberto Garcia" <berto@igalia.com>,
"Sagar Karandikar" <sagark@eecs.berkeley.edu>,
qemu-block@nongnu.org, "Michael S. Tsirkin" <mst@redhat.com>,
"Markus Armbruster" <armbru@redhat.com>,
"Halil Pasic" <pasic@linux.ibm.com>,
"Christian Borntraeger" <borntraeger@de.ibm.com>,
"Gonglei (Arei)" <arei.gonglei@huawei.com>,
"Joel Stanley" <joel@jms.id.au>,
"Samuel Thibault" <samuel.thibault@ens-lyon.org>,
"Aleksandar Rikalo" <aleksandar.rikalo@rt-rk.com>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
"Antony Pavlov" <antonynpavlov@gmail.com>,
"Laurent Vivier" <lvivier@redhat.com>,
"Corey Minyard" <minyard@acm.org>, "Amit Shah" <amit@kernel.org>,
"Alistair Francis" <alistair@alistair23.me>,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
"Fabien Chouteau" <chouteau@adacore.com>,
qemu-s390x@nongnu.org, qemu-arm@nongnu.org,
"Peter Chubb" <peter.chubb@nicta.com.au>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Kevin Wolf" <kwolf@redhat.com>,
qemu-riscv@nongnu.org, "Igor Mitsyanko" <i.mitsyanko@gmail.com>,
"Bastian Koppelmann" <kbastian@mail.uni-paderborn.de>,
"Cornelia Huck" <cohuck@redhat.com>,
"Max Reitz" <mreitz@redhat.com>,
"Zhang Chen" <chen.zhang@intel.com>,
"Michael Walle" <michael@walle.cc>,
"Palmer Dabbelt" <palmer@dabbelt.com>,
"Thomas Huth" <huth@tuxfamily.org>,
"Aleksandar Markovic" <amarkovic@wavecomp.com>,
"Aurelien Jarno" <aurelien@aurel32.net>
Subject: [RFC PATCH 02/14] chardev/char: Explicit we ignore some QEMUChrEvent in IOEventHandler
Date: Tue, 17 Dec 2019 17:37:56 +0100 [thread overview]
Message-ID: <20191217163808.20068-3-philmd@redhat.com> (raw)
In-Reply-To: <20191217163808.20068-1-philmd@redhat.com>
The Chardev events are listed in the QEMUChrEvent enum. To be
able to use this enum in the IOEventHandler typedef, we need to
explicit when frontends ignore some events, to silent GCC the
following warnings:
chardev/char.c: In function ‘qemu_chr_be_event’:
chardev/char.c:65:5: error: enumeration value ‘CHR_EVENT_BREAK’ not handled in switch [-Werror=switch]
65 | switch (event) {
| ^~~~~~
chardev/char.c:65:5: error: enumeration value ‘CHR_EVENT_MUX_IN’ not handled in switch [-Werror=switch]
chardev/char.c:65:5: error: enumeration value ‘CHR_EVENT_MUX_OUT’ not handled in switch [-Werror=switch]
cc1: all warnings being treated as errors
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
Cc: "Marc-André Lureau" <marcandre.lureau@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>
---
chardev/char.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/chardev/char.c b/chardev/char.c
index 7b6b2cb123..c4b6bbc55a 100644
--- a/chardev/char.c
+++ b/chardev/char.c
@@ -69,6 +69,9 @@ void qemu_chr_be_event(Chardev *s, int event)
case CHR_EVENT_CLOSED:
s->be_open = 0;
break;
+ default:
+ /* Ignore */
+ break;
}
CHARDEV_GET_CLASS(s)->chr_be_event(s, event);
--
2.21.0
next prev parent reply other threads:[~2019-12-17 16:41 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-17 16:37 [PATCH 00/14] chardev: Use QEMUChrEvent enum in IOEventHandler typedef Philippe Mathieu-Daudé
2019-12-17 16:37 ` [PATCH 01/14] hw/ipmi: Remove unnecessary declarations Philippe Mathieu-Daudé
2019-12-17 16:37 ` Philippe Mathieu-Daudé [this message]
2019-12-17 16:37 ` [RFC PATCH 03/14] vhost-user: Explicit we ignore some QEMUChrEvent in IOEventHandler Philippe Mathieu-Daudé
2019-12-17 16:37 ` [RFC PATCH 04/14] virtio-console: " Philippe Mathieu-Daudé
2019-12-17 16:37 ` [RFC PATCH 05/14] hw/ipmi: " Philippe Mathieu-Daudé
2019-12-17 16:38 ` [RFC PATCH 06/14] hw/usb/dev-serial: Explicit we ignore few " Philippe Mathieu-Daudé
2019-12-17 16:38 ` [RFC PATCH 07/14] ccid-card-passthru: Explicit we ignore " Philippe Mathieu-Daudé
2019-12-17 16:38 ` [RFC PATCH 08/14] hw/usb/redirect: Explicit we ignore few " Philippe Mathieu-Daudé
2019-12-17 16:38 ` [RFC PATCH 09/14] monitor/qmp: " Philippe Mathieu-Daudé
2019-12-17 16:38 ` [RFC PATCH 10/14] monitor/hmp: Explicit we ignore a " Philippe Mathieu-Daudé
2019-12-17 17:37 ` Dr. David Alan Gilbert
2019-12-17 17:46 ` Philippe Mathieu-Daudé
2019-12-17 17:51 ` Dr. David Alan Gilbert
2019-12-17 16:38 ` [RFC PATCH 11/14] net/vhost-user: Explicit we ignore few " Philippe Mathieu-Daudé
2019-12-17 16:38 ` [RFC PATCH 12/14] vhost-user-blk: " Philippe Mathieu-Daudé
2019-12-17 16:38 ` [RFC PATCH 13/14] hw/char/terminal3270: Explicit ignored " Philippe Mathieu-Daudé
2019-12-19 6:52 ` Markus Armbruster
2019-12-19 13:09 ` Philippe Mathieu-Daudé
2019-12-17 16:38 ` [PATCH 14/14] chardev: Use QEMUChrEvent enum in IOEventHandler typedef Philippe Mathieu-Daudé
2019-12-17 16:50 ` [PATCH 00/14] " Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191217163808.20068-3-philmd@redhat.com \
--to=philmd@redhat.com \
--cc=aleksandar.rikalo@rt-rk.com \
--cc=alex.bennee@linaro.org \
--cc=alistair@alistair23.me \
--cc=amarkovic@wavecomp.com \
--cc=amit@kernel.org \
--cc=antonynpavlov@gmail.com \
--cc=arei.gonglei@huawei.com \
--cc=armbru@redhat.com \
--cc=aurelien@aurel32.net \
--cc=berto@igalia.com \
--cc=borntraeger@de.ibm.com \
--cc=chen.zhang@intel.com \
--cc=chouteau@adacore.com \
--cc=cohuck@redhat.com \
--cc=dgilbert@redhat.com \
--cc=edgar.iglesias@gmail.com \
--cc=frederic.konrad@adacore.com \
--cc=huth@tuxfamily.org \
--cc=i.mitsyanko@gmail.com \
--cc=jasowang@redhat.com \
--cc=joel@jms.id.au \
--cc=kbastian@mail.uni-paderborn.de \
--cc=kraxel@redhat.com \
--cc=kwolf@redhat.com \
--cc=lizhijian@cn.fujitsu.com \
--cc=lvivier@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=michael@walle.cc \
--cc=minyard@acm.org \
--cc=mreitz@redhat.com \
--cc=mst@redhat.com \
--cc=palmer@dabbelt.com \
--cc=pasic@linux.ibm.com \
--cc=pbonzini@redhat.com \
--cc=pburton@wavecomp.com \
--cc=peter.chubb@nicta.com.au \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-riscv@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=sagark@eecs.berkeley.edu \
--cc=samuel.thibault@ens-lyon.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).