From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 12DFDC43603 for ; Tue, 17 Dec 2019 17:52:29 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D460F24679 for ; Tue, 17 Dec 2019 17:52:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="JUcQ/ASW" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D460F24679 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:44620 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ihH1I-0006GA-1e for qemu-devel@archiver.kernel.org; Tue, 17 Dec 2019 12:52:28 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:58392) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ihH0g-0005qp-Hh for qemu-devel@nongnu.org; Tue, 17 Dec 2019 12:51:51 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ihH0e-00008q-7c for qemu-devel@nongnu.org; Tue, 17 Dec 2019 12:51:49 -0500 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:35020 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ihH0e-00005d-41 for qemu-devel@nongnu.org; Tue, 17 Dec 2019 12:51:48 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1576605107; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3aDE1L+Xb5p32jzMEtH//uQo4KQnaVnoXx6owLvWO2Y=; b=JUcQ/ASWXWGKmhGtE3FAmiFTG1HaLV7wNmh8TJwVkMWnEG3z46XLQI5znv7x/U8t9bKARn TguXKgUXjSb3wbe/xzf62B+YHjszPnQ/TMjEQVlYlt3FushAcuSXqQb08rjUybbYNwF5Rg EdFFWg9fXxKa4MAkvXakKFMmzz+GAEI= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-345-60zssl8ZNhC-tKwPzrpKmA-1; Tue, 17 Dec 2019 12:51:46 -0500 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id F20BC107ACE3 for ; Tue, 17 Dec 2019 17:51:44 +0000 (UTC) Received: from work-vm (ovpn-117-232.ams2.redhat.com [10.36.117.232]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4CD9560BE0; Tue, 17 Dec 2019 17:51:41 +0000 (UTC) Date: Tue, 17 Dec 2019 17:51:39 +0000 From: "Dr. David Alan Gilbert" To: Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= Subject: Re: [RFC PATCH 10/14] monitor/hmp: Explicit we ignore a QEMUChrEvent in IOEventHandler Message-ID: <20191217175139.GF2780@work-vm> References: <20191217163808.20068-1-philmd@redhat.com> <20191217163808.20068-11-philmd@redhat.com> <20191217173722.GD2780@work-vm> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/1.13.0 (2019-11-30) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-MC-Unique: 60zssl8ZNhC-tKwPzrpKmA-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 207.211.31.120 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" * Philippe Mathieu-Daud=C3=A9 (philmd@redhat.com) wrote: > On 12/17/19 6:37 PM, Dr. David Alan Gilbert wrote: > > * Philippe Mathieu-Daud=C3=A9 (philmd@redhat.com) wrote: > > > The Chardev events are listed in the QEMUChrEvent enum. To be > > > able to use this enum in the IOEventHandler typedef, we need to > > > explicit when frontends ignore some events, to silent GCC the > > > following warnings: > > >=20 > > > CC monitor/hmp.o > > > monitor/hmp.c: In function =E2=80=98monitor_event=E2=80=99: > > > monitor/hmp.c:1330:5: error: enumeration value =E2=80=98CHR_EVENT_= BREAK=E2=80=99 not handled in switch [-Werror=3Dswitch] > > > 1330 | switch (event) { > > > | ^~~~~~ > > > cc1: all warnings being treated as errors > > >=20 > > > Signed-off-by: Philippe Mathieu-Daud=C3=A9 > > > --- > >=20 > >=20 > > Acked-by: Dr. David Alan Gilbert > > for HMP > >=20 > > Note that the use of 'default' will make life more unpredictable > > if you ever come to add a new event type. >=20 > You are right, this patch not good as it dumbly ignore the warning... > I will add all the missing cases: >=20 > -- >8 -- > @@ -1371,6 +1371,10 @@ static void monitor_event(void *opaque, int event) > mon_refcount--; > monitor_fdsets_cleanup(); > break; > + > + case CHR_EVENT_BREAK: > + /* Ignored */ > + break; > } > } >=20 > --- >=20 > And keep your Acked-by. Thanks! Acked-by: Dr. David Alan Gilbert >=20 > > > Cc: "Dr. David Alan Gilbert" > > > --- > > > monitor/hmp.c | 4 ++++ > > > 1 file changed, 4 insertions(+) > > >=20 > > > diff --git a/monitor/hmp.c b/monitor/hmp.c > > > index 8942e28933..d84238c120 100644 > > > --- a/monitor/hmp.c > > > +++ b/monitor/hmp.c > > > @@ -1371,6 +1371,10 @@ static void monitor_event(void *opaque, int ev= ent) > > > mon_refcount--; > > > monitor_fdsets_cleanup(); > > > break; > > > + > > > + default: > > > + /* Ignore */ > > > + break; > > > } > > > } > > > --=20 > > > 2.21.0 > > >=20 > > -- > > Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK > >=20 >=20 -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK