qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Juan Quintela <quintela@redhat.com>
To: qemu-devel@nongnu.org
Cc: Laurent Vivier <lvivier@redhat.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Thomas Huth <thuth@redhat.com>,
	"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
	Juan Quintela <quintela@redhat.com>
Subject: [PATCH v2 00/10] Migration Arguments cleanup
Date: Wed, 18 Dec 2019 02:55:10 +0100	[thread overview]
Message-ID: <20191218015520.2881-1-quintela@redhat.com> (raw)

[v2]
- fix use-after-free (thanks peter)

[v1]
This series simplify test_migrate_start() in two ways:
- simplify the command line creation, so everything that is common between
  architectures don't have to be repeated (DRY).
  Note that this bit remove lines of code.
- test_migrate_start() has two bools and two strings as arguments, it is very
  difficult to remmeber which is which and meaning.  And it is even worse to
  add new parameters.  Just pass them through one struct.

Please, review.

Juan Quintela (10):
  migration-test: Create cmd_soure and cmd_target
  migration-test: Move hide_stderr to common commandline
  migration-test: Move -machine to common commandline
  migration-test: Move memory size to common commandline
  migration-test: Move shmem handling to common commandline
  migration-test: Move -name handling to common commandline
  migration-test: Move -serial handling to common commandline
  migration-test: Move -incomming handling to common commandline
  migration-test: Rename cmd_src/dst to arch_source/arch_target
  migration-test: Use a struct for test_migrate_start parameters

 tests/migration-test.c | 269 +++++++++++++++++++++++------------------
 1 file changed, 149 insertions(+), 120 deletions(-)

-- 
2.23.0



             reply	other threads:[~2019-12-18  1:56 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-18  1:55 Juan Quintela [this message]
2019-12-18  1:55 ` [PATCH v2 01/10] migration-test: Create cmd_soure and cmd_target Juan Quintela
2019-12-18 10:40   ` Thomas Huth
2019-12-18 10:58     ` Juan Quintela
2019-12-18  1:55 ` [PATCH v2 02/10] migration-test: Move hide_stderr to common commandline Juan Quintela
2019-12-18  1:55 ` [PATCH v2 03/10] migration-test: Move -machine " Juan Quintela
2019-12-18  1:55 ` [PATCH v2 04/10] migration-test: Move memory size " Juan Quintela
2019-12-18  1:55 ` [PATCH v2 05/10] migration-test: Move shmem handling " Juan Quintela
2019-12-18  1:55 ` [PATCH v2 06/10] migration-test: Move -name " Juan Quintela
2019-12-18  1:55 ` [PATCH v2 07/10] migration-test: Move -serial " Juan Quintela
2019-12-18  1:55 ` [PATCH v2 08/10] migration-test: Move -incomming " Juan Quintela
2019-12-18 10:43   ` Thomas Huth
2019-12-18  1:55 ` [PATCH v2 09/10] migration-test: Rename cmd_src/dst to arch_source/arch_target Juan Quintela
2019-12-18 10:44   ` Thomas Huth
2019-12-18  1:55 ` [PATCH v2 10/10] migration-test: Use a struct for test_migrate_start parameters Juan Quintela

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191218015520.2881-1-quintela@redhat.com \
    --to=quintela@redhat.com \
    --cc=dgilbert@redhat.com \
    --cc=lvivier@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).