qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Richard Henderson <richard.henderson@linaro.org>
To: qemu-devel@nongnu.org
Cc: philmd@redhat.com, i@maskray.me, berrange@redhat.com
Subject: [PATCH 5/7] configure: Unnest detection of -z,relro and -z,now
Date: Tue, 17 Dec 2019 17:19:18 -1000	[thread overview]
Message-ID: <20191218031920.6414-6-richard.henderson@linaro.org> (raw)
In-Reply-To: <20191218031920.6414-1-richard.henderson@linaro.org>

There is nothing about these options that is related to PIE.
Nor is there anything that specifically ties them to each other.
Use them unconditionally.

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
 configure | 13 ++++++++++---
 1 file changed, 10 insertions(+), 3 deletions(-)

diff --git a/configure b/configure
index 972ce7396f..f8981eec15 100755
--- a/configure
+++ b/configure
@@ -2034,9 +2034,6 @@ if test "$pie" != "no" ; then
     QEMU_CFLAGS="-fPIE -DPIE $QEMU_CFLAGS"
     LDFLAGS="-pie $LDFLAGS"
     pie="yes"
-    if compile_prog "" "-Wl,-z,relro -Wl,-z,now" ; then
-      LDFLAGS="-Wl,-z,relro -Wl,-z,now $LDFLAGS"
-    fi
   else
     if test "$pie" = "yes"; then
       error_exit "PIE not available due to missing toolchain support"
@@ -2047,6 +2044,16 @@ if test "$pie" != "no" ; then
   fi
 fi
 
+# Detect support for DT_BIND_NOW.
+if compile_prog "" "-Wl,-z,now" ; then
+  LDFLAGS="-Wl,-z,now $LDFLAGS"
+fi
+
+# Detect support for PT_GNU_RELRO.
+if compile_prog "" "-Wl,-z,relro" ; then
+  LDFLAGS="-Wl,-z,relro $LDFLAGS"
+fi
+
 ##########################################
 # __sync_fetch_and_and requires at least -march=i486. Many toolchains
 # use i686 as default anyway, but for those that don't, an explicit
-- 
2.20.1



  parent reply	other threads:[~2019-12-18  3:23 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-18  3:19 [PATCH 0/7] configure: Improve PIE and other linkage Richard Henderson
2019-12-18  3:19 ` [PATCH 1/7] configure: Drop adjustment of textseg Richard Henderson
2019-12-18  6:59   ` Thomas Huth
2019-12-18 17:22     ` Richard Henderson
2019-12-18  3:19 ` [PATCH 2/7] tcg: Remove softmmu code_gen_buffer fixed address Richard Henderson
2019-12-18  7:01   ` Thomas Huth
2019-12-18  3:19 ` [PATCH 3/7] configure: Do not force pie=no for non-x86 Richard Henderson
2019-12-18  7:05   ` Thomas Huth
2019-12-18 19:23     ` Richard Henderson
2019-12-18  3:19 ` [PATCH 4/7] configure: Always detect -no-pie toolchain support Richard Henderson
2019-12-18  8:04   ` Thomas Huth
2019-12-18 17:55   ` Philippe Mathieu-Daudé
2019-12-18  3:19 ` Richard Henderson [this message]
2019-12-18  8:11   ` [PATCH 5/7] configure: Unnest detection of -z,relro and -z,now Thomas Huth
2019-12-18 16:58     ` Richard Henderson
2019-12-18 18:31       ` Thomas Huth
2019-12-18  3:19 ` [PATCH 6/7] configure: Override the os default with --disable-pie Richard Henderson
2019-12-18  8:13   ` Thomas Huth
2019-12-18 17:57   ` Philippe Mathieu-Daudé
2019-12-18  3:19 ` [PATCH 7/7] configure: Support -static-pie if requested Richard Henderson
2019-12-18  8:15   ` Thomas Huth
2019-12-18  7:28 ` [PATCH 0/7] configure: Improve PIE and other linkage Fangrui Song
2019-12-18 22:32   ` Richard Henderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191218031920.6414-6-richard.henderson@linaro.org \
    --to=richard.henderson@linaro.org \
    --cc=berrange@redhat.com \
    --cc=i@maskray.me \
    --cc=philmd@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).