From: Markus Armbruster <armbru@redhat.com>
To: qemu-devel@nongnu.org
Cc: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Subject: [PULL v2 25/35] hw/i386/amd_iommu: rename Error ** parameter to more common errp
Date: Wed, 18 Dec 2019 09:17:11 +0100 [thread overview]
Message-ID: <20191218081721.23520-26-armbru@redhat.com> (raw)
In-Reply-To: <20191218081721.23520-1-armbru@redhat.com>
From: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Message-Id: <20191205174635.18758-12-vsementsov@virtuozzo.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
hw/i386/amd_iommu.c | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/hw/i386/amd_iommu.c b/hw/i386/amd_iommu.c
index d55dbf07fc..b1175e52c7 100644
--- a/hw/i386/amd_iommu.c
+++ b/hw/i386/amd_iommu.c
@@ -1533,7 +1533,7 @@ static void amdvi_reset(DeviceState *dev)
amdvi_init(s);
}
-static void amdvi_realize(DeviceState *dev, Error **err)
+static void amdvi_realize(DeviceState *dev, Error **errp)
{
int ret = 0;
AMDVIState *s = AMD_IOMMU_DEVICE(dev);
@@ -1549,21 +1549,21 @@ static void amdvi_realize(DeviceState *dev, Error **err)
/* This device should take care of IOMMU PCI properties */
x86_iommu->type = TYPE_AMD;
qdev_set_parent_bus(DEVICE(&s->pci), &bus->qbus);
- object_property_set_bool(OBJECT(&s->pci), true, "realized", err);
+ object_property_set_bool(OBJECT(&s->pci), true, "realized", errp);
ret = pci_add_capability(&s->pci.dev, AMDVI_CAPAB_ID_SEC, 0,
- AMDVI_CAPAB_SIZE, err);
+ AMDVI_CAPAB_SIZE, errp);
if (ret < 0) {
return;
}
s->capab_offset = ret;
ret = pci_add_capability(&s->pci.dev, PCI_CAP_ID_MSI, 0,
- AMDVI_CAPAB_REG_SIZE, err);
+ AMDVI_CAPAB_REG_SIZE, errp);
if (ret < 0) {
return;
}
ret = pci_add_capability(&s->pci.dev, PCI_CAP_ID_HT, 0,
- AMDVI_CAPAB_REG_SIZE, err);
+ AMDVI_CAPAB_REG_SIZE, errp);
if (ret < 0) {
return;
}
@@ -1578,8 +1578,8 @@ static void amdvi_realize(DeviceState *dev, Error **err)
sysbus_init_mmio(SYS_BUS_DEVICE(s), &s->mmio);
sysbus_mmio_map(SYS_BUS_DEVICE(s), 0, AMDVI_BASE_ADDR);
pci_setup_iommu(bus, amdvi_host_dma_iommu, s);
- s->devid = object_property_get_int(OBJECT(&s->pci), "addr", err);
- msi_init(&s->pci.dev, 0, 1, true, false, err);
+ s->devid = object_property_get_int(OBJECT(&s->pci), "addr", errp);
+ msi_init(&s->pci.dev, 0, 1, true, false, errp);
amdvi_init(s);
}
--
2.21.0
next prev parent reply other threads:[~2019-12-18 8:33 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-18 8:16 [PULL v2 00/35] Error reporting patches for 2019-12-17 Markus Armbruster
2019-12-18 8:16 ` [PULL v2 01/35] error: Fix -msg timestamp default Markus Armbruster
2019-12-18 8:16 ` [PULL v2 02/35] crypto: Fix certificate file error handling crash bug Markus Armbruster
2019-12-18 8:16 ` [PULL v2 03/35] crypto: Fix typo in QCryptoTLSSession's <example> comment Markus Armbruster
2019-12-18 8:16 ` [PULL v2 04/35] io: Fix Error usage in a comment <example> Markus Armbruster
2019-12-18 8:16 ` [PULL v2 05/35] tests: Clean up initialization of Error *err variables Markus Armbruster
2019-12-18 8:16 ` [PULL v2 06/35] exec: Fix file_ram_alloc() error API violations Markus Armbruster
2019-12-18 8:16 ` [PULL v2 07/35] hw/acpi: Fix legacy CPU plug " Markus Armbruster
2019-12-18 8:16 ` [PULL v2 08/35] hw/core: Fix fit_load_fdt() " Markus Armbruster
2019-12-18 8:16 ` [PULL v2 09/35] hw/ipmi: Fix realize() " Markus Armbruster
2019-12-18 8:16 ` [PULL v2 10/35] qga: Fix guest-get-fsinfo " Markus Armbruster
2019-12-18 8:16 ` [PULL v2 11/35] memory-device: Fix memory pre-plug " Markus Armbruster
2019-12-18 8:16 ` [PULL v2 12/35] error: Clean up unusual names of Error * variables Markus Armbruster
2019-12-18 8:16 ` [PULL v2 13/35] hw/intc/s390: Simplify error handling in kvm_s390_flic_realize() Markus Armbruster
2019-12-18 8:17 ` [PULL v2 14/35] tests-blockjob: Use error_free_or_abort() Markus Armbruster
2019-12-18 8:17 ` [PULL v2 15/35] net/net: Clean up variable shadowing in net_client_init() Markus Armbruster
2019-12-18 8:17 ` [PULL v2 16/35] error: make Error **errp const where it is appropriate Markus Armbruster
2019-12-18 8:17 ` [PULL v2 17/35] hmp: drop Error pointer indirection in hmp_handle_error Markus Armbruster
2019-12-18 8:17 ` [PULL v2 18/35] vnc: drop Error pointer indirection in vnc_client_io_error Markus Armbruster
2019-12-18 8:17 ` [PULL v2 19/35] qdev-monitor: make Error **errp const where it is appropriate Markus Armbruster
2019-12-18 8:17 ` [PULL v2 20/35] Revert "ppc: well form kvmppc_hint_smt_possible error hint helper" Markus Armbruster
2019-12-18 8:17 ` [PULL v2 21/35] ppc: make Error **errp const where it is appropriate Markus Armbruster
2019-12-18 8:17 ` [PULL v2 22/35] 9pfs: " Markus Armbruster
2019-12-18 8:17 ` [PULL v2 23/35] hw/core/qdev: cleanup Error ** variables Markus Armbruster
2019-12-18 8:17 ` [PULL v2 24/35] block/snapshot: rename Error ** parameter to more common errp Markus Armbruster
2019-12-18 8:17 ` Markus Armbruster [this message]
2019-12-18 8:17 ` [PULL v2 26/35] qga: " Markus Armbruster
2019-12-18 8:17 ` [PULL v2 27/35] monitor/qmp-cmds: " Markus Armbruster
2019-12-18 8:17 ` [PULL v2 28/35] hw/s390x: " Markus Armbruster
2019-12-18 8:17 ` [PULL v2 29/35] hw/sd: drop extra whitespace in sdhci_sysbus_realize() header Markus Armbruster
2019-12-18 8:17 ` [PULL v2 30/35] hw/tpm: rename Error ** parameter to more common errp Markus Armbruster
2019-12-18 8:17 ` [PULL v2 31/35] hw/usb: " Markus Armbruster
2019-12-18 8:17 ` [PULL v2 32/35] include/qom/object.h: " Markus Armbruster
2019-12-18 8:17 ` [PULL v2 33/35] backends/cryptodev: drop local_err from cryptodev_backend_complete() Markus Armbruster
2019-12-18 8:17 ` [PULL v2 34/35] hw/vfio/ap: drop local_err from vfio_ap_realize Markus Armbruster
2019-12-18 8:17 ` [PULL v2 35/35] nbd: assert that Error** is not NULL in nbd_iter_channel_error Markus Armbruster
2019-12-20 11:20 ` [PULL v2 00/35] Error reporting patches for 2019-12-17 Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191218081721.23520-26-armbru@redhat.com \
--to=armbru@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).