qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Markus Armbruster <armbru@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Vladimir Sementsov-Ogievskiy" <vsementsov@virtuozzo.com>,
	"Philippe Mathieu-Daudé" <philmd@redhat.com>
Subject: [PULL v2 26/35] qga: rename Error ** parameter to more common errp
Date: Wed, 18 Dec 2019 09:17:12 +0100	[thread overview]
Message-ID: <20191218081721.23520-27-armbru@redhat.com> (raw)
In-Reply-To: <20191218081721.23520-1-armbru@redhat.com>

From: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>

Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Message-Id: <20191205174635.18758-13-vsementsov@virtuozzo.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
 qga/commands-posix.c |  2 +-
 qga/commands-win32.c |  2 +-
 qga/commands.c       | 12 ++++++------
 3 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/qga/commands-posix.c b/qga/commands-posix.c
index 10d818c3b2..93474ff770 100644
--- a/qga/commands-posix.c
+++ b/qga/commands-posix.c
@@ -2794,7 +2794,7 @@ static double ga_get_login_time(struct utmpx *user_info)
     return seconds + useconds;
 }
 
-GuestUserList *qmp_guest_get_users(Error **err)
+GuestUserList *qmp_guest_get_users(Error **errp)
 {
     GHashTable *cache = NULL;
     GuestUserList *head = NULL, *cur_item = NULL;
diff --git a/qga/commands-win32.c b/qga/commands-win32.c
index 55ba5b263a..2461fd19bf 100644
--- a/qga/commands-win32.c
+++ b/qga/commands-win32.c
@@ -1946,7 +1946,7 @@ typedef struct _GA_WTSINFOA {
 
 } GA_WTSINFOA;
 
-GuestUserList *qmp_guest_get_users(Error **err)
+GuestUserList *qmp_guest_get_users(Error **errp)
 {
 #define QGA_NANOSECONDS 10000000
 
diff --git a/qga/commands.c b/qga/commands.c
index 0c7d1385c2..43c323cead 100644
--- a/qga/commands.c
+++ b/qga/commands.c
@@ -143,7 +143,7 @@ static GuestExecInfo *guest_exec_info_find(int64_t pid_numeric)
     return NULL;
 }
 
-GuestExecStatus *qmp_guest_exec_status(int64_t pid, Error **err)
+GuestExecStatus *qmp_guest_exec_status(int64_t pid, Error **errp)
 {
     GuestExecInfo *gei;
     GuestExecStatus *ges;
@@ -152,7 +152,7 @@ GuestExecStatus *qmp_guest_exec_status(int64_t pid, Error **err)
 
     gei = guest_exec_info_find(pid);
     if (gei == NULL) {
-        error_setg(err, QERR_INVALID_PARAMETER, "pid");
+        error_setg(errp, QERR_INVALID_PARAMETER, "pid");
         return NULL;
     }
 
@@ -385,7 +385,7 @@ GuestExec *qmp_guest_exec(const char *path,
                        bool has_env, strList *env,
                        bool has_input_data, const char *input_data,
                        bool has_capture_output, bool capture_output,
-                       Error **err)
+                       Error **errp)
 {
     GPid pid;
     GuestExec *ge = NULL;
@@ -405,7 +405,7 @@ GuestExec *qmp_guest_exec(const char *path,
     arglist.next = has_arg ? arg : NULL;
 
     if (has_input_data) {
-        input = qbase64_decode(input_data, -1, &ninput, err);
+        input = qbase64_decode(input_data, -1, &ninput, errp);
         if (!input) {
             return NULL;
         }
@@ -424,7 +424,7 @@ GuestExec *qmp_guest_exec(const char *path,
             guest_exec_task_setup, NULL, &pid, has_input_data ? &in_fd : NULL,
             has_output ? &out_fd : NULL, has_output ? &err_fd : NULL, &gerr);
     if (!ret) {
-        error_setg(err, QERR_QGA_COMMAND_FAILED, gerr->message);
+        error_setg(errp, QERR_QGA_COMMAND_FAILED, gerr->message);
         g_error_free(gerr);
         goto done;
     }
@@ -499,7 +499,7 @@ int ga_parse_whence(GuestFileWhence *whence, Error **errp)
     return -1;
 }
 
-GuestHostName *qmp_guest_get_host_name(Error **err)
+GuestHostName *qmp_guest_get_host_name(Error **errp)
 {
     GuestHostName *result = NULL;
     gchar const *hostname = g_get_host_name();
-- 
2.21.0



  parent reply	other threads:[~2019-12-18  8:35 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-18  8:16 [PULL v2 00/35] Error reporting patches for 2019-12-17 Markus Armbruster
2019-12-18  8:16 ` [PULL v2 01/35] error: Fix -msg timestamp default Markus Armbruster
2019-12-18  8:16 ` [PULL v2 02/35] crypto: Fix certificate file error handling crash bug Markus Armbruster
2019-12-18  8:16 ` [PULL v2 03/35] crypto: Fix typo in QCryptoTLSSession's <example> comment Markus Armbruster
2019-12-18  8:16 ` [PULL v2 04/35] io: Fix Error usage in a comment <example> Markus Armbruster
2019-12-18  8:16 ` [PULL v2 05/35] tests: Clean up initialization of Error *err variables Markus Armbruster
2019-12-18  8:16 ` [PULL v2 06/35] exec: Fix file_ram_alloc() error API violations Markus Armbruster
2019-12-18  8:16 ` [PULL v2 07/35] hw/acpi: Fix legacy CPU plug " Markus Armbruster
2019-12-18  8:16 ` [PULL v2 08/35] hw/core: Fix fit_load_fdt() " Markus Armbruster
2019-12-18  8:16 ` [PULL v2 09/35] hw/ipmi: Fix realize() " Markus Armbruster
2019-12-18  8:16 ` [PULL v2 10/35] qga: Fix guest-get-fsinfo " Markus Armbruster
2019-12-18  8:16 ` [PULL v2 11/35] memory-device: Fix memory pre-plug " Markus Armbruster
2019-12-18  8:16 ` [PULL v2 12/35] error: Clean up unusual names of Error * variables Markus Armbruster
2019-12-18  8:16 ` [PULL v2 13/35] hw/intc/s390: Simplify error handling in kvm_s390_flic_realize() Markus Armbruster
2019-12-18  8:17 ` [PULL v2 14/35] tests-blockjob: Use error_free_or_abort() Markus Armbruster
2019-12-18  8:17 ` [PULL v2 15/35] net/net: Clean up variable shadowing in net_client_init() Markus Armbruster
2019-12-18  8:17 ` [PULL v2 16/35] error: make Error **errp const where it is appropriate Markus Armbruster
2019-12-18  8:17 ` [PULL v2 17/35] hmp: drop Error pointer indirection in hmp_handle_error Markus Armbruster
2019-12-18  8:17 ` [PULL v2 18/35] vnc: drop Error pointer indirection in vnc_client_io_error Markus Armbruster
2019-12-18  8:17 ` [PULL v2 19/35] qdev-monitor: make Error **errp const where it is appropriate Markus Armbruster
2019-12-18  8:17 ` [PULL v2 20/35] Revert "ppc: well form kvmppc_hint_smt_possible error hint helper" Markus Armbruster
2019-12-18  8:17 ` [PULL v2 21/35] ppc: make Error **errp const where it is appropriate Markus Armbruster
2019-12-18  8:17 ` [PULL v2 22/35] 9pfs: " Markus Armbruster
2019-12-18  8:17 ` [PULL v2 23/35] hw/core/qdev: cleanup Error ** variables Markus Armbruster
2019-12-18  8:17 ` [PULL v2 24/35] block/snapshot: rename Error ** parameter to more common errp Markus Armbruster
2019-12-18  8:17 ` [PULL v2 25/35] hw/i386/amd_iommu: " Markus Armbruster
2019-12-18  8:17 ` Markus Armbruster [this message]
2019-12-18  8:17 ` [PULL v2 27/35] monitor/qmp-cmds: " Markus Armbruster
2019-12-18  8:17 ` [PULL v2 28/35] hw/s390x: " Markus Armbruster
2019-12-18  8:17 ` [PULL v2 29/35] hw/sd: drop extra whitespace in sdhci_sysbus_realize() header Markus Armbruster
2019-12-18  8:17 ` [PULL v2 30/35] hw/tpm: rename Error ** parameter to more common errp Markus Armbruster
2019-12-18  8:17 ` [PULL v2 31/35] hw/usb: " Markus Armbruster
2019-12-18  8:17 ` [PULL v2 32/35] include/qom/object.h: " Markus Armbruster
2019-12-18  8:17 ` [PULL v2 33/35] backends/cryptodev: drop local_err from cryptodev_backend_complete() Markus Armbruster
2019-12-18  8:17 ` [PULL v2 34/35] hw/vfio/ap: drop local_err from vfio_ap_realize Markus Armbruster
2019-12-18  8:17 ` [PULL v2 35/35] nbd: assert that Error** is not NULL in nbd_iter_channel_error Markus Armbruster
2019-12-20 11:20 ` [PULL v2 00/35] Error reporting patches for 2019-12-17 Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191218081721.23520-27-armbru@redhat.com \
    --to=armbru@redhat.com \
    --cc=philmd@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=vsementsov@virtuozzo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).