qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Markus Armbruster <armbru@redhat.com>
To: qemu-devel@nongnu.org
Cc: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>,
	Cornelia Huck <cohuck@redhat.com>
Subject: [PULL v2 34/35] hw/vfio/ap: drop local_err from vfio_ap_realize
Date: Wed, 18 Dec 2019 09:17:20 +0100	[thread overview]
Message-ID: <20191218081721.23520-35-armbru@redhat.com> (raw)
In-Reply-To: <20191218081721.23520-1-armbru@redhat.com>

From: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>

No reason for local_err here, use errp directly instead.

Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
Message-Id: <20191205174635.18758-21-vsementsov@virtuozzo.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
 hw/vfio/ap.c | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

diff --git a/hw/vfio/ap.c b/hw/vfio/ap.c
index da6a20669d..8fbaa724c2 100644
--- a/hw/vfio/ap.c
+++ b/hw/vfio/ap.c
@@ -89,14 +89,13 @@ static void vfio_ap_realize(DeviceState *dev, Error **errp)
 {
     int ret;
     char *mdevid;
-    Error *local_err = NULL;
     VFIOGroup *vfio_group;
     APDevice *apdev = AP_DEVICE(dev);
     VFIOAPDevice *vapdev = VFIO_AP_DEVICE(apdev);
 
-    vfio_group = vfio_ap_get_group(vapdev, &local_err);
+    vfio_group = vfio_ap_get_group(vapdev, errp);
     if (!vfio_group) {
-        goto out_err;
+        return;
     }
 
     vapdev->vdev.ops = &vfio_ap_ops;
@@ -113,7 +112,7 @@ static void vfio_ap_realize(DeviceState *dev, Error **errp)
      */
     vapdev->vdev.balloon_allowed = true;
 
-    ret = vfio_get_device(vfio_group, mdevid, &vapdev->vdev, &local_err);
+    ret = vfio_get_device(vfio_group, mdevid, &vapdev->vdev, errp);
     if (ret) {
         goto out_get_dev_err;
     }
@@ -123,8 +122,6 @@ static void vfio_ap_realize(DeviceState *dev, Error **errp)
 out_get_dev_err:
     vfio_ap_put_device(vapdev);
     vfio_put_group(vfio_group);
-out_err:
-    error_propagate(errp, local_err);
 }
 
 static void vfio_ap_unrealize(DeviceState *dev, Error **errp)
-- 
2.21.0



  parent reply	other threads:[~2019-12-18  8:45 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-18  8:16 [PULL v2 00/35] Error reporting patches for 2019-12-17 Markus Armbruster
2019-12-18  8:16 ` [PULL v2 01/35] error: Fix -msg timestamp default Markus Armbruster
2019-12-18  8:16 ` [PULL v2 02/35] crypto: Fix certificate file error handling crash bug Markus Armbruster
2019-12-18  8:16 ` [PULL v2 03/35] crypto: Fix typo in QCryptoTLSSession's <example> comment Markus Armbruster
2019-12-18  8:16 ` [PULL v2 04/35] io: Fix Error usage in a comment <example> Markus Armbruster
2019-12-18  8:16 ` [PULL v2 05/35] tests: Clean up initialization of Error *err variables Markus Armbruster
2019-12-18  8:16 ` [PULL v2 06/35] exec: Fix file_ram_alloc() error API violations Markus Armbruster
2019-12-18  8:16 ` [PULL v2 07/35] hw/acpi: Fix legacy CPU plug " Markus Armbruster
2019-12-18  8:16 ` [PULL v2 08/35] hw/core: Fix fit_load_fdt() " Markus Armbruster
2019-12-18  8:16 ` [PULL v2 09/35] hw/ipmi: Fix realize() " Markus Armbruster
2019-12-18  8:16 ` [PULL v2 10/35] qga: Fix guest-get-fsinfo " Markus Armbruster
2019-12-18  8:16 ` [PULL v2 11/35] memory-device: Fix memory pre-plug " Markus Armbruster
2019-12-18  8:16 ` [PULL v2 12/35] error: Clean up unusual names of Error * variables Markus Armbruster
2019-12-18  8:16 ` [PULL v2 13/35] hw/intc/s390: Simplify error handling in kvm_s390_flic_realize() Markus Armbruster
2019-12-18  8:17 ` [PULL v2 14/35] tests-blockjob: Use error_free_or_abort() Markus Armbruster
2019-12-18  8:17 ` [PULL v2 15/35] net/net: Clean up variable shadowing in net_client_init() Markus Armbruster
2019-12-18  8:17 ` [PULL v2 16/35] error: make Error **errp const where it is appropriate Markus Armbruster
2019-12-18  8:17 ` [PULL v2 17/35] hmp: drop Error pointer indirection in hmp_handle_error Markus Armbruster
2019-12-18  8:17 ` [PULL v2 18/35] vnc: drop Error pointer indirection in vnc_client_io_error Markus Armbruster
2019-12-18  8:17 ` [PULL v2 19/35] qdev-monitor: make Error **errp const where it is appropriate Markus Armbruster
2019-12-18  8:17 ` [PULL v2 20/35] Revert "ppc: well form kvmppc_hint_smt_possible error hint helper" Markus Armbruster
2019-12-18  8:17 ` [PULL v2 21/35] ppc: make Error **errp const where it is appropriate Markus Armbruster
2019-12-18  8:17 ` [PULL v2 22/35] 9pfs: " Markus Armbruster
2019-12-18  8:17 ` [PULL v2 23/35] hw/core/qdev: cleanup Error ** variables Markus Armbruster
2019-12-18  8:17 ` [PULL v2 24/35] block/snapshot: rename Error ** parameter to more common errp Markus Armbruster
2019-12-18  8:17 ` [PULL v2 25/35] hw/i386/amd_iommu: " Markus Armbruster
2019-12-18  8:17 ` [PULL v2 26/35] qga: " Markus Armbruster
2019-12-18  8:17 ` [PULL v2 27/35] monitor/qmp-cmds: " Markus Armbruster
2019-12-18  8:17 ` [PULL v2 28/35] hw/s390x: " Markus Armbruster
2019-12-18  8:17 ` [PULL v2 29/35] hw/sd: drop extra whitespace in sdhci_sysbus_realize() header Markus Armbruster
2019-12-18  8:17 ` [PULL v2 30/35] hw/tpm: rename Error ** parameter to more common errp Markus Armbruster
2019-12-18  8:17 ` [PULL v2 31/35] hw/usb: " Markus Armbruster
2019-12-18  8:17 ` [PULL v2 32/35] include/qom/object.h: " Markus Armbruster
2019-12-18  8:17 ` [PULL v2 33/35] backends/cryptodev: drop local_err from cryptodev_backend_complete() Markus Armbruster
2019-12-18  8:17 ` Markus Armbruster [this message]
2019-12-18  8:17 ` [PULL v2 35/35] nbd: assert that Error** is not NULL in nbd_iter_channel_error Markus Armbruster
2019-12-20 11:20 ` [PULL v2 00/35] Error reporting patches for 2019-12-17 Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191218081721.23520-35-armbru@redhat.com \
    --to=armbru@redhat.com \
    --cc=cohuck@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=vsementsov@virtuozzo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).