From: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, qemu-block@nongnu.org, armbru@redhat.com,
mreitz@redhat.com, nsoffer@redhat.com
Subject: [PATCH] qapi/block: fix nbd-server-add spec
Date: Thu, 19 Dec 2019 17:34:15 +0300 [thread overview]
Message-ID: <20191219143415.28490-1-vsementsov@virtuozzo.com> (raw)
"NAME" here may be interpreted like it should match @name, which is
export name. But it was never mentioned in such way. Make it obvious,
that actual "<dirty-bitmap-export-name>" (see docs/interop/nbd.txt)
will match @bitmap parameter.
Fixes: 5fcbeb06812685a2
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
---
Hi all.
This patch follows discussion on Nir's patch
[PATCH] block: nbd: Fix dirty bitmap context name
( https://lists.gnu.org/archive/html/qemu-devel/2019-12/msg04309.html )
Let's just fix qapi spec now.
qapi/block.json | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/qapi/block.json b/qapi/block.json
index 145c268bb6..8042ef78f0 100644
--- a/qapi/block.json
+++ b/qapi/block.json
@@ -255,7 +255,8 @@
# @bitmap: Also export the dirty bitmap reachable from @device, so the
# NBD client can use NBD_OPT_SET_META_CONTEXT with
-# "qemu:dirty-bitmap:NAME" to inspect the bitmap. (since 4.0)
+# "qemu:dirty-bitmap:BITMAP" to inspect the bitmap (BITMAP here
+# matches @bitmap parameter). (since 4.0)
#
# Returns: error if the server is not running, or export with the same name
# already exists.
--
2.21.0
next reply other threads:[~2019-12-19 14:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-19 14:34 Vladimir Sementsov-Ogievskiy [this message]
2019-12-19 14:42 ` [PATCH] qapi/block: fix nbd-server-add spec Nir Soffer
2019-12-19 15:00 ` Vladimir Sementsov-Ogievskiy
2019-12-19 15:08 ` Nir Soffer
2019-12-19 15:25 ` Vladimir Sementsov-Ogievskiy
2019-12-19 16:14 ` Nir Soffer
2019-12-20 9:25 ` Vladimir Sementsov-Ogievskiy
2019-12-20 22:04 ` Eric Blake
2019-12-25 16:13 ` Vladimir Sementsov-Ogievskiy
2019-12-20 21:58 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191219143415.28490-1-vsementsov@virtuozzo.com \
--to=vsementsov@virtuozzo.com \
--cc=armbru@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=nsoffer@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).