Re: [PATCH 3/3] iotests: Test external snapshot with VM state

[Kevin Wolf <kwolf@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 2020 bytes --]

Am 19.12.2019 um 15:26 hat Max Reitz geschrieben:
> On 17.12.19 15:59, Kevin Wolf wrote:
> > This tests creating an external snapshot with VM state (which results in
> > an active overlay over an inactive backing file, which is also the root
> > node of an inactive BlockBackend), re-activating the images and
> > performing some operations to test that the re-activation worked as
> > intended.
> > 
> > Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> 
> [...]
> 
> > diff --git a/tests/qemu-iotests/280.out b/tests/qemu-iotests/280.out
> > new file mode 100644
> > index 0000000000..5d382faaa8
> > --- /dev/null
> > +++ b/tests/qemu-iotests/280.out
> > @@ -0,0 +1,50 @@
> > +Formatting 'TEST_DIR/PID-base', fmt=qcow2 size=67108864 cluster_size=65536 lazy_refcounts=off refcount_bits=16
> > +
> > +=== Launch VM ===
> > +Enabling migration QMP events on VM...
> > +{"return": {}}
> > +
> > +=== Migrate to file ===
> > +{"execute": "migrate", "arguments": {"uri": "exec:cat > /dev/null"}}
> > +{"return": {}}
> > +{"data": {"status": "setup"}, "event": "MIGRATION", "timestamp": {"microseconds": "USECS", "seconds": "SECS"}}
> > +{"data": {"status": "active"}, "event": "MIGRATION", "timestamp": {"microseconds": "USECS", "seconds": "SECS"}}
> > +{"data": {"status": "completed"}, "event": "MIGRATION", "timestamp": {"microseconds": "USECS", "seconds": "SECS"}}
> > +
> > +VM is now stopped:
> > +completed
> > +{"execute": "query-status", "arguments": {}}
> > +{"return": {"running": false, "singlestep": false, "status": "postmigrate"}}
> 
> Hmmm, I get a finish-migrate status here (on tmpfs)...

Dave, is it intentional that the "completed" migration event is emitted
while we are still in finish-migration rather than postmigrate?

I guess we could change wait_migration() in qemu-iotests to wait for the
postmigrate state rather than the "completed" event, but maybe it would
be better to change the migration code to avoid similar races in other
QMP clients.

Kevin

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]