From: "Maxiwell S. Garcia" <maxiwell@linux.ibm.com>
To: qemu-ppc@nongnu.org
Cc: farosas@linux.ibm.com, qemu-devel@nongnu.org,
"Maxiwell S. Garcia" <maxiwell@linux.ibm.com>,
david@gibson.dropbear.id.au
Subject: [PATCH] target/ppc: fix memory dump endianness in QEMU monitor
Date: Thu, 19 Dec 2019 13:38:54 -0300 [thread overview]
Message-ID: <20191219163854.8945-1-maxiwell@linux.ibm.com> (raw)
The env->hflags is computed in ppc_cpu_reset(), using the MSR register
as input. But at the point ppc_disas_set_info() is called the MSR_LE bit
in env->hflags doesn't contain the same information that env->msr.
Signed-off-by: Maxiwell S. Garcia <maxiwell@linux.ibm.com>
Signed-off-by: Fabiano Rosas <farosas@linux.ibm.com>
---
target/ppc/translate_init.inc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target/ppc/translate_init.inc.c b/target/ppc/translate_init.inc.c
index d33d65dff7..a0b384da9e 100644
--- a/target/ppc/translate_init.inc.c
+++ b/target/ppc/translate_init.inc.c
@@ -10830,7 +10830,7 @@ static void ppc_disas_set_info(CPUState *cs, disassemble_info *info)
PowerPCCPU *cpu = POWERPC_CPU(cs);
CPUPPCState *env = &cpu->env;
- if ((env->hflags >> MSR_LE) & 1) {
+ if (msr_le) {
info->endian = BFD_ENDIAN_LITTLE;
}
info->mach = env->bfd_mach;
--
2.20.1
next reply other threads:[~2019-12-19 16:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-19 16:38 Maxiwell S. Garcia [this message]
2019-12-23 6:30 ` [PATCH] target/ppc: fix memory dump endianness in QEMU monitor David Gibson
2019-12-23 21:35 ` Maxiwell S. Garcia
2019-12-24 5:10 ` David Gibson
2019-12-23 23:27 ` Fabiano Rosas
2019-12-24 5:19 ` David Gibson
2019-12-24 16:10 ` Fabiano Rosas
2019-12-26 1:54 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191219163854.8945-1-maxiwell@linux.ibm.com \
--to=maxiwell@linux.ibm.com \
--cc=david@gibson.dropbear.id.au \
--cc=farosas@linux.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).