From: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
To: qemu-devel@nongnu.org, Niek Linnenbank <nieklinnenbank@gmail.com>
Cc: "Beniamino Galvani" <b.galvani@gmail.com>,
"Peter Maydell" <peter.maydell@linaro.org>,
qemu-arm@nongnu.org, "Philippe Mathieu-Daudé" <f4bug@amsat.org>
Subject: [RFC PATCH 13/13] hw/timer/allwinner: Rename functions not specific to the A10 SoC
Date: Thu, 19 Dec 2019 19:51:27 +0100 [thread overview]
Message-ID: <20191219185127.24388-14-f4bug@amsat.org> (raw)
In-Reply-To: <20191219185127.24388-1-f4bug@amsat.org>
These functions are used by different Allwinner timer controllers,
rename them.
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
hw/timer/allwinner-a10-pit.c | 52 ++++++++++++++++++------------------
1 file changed, 26 insertions(+), 26 deletions(-)
diff --git a/hw/timer/allwinner-a10-pit.c b/hw/timer/allwinner-a10-pit.c
index 7413f046cc..dff534cfef 100644
--- a/hw/timer/allwinner-a10-pit.c
+++ b/hw/timer/allwinner-a10-pit.c
@@ -68,7 +68,7 @@ typedef struct AllwinnerTmrCtrlClass {
#define AW_TIMER_GET_CLASS(obj) \
OBJECT_GET_CLASS(AllwinnerTmrCtrlClass, (obj), TYPE_AW_COMMON_PIT)
-static void a10_pit_update_irq(AllwinnerTmrCtrlState *s)
+static void allwinner_timer_update_irq(AllwinnerTmrCtrlState *s)
{
int i;
@@ -78,7 +78,7 @@ static void a10_pit_update_irq(AllwinnerTmrCtrlState *s)
}
}
-static uint64_t a10_pit_read(void *opaque, hwaddr offset, unsigned size)
+static uint64_t allwinner_timer_read(void *opaque, hwaddr offset, unsigned size)
{
AllwinnerTmrCtrlState *s = AW_TIMER_CTRL(opaque);
uint8_t index;
@@ -125,7 +125,7 @@ static uint64_t a10_pit_read(void *opaque, hwaddr offset, unsigned size)
}
/* Must be called inside a ptimer transaction block for s->timer[idx].ptimer */
-static void a10_pit_set_freq(AllwinnerTmrCtrlState *s, int index)
+static void allwinner_ptimer_set_freq(AllwinnerTmrCtrlState *s, int index)
{
uint32_t prescaler, source, source_freq;
@@ -141,8 +141,8 @@ static void a10_pit_set_freq(AllwinnerTmrCtrlState *s, int index)
}
}
-static void a10_pit_write(void *opaque, hwaddr offset, uint64_t value,
- unsigned size)
+static void allwinner_timer_write(void *opaque, hwaddr offset,
+ uint64_t value, unsigned size)
{
AllwinnerTmrCtrlState *s = AW_TIMER_CTRL(opaque);
uint8_t index;
@@ -150,11 +150,11 @@ static void a10_pit_write(void *opaque, hwaddr offset, uint64_t value,
switch (offset) {
case AW_A10_PIT_TIMER_IRQ_EN:
s->irq_enable = value;
- a10_pit_update_irq(s);
+ allwinner_timer_update_irq(s);
break;
case AW_A10_PIT_TIMER_IRQ_ST:
s->irq_status &= ~value;
- a10_pit_update_irq(s);
+ allwinner_timer_update_irq(s);
break;
case AW_A10_PIT_TIMER_BASE ... AW_A10_PIT_TIMER_BASE_END:
index = offset & 0xf0;
@@ -164,7 +164,7 @@ static void a10_pit_write(void *opaque, hwaddr offset, uint64_t value,
case AW_A10_PIT_TIMER_CONTROL:
s->timer[index].control = value;
ptimer_transaction_begin(s->timer[index].ptimer);
- a10_pit_set_freq(s, index);
+ allwinner_ptimer_set_freq(s, index);
if (s->timer[index].control & AW_A10_PIT_TIMER_RELOAD) {
ptimer_set_count(s->timer[index].ptimer,
s->timer[index].interval);
@@ -229,13 +229,13 @@ static void a10_pit_write(void *opaque, hwaddr offset, uint64_t value,
}
}
-static const MemoryRegionOps a10_pit_ops = {
- .read = a10_pit_read,
- .write = a10_pit_write,
+static const MemoryRegionOps allwinner_timer_ops = {
+ .read = allwinner_timer_read,
+ .write = allwinner_timer_write,
.endianness = DEVICE_NATIVE_ENDIAN,
};
-static Property a10_pit_properties[] = {
+static Property allwinner_timer_properties[] = {
DEFINE_PROP_UINT32("clk0-freq", AllwinnerTmrCtrlState, clk_freq[0], 0),
DEFINE_PROP_UINT32("clk1-freq", AllwinnerTmrCtrlState, clk_freq[1], 0),
DEFINE_PROP_UINT32("clk2-freq", AllwinnerTmrCtrlState, clk_freq[2], 0),
@@ -276,14 +276,14 @@ static const VMStateDescription vmstate_a10_pit = {
}
};
-static void a10_pit_reset(DeviceState *dev)
+static void allwinner_timer_reset(DeviceState *dev)
{
AllwinnerTmrCtrlState *s = AW_TIMER_CTRL(dev);
uint8_t i;
s->irq_enable = 0;
s->irq_status = 0;
- a10_pit_update_irq(s);
+ allwinner_timer_update_irq(s);
for (i = 0; i < s->timer_count; i++) {
s->timer[i].control = AW_A10_PIT_DEFAULT_CLOCK;
@@ -291,7 +291,7 @@ static void a10_pit_reset(DeviceState *dev)
s->timer[i].count = 0;
ptimer_transaction_begin(s->timer[i].ptimer);
ptimer_stop(s->timer[i].ptimer);
- a10_pit_set_freq(s, i);
+ allwinner_ptimer_set_freq(s, i);
ptimer_transaction_commit(s->timer[i].ptimer);
}
s->watch_dog_mode = 0;
@@ -301,7 +301,7 @@ static void a10_pit_reset(DeviceState *dev)
s->count_ctl = 0;
}
-static void a10_pit_timer_cb(void *opaque)
+static void allwinner_ptimer_cb(void *opaque)
{
AllwinnerTmrState *tc = opaque;
AllwinnerTmrCtrlState *s = tc->container;
@@ -313,11 +313,11 @@ static void a10_pit_timer_cb(void *opaque)
ptimer_stop(s->timer[i].ptimer);
s->timer[i].control &= ~AW_A10_PIT_TIMER_EN;
}
- a10_pit_update_irq(s);
+ allwinner_timer_update_irq(s);
}
}
-static void aw_pit_instance_init(Object *obj)
+static void allwinner_timer_instance_init(Object *obj)
{
AllwinnerTmrCtrlState *s = AW_TIMER_CTRL(obj);
AllwinnerTmrCtrlClass *c = AW_TIMER_GET_CLASS(s);
@@ -329,8 +329,8 @@ static void aw_pit_instance_init(Object *obj)
for (i = 0; i < s->timer_count; i++) {
sysbus_init_irq(sbd, &s->timer[i].irq);
}
- memory_region_init_io(&s->iomem, OBJECT(s), &a10_pit_ops, s,
- TYPE_AW_COMMON_PIT, c->region_size);
+ memory_region_init_io(&s->iomem, OBJECT(s), &allwinner_timer_ops,
+ s, TYPE_AW_COMMON_PIT, c->region_size);
sysbus_init_mmio(sbd, &s->iomem);
for (i = 0; i < s->timer_count; i++) {
@@ -338,7 +338,7 @@ static void aw_pit_instance_init(Object *obj)
tc->container = s;
tc->index = i;
- s->timer[i].ptimer = ptimer_init(a10_pit_timer_cb, tc,
+ s->timer[i].ptimer = ptimer_init(allwinner_ptimer_cb, tc,
PTIMER_POLICY_DEFAULT);
}
}
@@ -347,8 +347,8 @@ static void aw_timer_class_init(ObjectClass *klass, void *data)
{
DeviceClass *dc = DEVICE_CLASS(klass);
- dc->reset = a10_pit_reset;
- dc->props = a10_pit_properties;
+ dc->reset = allwinner_timer_reset;
+ dc->props = allwinner_timer_properties;
dc->desc = "Allwinner Timer Controller";
dc->vmsd = &vmstate_a10_pit;
}
@@ -356,7 +356,7 @@ static void aw_timer_class_init(ObjectClass *klass, void *data)
static const TypeInfo allwinner_pit_info = {
.name = TYPE_AW_COMMON_PIT,
.parent = TYPE_SYS_BUS_DEVICE,
- .instance_init = aw_pit_instance_init,
+ .instance_init = allwinner_timer_instance_init,
.instance_size = sizeof(AllwinnerTmrCtrlState),
.class_init = aw_timer_class_init,
.class_size = sizeof(AllwinnerTmrCtrlClass),
@@ -379,10 +379,10 @@ static const TypeInfo a10_pit_info = {
.class_init = a10_pit_class_init,
};
-static void a10_register_types(void)
+static void allwinner_timer_register_types(void)
{
type_register_static(&allwinner_pit_info);
type_register_static(&a10_pit_info);
}
-type_init(a10_register_types);
+type_init(allwinner_timer_register_types);
--
2.21.0
next prev parent reply other threads:[~2019-12-19 19:09 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-19 18:51 [RFC PATCH 00/13] hw/timer/allwinner: Make it reusable Philippe Mathieu-Daudé
2019-12-19 18:51 ` [PATCH 01/13] hw/timer/allwinner: Use the AW_A10_PIT_TIMER_NR definition Philippe Mathieu-Daudé
2019-12-20 21:19 ` Niek Linnenbank
2019-12-19 18:51 ` [PATCH 02/13] hw/timer/allwinner: Add AW_PIT_TIMER_MAX definition Philippe Mathieu-Daudé
2019-12-20 21:27 ` Niek Linnenbank
2019-12-19 18:51 ` [PATCH 03/13] hw/timer/allwinner: Remove unused definitions Philippe Mathieu-Daudé
2019-12-20 21:36 ` Niek Linnenbank
2019-12-19 18:51 ` [PATCH 04/13] hw/timer/allwinner: Move definitions from header to source Philippe Mathieu-Daudé
2019-12-20 21:41 ` Niek Linnenbank
2019-12-19 18:51 ` [RFC PATCH 05/13] hw/timer/allwinner: Rename the ptimer field Philippe Mathieu-Daudé
2019-12-19 18:51 ` [RFC PATCH 06/13] hw/timer/allwinner: Rename 'timer_context' as 'timer' Philippe Mathieu-Daudé
2019-12-19 18:51 ` [RFC PATCH 07/13] hw/timer/allwinner: Move timer specific fields into AwA10TimerContext Philippe Mathieu-Daudé
2019-12-19 18:51 ` [RFC PATCH 08/13] hw/timer/allwinner: Add a timer_count field Philippe Mathieu-Daudé
2019-12-19 18:51 ` [RFC PATCH 09/13] hw/timer/allwinner: Rename AwA10TimerContext as AllwinnerTmrState Philippe Mathieu-Daudé
2019-12-19 18:51 ` [RFC PATCH 10/13] hw/timer/allwinner: Rename AwA10PITState as AllwinnerTmrCtrlState Philippe Mathieu-Daudé
2019-12-19 18:51 ` [RFC PATCH 11/13] hw/timer/allwinner: Introduce TYPE_AW_COMMON_PIT abstract device Philippe Mathieu-Daudé
2019-12-20 21:11 ` Niek Linnenbank
2019-12-19 18:51 ` [RFC PATCH 12/13] hw/timer/allwinner: Rename AW_A10_PIT() as AW_TIMER_CTRL() Philippe Mathieu-Daudé
2019-12-19 18:51 ` Philippe Mathieu-Daudé [this message]
2019-12-20 20:53 ` [RFC PATCH 00/13] hw/timer/allwinner: Make it reusable Niek Linnenbank
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191219185127.24388-14-f4bug@amsat.org \
--to=f4bug@amsat.org \
--cc=b.galvani@gmail.com \
--cc=nieklinnenbank@gmail.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).