qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Laurent Vivier <laurent@vivier.eu>
To: qemu-devel@nongnu.org
Cc: "Philippe Mathieu-Daudé" <philmd@redhat.com>,
	"Mark Cave-Ayland" <mark.cave-ayland@ilande.co.uk>,
	"Laurent Vivier" <laurent@vivier.eu>
Subject: [PATCH 0/2] q800: fix and improve RTC/PRAM interface
Date: Thu, 19 Dec 2019 21:14:37 +0100	[thread overview]
Message-ID: <20191219201439.84804-1-laurent@vivier.eu> (raw)

A bug has been reported on launchpad about an error
reported by cc:

  qemu-4.2.0/hw/misc/mac_via.c:467:27: style: Expression is
  always false because 'else if' condition matches previous
  condition at line 463. [multiCondition]

  https://bugs.launchpad.net/qemu/+bug/1856549

In fact, the PRAM interface has not really been tested and
has several problems that needed to be fixed.

This series makes a cleanup in this part of code and
fix existing problems.

It also adds some trace-events that helped to debug the
numerous issues and a backend file to allow to save and
restore the content of the PRAM.

This has been tested by playing with the /dev/nvram interface
in the guest, checking we can read what we have written, and
we can read and write in the file on host and read and write
the same data in the guest /dev/nvram.

Laurent Vivier (2):
  q800: fix mac_via RTC PRAM commands
  q800: add a block backend to the PRAM

 hw/m68k/q800.c            |   6 +
 hw/misc/mac_via.c         | 339 ++++++++++++++++++++++++++++----------
 hw/misc/trace-events      |  19 +++
 include/hw/misc/mac_via.h |   3 +
 4 files changed, 284 insertions(+), 83 deletions(-)

-- 
2.24.1



             reply	other threads:[~2019-12-19 20:17 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-19 20:14 Laurent Vivier [this message]
2019-12-19 20:14 ` [PATCH 1/2] q800: fix mac_via RTC PRAM commands Laurent Vivier
2019-12-22 11:07   ` Mark Cave-Ayland
2019-12-19 20:14 ` [PATCH 2/2] q800: add a block backend to the PRAM Laurent Vivier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191219201439.84804-1-laurent@vivier.eu \
    --to=laurent@vivier.eu \
    --cc=mark.cave-ayland@ilande.co.uk \
    --cc=philmd@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).