qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Alex Bennée" <alex.bennee@linaro.org>
To: qemu-devel@nongnu.org
Cc: "Richard Henderson" <richard.henderson@linaro.org>,
	keithp@keithp.com, "open list:ARM TCG CPUs" <qemu-arm@nongnu.org>,
	"Alex Bennée" <alex.bennee@linaro.org>,
	"Peter Maydell" <peter.maydell@linaro.org>
Subject: [PATCH  v2 1/5] target/arm: remove unused EXCP_SEMIHOST leg
Date: Fri, 20 Dec 2019 13:22:42 +0000	[thread overview]
Message-ID: <20191220132246.6759-2-alex.bennee@linaro.org> (raw)
In-Reply-To: <20191220132246.6759-1-alex.bennee@linaro.org>

All semihosting exceptions are dealt with earlier in the common code
so we should never get here.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Keith Packard <keithp@keithp.com>
Tested-by: Keith Packard <keithp@keithp.com>
---
 target/arm/helper.c | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/target/arm/helper.c b/target/arm/helper.c
index 5074b5f69ca..b4dc2274c8b 100644
--- a/target/arm/helper.c
+++ b/target/arm/helper.c
@@ -8554,12 +8554,6 @@ static void arm_cpu_do_interrupt_aarch64(CPUState *cs)
     case EXCP_VFIQ:
         addr += 0x100;
         break;
-    case EXCP_SEMIHOST:
-        qemu_log_mask(CPU_LOG_INT,
-                      "...handling as semihosting call 0x%" PRIx64 "\n",
-                      env->xregs[0]);
-        env->xregs[0] = do_arm_semihosting(env);
-        return;
     default:
         cpu_abort(cs, "Unhandled exception 0x%x\n", cs->exception_index);
     }
-- 
2.20.1



  reply	other threads:[~2019-12-20 13:27 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-20 13:22 [PATCH v2 0/5] semihosting read console support Alex Bennée
2019-12-20 13:22 ` Alex Bennée [this message]
2019-12-20 13:22 ` [PATCH v2 2/5] target/arm: only update pc after semihosting completes Alex Bennée
2019-12-20 13:22 ` [PATCH v2 3/5] semihosting: add qemu_semihosting_console_inc for SYS_READC Alex Bennée
2019-12-29  2:58   ` Richard Henderson
2019-12-20 13:22 ` [PATCH v2 4/5] tests/tcg: add a dumb-as-bricks semihosting console test Alex Bennée
2019-12-29  2:57   ` Richard Henderson
2019-12-20 13:22 ` [PATCH v2 5/5] tests/tcg: add user version of dumb-as-bricks semiconsole test Alex Bennée
2019-12-29  2:55   ` Richard Henderson
2020-01-07 14:27     ` Alex Bennée
2020-01-08  1:13       ` Richard Henderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191220132246.6759-2-alex.bennee@linaro.org \
    --to=alex.bennee@linaro.org \
    --cc=keithp@keithp.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).