From: "Daniel P. Berrangé" <berrange@redhat.com>
To: "Marc-André Lureau" <marcandre.lureau@redhat.com>
Cc: mprivozn@redhat.com, quintela@redhat.com, qemu-devel@nongnu.org,
dgilbert@redhat.com, pbonzini@redhat.com
Subject: Re: [PATCH v7 8/9] tests: add migration-helpers unit
Date: Fri, 20 Dec 2019 14:10:32 +0000 [thread overview]
Message-ID: <20191220141032.GO1699760@redhat.com> (raw)
In-Reply-To: <20191219123029.200788-9-marcandre.lureau@redhat.com>
On Thu, Dec 19, 2019 at 04:30:28PM +0400, Marc-André Lureau wrote:
> Move a few helper functions from migration-test.c to migration-helpers.c
>
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
> tests/Makefile.include | 2 +-
> tests/migration-helpers.c | 167 ++++++++++++++++++++++++++++++++++++
> tests/migration-helpers.h | 37 ++++++++
> tests/migration-test.c | 176 +++-----------------------------------
> 4 files changed, 216 insertions(+), 166 deletions(-)
> create mode 100644 tests/migration-helpers.c
> create mode 100644 tests/migration-helpers.h
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2019-12-20 14:21 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-19 12:30 [PATCH v7 0/9] Add dbus-vmstate Marc-André Lureau
2019-12-19 12:30 ` [PATCH v7 1/9] vmstate: add qom interface to get id Marc-André Lureau
2019-12-19 12:30 ` [PATCH v7 2/9] vmstate: replace DeviceState with VMStateIf Marc-André Lureau
2019-12-19 12:30 ` [PATCH v7 3/9] docs: start a document to describe D-Bus usage Marc-André Lureau
2019-12-20 14:02 ` Daniel P. Berrangé
2019-12-19 12:30 ` [PATCH v7 4/9] util: add dbus helper unit Marc-André Lureau
2019-12-20 14:03 ` Daniel P. Berrangé
2019-12-19 12:30 ` [PATCH v7 5/9] Add dbus-vmstate object Marc-André Lureau
2019-12-20 14:09 ` Daniel P. Berrangé
2019-12-19 12:30 ` [PATCH v7 6/9] configure: add GDBUS_CODEGEN Marc-André Lureau
2019-12-19 12:30 ` [PATCH v7 7/9] dockerfiles: add dbus-daemon to some of latest distributions Marc-André Lureau
2019-12-19 12:30 ` [PATCH v7 8/9] tests: add migration-helpers unit Marc-André Lureau
2019-12-20 14:10 ` Daniel P. Berrangé [this message]
2019-12-19 12:30 ` [PATCH v7 9/9] tests: add dbus-vmstate-test Marc-André Lureau
2019-12-20 14:14 ` Daniel P. Berrangé
2019-12-20 14:28 ` Marc-André Lureau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191220141032.GO1699760@redhat.com \
--to=berrange@redhat.com \
--cc=dgilbert@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=mprivozn@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).