From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4A148C2D0C0 for ; Mon, 23 Dec 2019 16:58:46 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 152D020715 for ; Mon, 23 Dec 2019 16:58:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="KBqDA0Aw" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 152D020715 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:58974 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ijR2a-0007MM-QG for qemu-devel@archiver.kernel.org; Mon, 23 Dec 2019 11:58:44 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:41647) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ijQn7-00054l-GX for qemu-devel@nongnu.org; Mon, 23 Dec 2019 11:42:46 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ijQn5-0005iN-Dn for qemu-devel@nongnu.org; Mon, 23 Dec 2019 11:42:45 -0500 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:37769 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ijQn5-0005iE-9z for qemu-devel@nongnu.org; Mon, 23 Dec 2019 11:42:43 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1577119362; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mD5CnKaHCqEnDtYsfaWuvKKdqaTymxgk4zlUTmpGAA8=; b=KBqDA0AwJ9hW+fc9ASMLxSW5Ze/7oY8rOVzJxgXUXf1s2qNLFpnnXWfGwskI/zaHibdHKR MSZnXtCtuxQVB6DSjfw9Z9nHUQD1mAErVc7PjlPhIvQfoTOLrJjoEu+likB9/bTC/zOxSp 1LHDDOB5rd37aKzk6HLM/UpzibAYtEE= Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-52-GKzStXjcMaSv7k3f6c2quQ-1; Mon, 23 Dec 2019 11:42:41 -0500 Received: by mail-qk1-f197.google.com with SMTP id 12so11438670qkf.20 for ; Mon, 23 Dec 2019 08:42:40 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=zrcV6NduOW424RfDjQAFC57USpEMc62nbflawLr92Qk=; b=KGZVOKqfCjnewssqMp8Zft/mycfLSsFsgt1/LLwl2UIE7lo2VOxy1i2dlQ3f9BQZ/m YjSFfEXDZ4OvBG8b9gLtspGo61Ap8wLRrLo6SWp0AYYSDvIND1rbRt1mqHW7G5gwLcOL YRKcJ1QJG8s9F01GKf1dN1c2VeWQeG4iC6ZqH8YExY5tjWiBWVBA3o9mPvrjDvCUIb3J UZkm5VzG+CBsKkjaDW37WV0Kcwca5B361aR0NEgUyzEa8Fqll5XZY4ZIXtmFi0xxHHvC rO7LhNdHwkvbMVtmSzlmKJAnIXr7r2EPfv/yTtetcpSx4xWbApB7mbvYbobc7LM1iDah yNgg== X-Gm-Message-State: APjAAAV8qSfh30GiiSMnEd9ALR1lhS2shpdZmkSvfxpOhVziJQAsKlxx 5FYTMAlFyJ6RM5IVQenaTb8mTxqdEn0Hck3hFpFFvtcnctLZoLjMFPQOLMauBrXn97i1NVZXIlQ lP7Egv7NayuycB78= X-Received: by 2002:ac8:a8b:: with SMTP id d11mr23047146qti.94.1577119359584; Mon, 23 Dec 2019 08:42:39 -0800 (PST) X-Google-Smtp-Source: APXvYqxx+1NDB7gL0INz6uTkRQNbgwDYq3IrTFl5zw1CLCSJ012S4cUNyrqbSiKU6YlfMLW3deiOeg== X-Received: by 2002:ac8:a8b:: with SMTP id d11mr23047138qti.94.1577119359416; Mon, 23 Dec 2019 08:42:39 -0800 (PST) Received: from redhat.com (bzq-109-64-31-13.red.bezeqint.net. [109.64.31.13]) by smtp.gmail.com with ESMTPSA id k22sm5952522qkg.80.2019.12.23.08.42.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Dec 2019 08:42:38 -0800 (PST) Date: Mon, 23 Dec 2019 11:42:35 -0500 From: "Michael S. Tsirkin" To: qemu-devel@nongnu.org Subject: [PULL v2 22/27] hw/pci/pci_host: Let pci_data_[read/write] use unsigned 'size' argument Message-ID: <20191223141536.72682-23-mst@redhat.com> References: <20191223141536.72682-1-mst@redhat.com> MIME-Version: 1.0 In-Reply-To: <20191223141536.72682-1-mst@redhat.com> X-Mailer: git-send-email 2.24.1.751.gd10ce2899c X-Mutt-Fcc: =sent X-MC-Unique: GKzStXjcMaSv7k3f6c2quQ-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 205.139.110.120 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" From: Philippe Mathieu-Daud=C3=A9 Both functions are called by MemoryRegionOps.[read/write] handlers with unsigned 'size' argument. Both functions call pci_host_config_[read/write]_common() which expect a uint32_t 'len' parameter (also unsigned). Since it is pointless (and confuse) to use a signed value, use a unsigned type. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Message-Id: <20191216002134.18279-3-philmd@redhat.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- include/hw/pci/pci_host.h | 4 ++-- hw/pci/pci_host.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/include/hw/pci/pci_host.h b/include/hw/pci/pci_host.h index ba31595fc7..9ce088bd13 100644 --- a/include/hw/pci/pci_host.h +++ b/include/hw/pci/pci_host.h @@ -62,8 +62,8 @@ void pci_host_config_write_common(PCIDevice *pci_dev, uin= t32_t addr, uint32_t pci_host_config_read_common(PCIDevice *pci_dev, uint32_t addr, uint32_t limit, uint32_t len); =20 -void pci_data_write(PCIBus *s, uint32_t addr, uint32_t val, int len); -uint32_t pci_data_read(PCIBus *s, uint32_t addr, int len); +void pci_data_write(PCIBus *s, uint32_t addr, uint32_t val, unsigned len); +uint32_t pci_data_read(PCIBus *s, uint32_t addr, unsigned len); =20 extern const MemoryRegionOps pci_host_conf_le_ops; extern const MemoryRegionOps pci_host_conf_be_ops; diff --git a/hw/pci/pci_host.c b/hw/pci/pci_host.c index 0958d157de..ce7bcdb1d5 100644 --- a/hw/pci/pci_host.c +++ b/hw/pci/pci_host.c @@ -106,7 +106,7 @@ uint32_t pci_host_config_read_common(PCIDevice *pci_dev= , uint32_t addr, return ret; } =20 -void pci_data_write(PCIBus *s, uint32_t addr, uint32_t val, int len) +void pci_data_write(PCIBus *s, uint32_t addr, uint32_t val, unsigned len) { PCIDevice *pci_dev =3D pci_dev_find_by_addr(s, addr); uint32_t config_addr =3D addr & (PCI_CONFIG_SPACE_SIZE - 1); @@ -119,7 +119,7 @@ void pci_data_write(PCIBus *s, uint32_t addr, uint32_t = val, int len) val, len); } =20 -uint32_t pci_data_read(PCIBus *s, uint32_t addr, int len) +uint32_t pci_data_read(PCIBus *s, uint32_t addr, unsigned len) { PCIDevice *pci_dev =3D pci_dev_find_by_addr(s, addr); uint32_t config_addr =3D addr & (PCI_CONFIG_SPACE_SIZE - 1); --=20 MST