qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Richard Henderson <richard.henderson@linaro.org>
To: qemu-devel@nongnu.org
Cc: "Max Filippov" <jcmvbkbc@gmail.com>,
	"Alex Bennée" <alex.bennee@linaro.org>,
	"Philippe Mathieu-Daudé" <philmd@redhat.com>
Subject: [PATCH v3 01/29] target/xtensa: Use probe_access for itlb_hit_test
Date: Sun, 29 Dec 2019 10:10:56 +1100	[thread overview]
Message-ID: <20191228231124.18307-2-richard.henderson@linaro.org> (raw)
In-Reply-To: <20191228231124.18307-1-richard.henderson@linaro.org>

We don't actually need the result of the read, only to probe that the
memory mapping exists.  This is exactly what probe_access does.

This is also the only user of any cpu_ld*_code_ra function.
Removing this allows the interface to be removed shortly.

Acked-by: Max Filippov <jcmvbkbc@gmail.com>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
 target/xtensa/mmu_helper.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/target/xtensa/mmu_helper.c b/target/xtensa/mmu_helper.c
index f15bff306f..b01ff9399a 100644
--- a/target/xtensa/mmu_helper.c
+++ b/target/xtensa/mmu_helper.c
@@ -63,10 +63,11 @@
 void HELPER(itlb_hit_test)(CPUXtensaState *env, uint32_t vaddr)
 {
     /*
-     * Attempt the memory load; we don't care about the result but
+     * Probe the memory; we don't care about the result but
      * only the side-effects (ie any MMU or other exception)
      */
-    cpu_ldub_code_ra(env, vaddr, GETPC());
+    probe_access(env, vaddr, 1, MMU_INST_FETCH,
+                 cpu_mmu_index(env, true), GETPC());
 }
 
 void HELPER(wsr_rasid)(CPUXtensaState *env, uint32_t v)
-- 
2.20.1



  reply	other threads:[~2019-12-28 23:15 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-28 23:10 [PATCH v3 00/29] cputlb: Remove support for MMU_MODE*_SUFFIX Richard Henderson
2019-12-28 23:10 ` Richard Henderson [this message]
2019-12-28 23:10 ` [PATCH v3 02/29] cputlb: Use trace_mem_get_info instead of trace_mem_build_info Richard Henderson
2019-12-28 23:10 ` [PATCH v3 03/29] trace: Remove trace_mem_build_info_no_se_[bl]e Richard Henderson
2019-12-28 23:10 ` [PATCH v3 04/29] target/s390x: Include tcg.h in mem_helper.c Richard Henderson
2019-12-28 23:11 ` [PATCH v3 05/29] target/arm: Include tcg.h in sve_helper.c Richard Henderson
2019-12-28 23:11 ` [PATCH v3 06/29] accel/tcg: Include tcg.h in tcg-runtime.c Richard Henderson
2019-12-28 23:11 ` [PATCH v3 07/29] linux-user: Include tcg.h in syscall.c Richard Henderson
2019-12-29 23:31   ` Philippe Mathieu-Daudé
2019-12-28 23:11 ` [PATCH v3 08/29] linux-user: Include trace-root.h in syscall-trace.h Richard Henderson
2019-12-29 23:52   ` Philippe Mathieu-Daudé
2019-12-28 23:11 ` [PATCH v3 09/29] plugins: Include trace/mem.h in api.c Richard Henderson
2020-01-03  6:22   ` Philippe Mathieu-Daudé
2020-01-03 21:59     ` Richard Henderson
2020-01-04 11:52       ` Philippe Mathieu-Daudé
2019-12-28 23:11 ` [PATCH v3 10/29] cputlb: Move body of cpu_ldst_template.h out of line Richard Henderson
2019-12-28 23:11 ` [PATCH v3 11/29] translator: Use cpu_ld*_code instead of open-coding Richard Henderson
2019-12-28 23:11 ` [PATCH v3 12/29] cputlb: Rename helper_ret_ld*_cmmu to cpu_ld*_code Richard Henderson
2019-12-28 23:11 ` [PATCH v3 13/29] cputlb: Provide cpu_(ld, st}*_mmuidx_ra for user-only Richard Henderson
2019-12-29 15:20   ` Aleksandar Markovic
2019-12-28 23:11 ` [PATCH v3 14/29] target/i386: Use cpu_*_mmuidx_ra instead of templates Richard Henderson
2019-12-28 23:11 ` [PATCH v3 15/29] cputlb: Expand cpu_ldst_useronly_template.h in user-exec.c Richard Henderson
2019-12-28 23:11 ` [PATCH v3 16/29] target/nios2: Remove MMU_MODE{0,1}_SUFFIX Richard Henderson
2019-12-28 23:11 ` [PATCH v3 17/29] target/alpha: " Richard Henderson
2019-12-28 23:11 ` [PATCH v3 18/29] target/cris: " Richard Henderson
2019-12-28 23:11 ` [PATCH v3 19/29] target/i386: Remove MMU_MODE{0,1,2}_SUFFIX Richard Henderson
2019-12-28 23:11 ` [PATCH v3 20/29] target/microblaze: " Richard Henderson
2019-12-28 23:11 ` [PATCH v3 21/29] target/sh4: Remove MMU_MODE{0,1}_SUFFIX Richard Henderson
2019-12-28 23:11 ` [PATCH v3 22/29] target/unicore32: " Richard Henderson
2019-12-28 23:11 ` [PATCH v3 23/29] target/xtensa: Remove MMU_MODE{0,1,2,3}_SUFFIX Richard Henderson
2019-12-28 23:11 ` [PATCH v3 24/29] target/m68k: Use cpu_*_mmuidx_ra instead of MMU_MODE{0, 1}_SUFFIX Richard Henderson
2019-12-28 23:11 ` [PATCH v3 25/29] target/mips: Use cpu_*_mmuidx_ra instead of MMU_MODE*_SUFFIX Richard Henderson
2019-12-28 23:11 ` [PATCH v3 26/29] target/s390x: " Richard Henderson
2019-12-28 23:11 ` [PATCH v3 27/29] target/ppc: " Richard Henderson
2019-12-28 23:11 ` [PATCH v3 28/29] cputlb: Remove support for MMU_MODE*_SUFFIX Richard Henderson
2019-12-28 23:11 ` [PATCH v3 29/29] cputlb: Expand cpu_ldst_template.h in cputlb.c Richard Henderson
2020-01-04 14:40 ` [PATCH v3 00/29] cputlb: Remove support for MMU_MODE*_SUFFIX Philippe Mathieu-Daudé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191228231124.18307-2-richard.henderson@linaro.org \
    --to=richard.henderson@linaro.org \
    --cc=alex.bennee@linaro.org \
    --cc=jcmvbkbc@gmail.com \
    --cc=philmd@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).