From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:41488)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mlureau@redhat.com>) id 1ZvqaC-0000WG-Va
	for qemu-devel@nongnu.org; Mon, 09 Nov 2015 12:50:21 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mlureau@redhat.com>) id 1Zvqa8-0001Jz-Q7
	for qemu-devel@nongnu.org; Mon, 09 Nov 2015 12:50:20 -0500
Received: from mx4-phx2.redhat.com ([209.132.183.25]:52507)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mlureau@redhat.com>) id 1Zvqa8-0001Js-Jp
	for qemu-devel@nongnu.org; Mon, 09 Nov 2015 12:50:16 -0500
Date: Mon, 9 Nov 2015 12:50:14 -0500 (EST)
From: =?utf-8?Q?Marc-Andr=C3=A9?= Lureau <mlureau@redhat.com>
Message-ID: <2019295173.5692962.1447091414607.JavaMail.zimbra@redhat.com>
In-Reply-To: <CAFEAcA_+bSdNJ3qJHNtp1mh-mRZaLv3Li6UP35ERzkTurPUudg@mail.gmail.com>
References: <1447063704-24893-1-git-send-email-stefanha@redhat.com>
	<CAFEAcA-0BTMomvhDHif+d2c2CzvinwnBQMDyXnLXod9BCnX1xw@mail.gmail.com>
	<CAFEAcA-DXrYrMPWYkYPdp6TOYfbfN=S8ne7znCa7S0KQZ_4LTw@mail.gmail.com>
	<1053612416.5612384.1447081777119.JavaMail.zimbra@redhat.com>
	<CAFEAcA_+bSdNJ3qJHNtp1mh-mRZaLv3Li6UP35ERzkTurPUudg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PULL v2 0/7] Block patches
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: =?utf-8?Q?Marc-Andr=C3=A9?= Lureau <marcandre.lureau@redhat.com>, QEMU Developers <qemu-devel@nongnu.org>, Stefan Hajnoczi <stefanha@redhat.com>

Hi

----- Original Message -----
> On 9 November 2015 at 15:09, Marc-Andr=C3=A9 Lureau <mlureau@redhat.com> =
wrote:
> >> On 9 November 2015 at 12:51, Peter Maydell <peter.maydell@linaro.org>
> >> wrote:
> >> Marc-Andr=C3=A9, can you look into why the ivshmem tests might be
> >> intermittently
> >> failing like this, please?
> >
> > Is this with an slow or emulated host? It could be that the 5s timeout
> > is not enough?
>=20
> This is with the 32-bit build on a 64-bit ARM server box. So it's
> not the fastest machine in the world, but it's not bad either.
> It will be using TCG, obviously.
>=20
> A test which takes 5 seconds to run isn't ideal from a "keep
> the make-check time down" perspective either.

I can imagine a test starting a server thread and 2 qemu instances would ta=
ke more than 5s on such configuration then.

Could you try timing the test a few times to confirm this?

If it's too long, I suggest we move it to g_test_slow(), and perhaps get ri=
d of the timer.=20

thanks