From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Cc: alex.bennee@linaro.org, f4bug@amsat.org
Subject: Re: [PATCH] build: make meson-buildoptions.sh stable
Date: Mon, 6 Feb 2023 15:55:55 +0100 [thread overview]
Message-ID: <201bfdcb-85d9-fbd3-0dfe-9b67efb92596@linaro.org> (raw)
In-Reply-To: <20230206123247.16814-1-pbonzini@redhat.com>
On 6/2/23 13:32, Paolo Bonzini wrote:
> The library directory can change depending on the multilib setup of the host.
> It would be even better to detect it in configure with the same algorithm
> that Meson uses, but the important thing to avoid confusing developers is
> to have identical contents of scripts/meson-buildoptions.sh, independent
> of the distro and architecture on which it was created.
>
> So, for now just give a custom default value to libdir.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> scripts/meson-buildoptions.py | 7 +++++--
> scripts/meson-buildoptions.sh | 2 +-
> 2 files changed, 6 insertions(+), 3 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
prev parent reply other threads:[~2023-02-06 14:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-06 12:32 [PATCH] build: make meson-buildoptions.sh stable Paolo Bonzini
2023-02-06 13:22 ` Alex Bennée
2023-02-06 14:55 ` Philippe Mathieu-Daudé [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201bfdcb-85d9-fbd3-0dfe-9b67efb92596@linaro.org \
--to=philmd@linaro.org \
--cc=alex.bennee@linaro.org \
--cc=f4bug@amsat.org \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).