From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Palmer Dabbelt <palmer@sifive.com>,
qemu-devel@nongnu.org, qemu-riscv@nongnu.org
Subject: Re: [Qemu-devel] [PATCH for-3.1 1/2] MAINTAINERS: Any file with "riscv" in the name is a RISC-V file
Date: Thu, 22 Nov 2018 01:29:09 +0100 [thread overview]
Message-ID: <201f1cf4-30af-03c5-393b-0eab6ac7eb87@redhat.com> (raw)
In-Reply-To: <20181121234651.24596-1-palmer@sifive.com>
On 22/11/18 0:46, Palmer Dabbelt wrote:
> There was a recent thread about unmaintained files in QEMU where it was
> noted that a few RISC-V related files had slipped through the patterns
> in our MAINTAINERS file entry. This patch adds some more aggressive
> pattern matching in an attempt to rectify this situation.
>
> Signed-off-by: Palmer Dabbelt <palmer@sifive.com>
> ---
> MAINTAINERS | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 1032406c5607..e89adc81d5d5 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -255,6 +255,8 @@ F: target/riscv/
> F: hw/riscv/
> F: include/hw/riscv/
> F: disas/riscv.c
> +K: riscv
> +N: riscv
QEMU doesn't support the 'N' tag.
I see from the Linux kernel:
N: Files and directories with regex patterns.
N: [^a-z]tegra all files whose path contains the word tegra
One pattern per line. Multiple N: lines acceptable.
scripts/get_maintainer.pl has different behavior for files that
match F: pattern and matches of N: patterns. By default,
get_maintainer will not look at git log history when an F: pattern
match occurs. When an N: match occurs, git log history is used
to also notify the people that have git commit signatures.
Should we add this feature to checkscript?
>
> S390
> M: Richard Henderson <rth@twiddle.net>
>
next prev parent reply other threads:[~2018-11-22 0:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-21 23:46 [Qemu-devel] [PATCH for-3.1 1/2] MAINTAINERS: Any file with "riscv" in the name is a RISC-V file Palmer Dabbelt
2018-11-21 23:46 ` [Qemu-devel] [PATCH for-3.1 2/2] MAINTAINERS: Mark RISC-V as Supported Palmer Dabbelt
2018-11-22 2:10 ` Alistair Francis
2018-11-22 0:29 ` Philippe Mathieu-Daudé [this message]
2018-11-22 1:44 ` [Qemu-devel] [PATCH for-3.1 1/2] MAINTAINERS: Any file with "riscv" in the name is a RISC-V file Palmer Dabbelt
2018-11-22 9:09 ` Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201f1cf4-30af-03c5-393b-0eab6ac7eb87@redhat.com \
--to=philmd@redhat.com \
--cc=palmer@sifive.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-riscv@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).