From: David Gibson <david@gibson.dropbear.id.au>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>
Cc: "Fam Zheng" <fam@euphon.net>,
"Eduardo Habkost" <ehabkost@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Jason Wang" <jasowang@redhat.com>,
"Mark Cave-Ayland" <mark.cave-ayland@ilande.co.uk>,
qemu-devel@nongnu.org, "Artyom Tarasenko" <atar4qemu@gmail.com>,
"Aleksandar Markovic" <amarkovic@wavecomp.com>,
"Hervé Poussineau" <hpoussin@reactos.org>,
qemu-ppc@nongnu.org, "Gerd Hoffmann" <kraxel@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Aleksandar Rikalo" <aleksandar.rikalo@rt-rk.com>,
"Aurelien Jarno" <aurelien@aurel32.net>,
"Richard Henderson" <rth@twiddle.net>
Subject: Re: [PATCH 10/14] hw/ppc/Kconfig: Only select fw_cfg with machines using OpenBIOS
Date: Thu, 2 Jan 2020 13:05:44 +1100 [thread overview]
Message-ID: <20200102020544.GG2098@umbus> (raw)
In-Reply-To: <20191231183216.6781-11-philmd@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 2005 bytes --]
On Tue, Dec 31, 2019 at 07:32:12PM +0100, Philippe Mathieu-Daudé wrote:
> The fw_cfg helpers are only used by machines using OpenBIOS.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Acked-by: David Gibson <david@gibson.dropbear.id.au>
> ---
> Cc: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
> Cc: "Hervé Poussineau" <hpoussin@reactos.org>
> ---
> hw/ppc/Kconfig | 6 ++++++
> hw/ppc/Makefile.objs | 3 ++-
> 2 files changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/hw/ppc/Kconfig b/hw/ppc/Kconfig
> index d8482a5e99..e4ca920507 100644
> --- a/hw/ppc/Kconfig
> +++ b/hw/ppc/Kconfig
> @@ -72,6 +72,7 @@ config PREP
> select M48T59
> select PC87312
> select RS6000_MC
> + select FW_CFG_PPC
>
> config RS6000_MC
> bool
> @@ -85,6 +86,7 @@ config MAC_OLDWORLD
> select GRACKLE_PCI
> select HEATHROW_PIC
> select MACIO
> + select FW_CFG_PPC
>
> config MAC_NEWWORLD
> bool
> @@ -96,6 +98,7 @@ config MAC_NEWWORLD
> select MACIO_GPIO
> select MAC_PMU
> select UNIN_PCI
> + select FW_CFG_PPC
>
> config E500
> bool
> @@ -130,3 +133,6 @@ config XIVE_KVM
> bool
> default y
> depends on XIVE_SPAPR && KVM
> +
> +config FW_CFG_PPC
> + bool
> diff --git a/hw/ppc/Makefile.objs b/hw/ppc/Makefile.objs
> index 79adf06aa3..5c46c68e44 100644
> --- a/hw/ppc/Makefile.objs
> +++ b/hw/ppc/Makefile.objs
> @@ -1,5 +1,6 @@
> # shared objects
> -obj-y += ppc.o ppc_booke.o fdt.o fw_cfg.o
> +obj-y += ppc.o ppc_booke.o fdt.o
> +obj-$(CONFIG_FW_CFG_PPC) += fw_cfg.o
> # IBM pSeries (sPAPR)
> obj-$(CONFIG_PSERIES) += spapr.o spapr_caps.o spapr_vio.o spapr_events.o
> obj-$(CONFIG_PSERIES) += spapr_hcall.o spapr_iommu.o spapr_rtas.o
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2020-01-02 2:24 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-31 18:32 [PATCH 00/14] hw: Fix various --without-default-devices issues Philippe Mathieu-Daudé
2019-12-31 18:32 ` [PATCH 01/14] hw/usb/redirect: Do not link 'usb-redir' device when USB not enabled Philippe Mathieu-Daudé
2020-01-07 12:24 ` Thomas Huth
2019-12-31 18:32 ` [PATCH 02/14] hw/intc/i8259: Fix Kconfig dependency on ISA bus Philippe Mathieu-Daudé
2020-01-07 12:28 ` Thomas Huth
2019-12-31 18:32 ` [PATCH 03/14] hw/i386/Kconfig: Let the MicroVM machine select the SERIAL_ISA config Philippe Mathieu-Daudé
2020-01-07 10:00 ` Paolo Bonzini
2020-01-07 10:06 ` Philippe Mathieu-Daudé
2019-12-31 18:32 ` [PATCH 04/14] hw/i386: Restrict fw_cfg to the PC machines Philippe Mathieu-Daudé
2020-01-07 10:00 ` Paolo Bonzini
2020-01-07 10:01 ` Paolo Bonzini
2020-01-07 10:07 ` Philippe Mathieu-Daudé
2020-01-07 10:16 ` Michael S. Tsirkin
2020-01-07 12:22 ` Paolo Bonzini
2019-12-31 18:32 ` [PATCH 05/14] hw/i2c/Kconfig: Add an entry for the SMBus Philippe Mathieu-Daudé
2019-12-31 19:16 ` Corey Minyard
2020-01-01 10:25 ` Philippe Mathieu-Daudé
2020-01-01 16:15 ` Corey Minyard
2020-01-01 16:21 ` Philippe Mathieu-Daudé
2019-12-31 18:32 ` [PATCH 06/14] hw/ppc/Kconfig: Restrict the MPC I2C controller to e500-based platforms Philippe Mathieu-Daudé
2020-01-02 2:03 ` David Gibson
2019-12-31 18:32 ` [PATCH 07/14] hw/ppc/Kconfig: Let the Sam460ex board use the PowerPC 405 devices Philippe Mathieu-Daudé
2020-01-01 11:29 ` BALATON Zoltan
2020-01-01 15:37 ` Philippe Mathieu-Daudé
2020-01-02 2:03 ` David Gibson
2019-12-31 18:32 ` [PATCH 08/14] hw/ppc/Kconfig: Let the Xilinx Virtex5 ML507 use the PPC-440 devices Philippe Mathieu-Daudé
2020-01-02 2:04 ` David Gibson
2019-12-31 18:32 ` [PATCH 09/14] hw/ppc/Makefile: Simplify the sPAPR PCI objects rule Philippe Mathieu-Daudé
2020-01-02 2:05 ` David Gibson
2019-12-31 18:32 ` [PATCH 10/14] hw/ppc/Kconfig: Only select fw_cfg with machines using OpenBIOS Philippe Mathieu-Daudé
2020-01-02 2:05 ` David Gibson [this message]
2019-12-31 18:32 ` [PATCH 11/14] hw/ppc/Kconfig: Only select FDT helper for machines using it Philippe Mathieu-Daudé
2020-01-02 2:06 ` David Gibson
2019-12-31 18:32 ` [PATCH 12/14] hw/nvram/Kconfig: Add an entry for the NMC93xx EEPROM Philippe Mathieu-Daudé
2020-01-01 10:31 ` Philippe Mathieu-Daudé
2020-01-07 10:08 ` Paolo Bonzini
2019-12-31 18:32 ` [PATCH 13/14] hw/nvram/Kconfig: Restrict CHRP NVRAM to machines using OpenBIOS or SLOF Philippe Mathieu-Daudé
2020-01-02 2:07 ` David Gibson
2019-12-31 18:32 ` [RFC PATCH 14/14] hw/intc/Kconfig: Let APIC select IOAPIC Philippe Mathieu-Daudé
2020-01-07 9:58 ` Paolo Bonzini
2020-01-07 10:11 ` [PATCH 00/14] hw: Fix various --without-default-devices issues Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200102020544.GG2098@umbus \
--to=david@gibson.dropbear.id.au \
--cc=aleksandar.rikalo@rt-rk.com \
--cc=amarkovic@wavecomp.com \
--cc=atar4qemu@gmail.com \
--cc=aurelien@aurel32.net \
--cc=ehabkost@redhat.com \
--cc=fam@euphon.net \
--cc=hpoussin@reactos.org \
--cc=jasowang@redhat.com \
--cc=kraxel@redhat.com \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).