From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
To: Juan Quintela <quintela@redhat.com>
Cc: "Laurent Vivier" <lvivier@redhat.com>,
"Thomas Huth" <thuth@redhat.com>,
"Daniel P. Berrangé" <berrange@redhat.com>,
"Eduardo Habkost" <ehabkost@redhat.com>,
qemu-devel@nongnu.org, "Markus Armbruster" <armbru@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>
Subject: Re: [PATCH v2 01/10] migration: Increase default number of multifd channels to 16
Date: Fri, 3 Jan 2020 16:51:21 +0000 [thread overview]
Message-ID: <20200103165121.GM3804@work-vm> (raw)
In-Reply-To: <20191218020119.3776-2-quintela@redhat.com>
* Juan Quintela (quintela@redhat.com) wrote:
> We can scale much better with 16, so we can scale to higher numbers.
>
> Signed-off-by: Juan Quintela <quintela@redhat.com>
> ---
> migration/migration.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/migration/migration.c b/migration/migration.c
> index 354ad072fa..e7f707e033 100644
> --- a/migration/migration.c
> +++ b/migration/migration.c
> @@ -86,7 +86,7 @@
>
> /* The delay time (in ms) between two COLO checkpoints */
> #define DEFAULT_MIGRATE_X_CHECKPOINT_DELAY (200 * 100)
> -#define DEFAULT_MIGRATE_MULTIFD_CHANNELS 2
> +#define DEFAULT_MIGRATE_MULTIFD_CHANNELS 16
OK, I suspect the management apps will set it anyway; some could be a
bit surprised chewing 16 cores/threads of CPU in some cases.
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> /* Background transfer rate for postcopy, 0 means unlimited, note
> * that page requests can still exceed this limit.
> --
> 2.23.0
>
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
next prev parent reply other threads:[~2020-01-03 16:52 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-18 2:01 [PATCH v2 00/10] Multifd Migration Compression Juan Quintela
2019-12-18 2:01 ` [PATCH v2 01/10] migration: Increase default number of multifd channels to 16 Juan Quintela
2020-01-03 16:51 ` Dr. David Alan Gilbert [this message]
2020-01-03 16:58 ` Daniel P. Berrangé
2020-01-03 17:01 ` Dr. David Alan Gilbert
2020-01-03 17:12 ` Daniel P. Berrangé
2020-01-03 17:32 ` Dr. David Alan Gilbert
2020-01-03 18:25 ` Juan Quintela
2020-01-07 12:49 ` Daniel P. Berrangé
2020-01-07 13:32 ` Juan Quintela
2020-01-07 13:42 ` Daniel P. Berrangé
2020-01-03 17:49 ` Daniel P. Berrangé
2019-12-18 2:01 ` [PATCH v2 02/10] migration-test: Add migration multifd test Juan Quintela
2019-12-18 2:01 ` [PATCH v2 03/10] migration-test: introduce functions to handle string parameters Juan Quintela
2020-01-03 16:57 ` Dr. David Alan Gilbert
2019-12-18 2:01 ` [PATCH v2 04/10] migration: Make multifd_save_setup() get an Error parameter Juan Quintela
2020-01-03 16:46 ` Dr. David Alan Gilbert
2020-01-07 12:35 ` Juan Quintela
2019-12-18 2:01 ` [PATCH v2 05/10] migration: Make multifd_load_setup() " Juan Quintela
2020-01-03 17:22 ` Dr. David Alan Gilbert
2020-01-07 13:00 ` Juan Quintela
2019-12-18 2:01 ` [PATCH v2 06/10] migration: Add multifd-compress parameter Juan Quintela
2019-12-19 7:41 ` Markus Armbruster
2020-01-03 17:57 ` Dr. David Alan Gilbert
2020-01-07 13:03 ` Juan Quintela
2019-12-18 2:01 ` [PATCH v2 07/10] migration: Make no compression operations into its own structure Juan Quintela
2020-01-03 18:20 ` Dr. David Alan Gilbert
2020-01-07 13:08 ` Juan Quintela
2019-12-18 2:01 ` [PATCH v2 08/10] migration: Add zlib compression multifd support Juan Quintela
2019-12-18 2:01 ` [PATCH v2 09/10] configure: Enable test and libs for zstd Juan Quintela
2019-12-18 2:01 ` [PATCH v2 10/10] migration: Add zstd compression multifd support Juan Quintela
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200103165121.GM3804@work-vm \
--to=dgilbert@redhat.com \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=ehabkost@redhat.com \
--cc=lvivier@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).