From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 81C18C33C8C for ; Sun, 5 Jan 2020 12:55:16 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4D0CE20866 for ; Sun, 5 Jan 2020 12:55:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="eOS1ylfL" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4D0CE20866 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:41714 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1io5R5-00083r-EA for qemu-devel@archiver.kernel.org; Sun, 05 Jan 2020 07:55:15 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:57641) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1io5Px-0007Ho-3y for qemu-devel@nongnu.org; Sun, 05 Jan 2020 07:54:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1io5Pv-0007Dg-2c for qemu-devel@nongnu.org; Sun, 05 Jan 2020 07:54:04 -0500 Received: from us-smtp-2.mimecast.com ([205.139.110.61]:58346 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1io5Pu-0007AW-U3 for qemu-devel@nongnu.org; Sun, 05 Jan 2020 07:54:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1578228842; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ofOgKIJGQmYYlJvJEtar4z1ANhqjstHJaxxlbxxFsR0=; b=eOS1ylfL/cesZvI4Xfak0tDAWuyxMqTllwTo6zYJS/MyS9UUyDZP1/V8DO8HZAkRw2RznM bYqu9syBsLLS0e09NPzzvur6xVLgXOEx9MyNcociEWuubGZNbG7hZ6woFWZbB6+DFjmUh5 1cXlZAQv7iqsNed64lxcwz9qrKid0WE= Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-276-wOooEyusMfapj_f5OHbMMw-1; Sun, 05 Jan 2020 07:54:00 -0500 Received: by mail-qt1-f200.google.com with SMTP id l56so32598265qtk.11 for ; Sun, 05 Jan 2020 04:54:00 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=Vxo46B2oj+YCTfA3i4ixkh8kVV8Fpgnabmgxa9H/c0M=; b=ACKq497bTKk19JjF95mJlNvkE1uuKR2f78mWhN9HoNY+tJeQTL6EmXfzu6wIU7qH8S xbD6Jv4g9EH2FZVr1WU1SoFJJtyxQqOFQv59JQdLqS6aoH2P0H2e/1byX1tdvlEJzWM2 z/P5OOoD9PUgDvzWBupibNbomlIYHlxiHxYtLoOjOKJpuAXMwAYT9sMAaWHcdAxrVX33 zGFnwk5M+JxytzDEeQdqiMtx3YRUUp7iaYkcicKXXH6b2hfHXYTvTE9eACGnKgku39ML dqSwdd7R4/fUZR4MJcGWUq0FEl9MNCC/m1aYxu4ZkzyUMaNV3uvwG95qB0X50C0nuVoA XdbA== X-Gm-Message-State: APjAAAVJD9wW0q/rp8IJKsxP5Q7p1h6DA3CjIZouR+ApJpIr5jUWIONj p9gJ7joNKla1X+FgpWGoKA23G00k/SphRa4IDBc05fVSEj/axHX9A8eHMDsWGlSTURaua5w537P YcZuxwOylZVJ48vQ= X-Received: by 2002:ae9:e10e:: with SMTP id g14mr80913294qkm.430.1578228840251; Sun, 05 Jan 2020 04:54:00 -0800 (PST) X-Google-Smtp-Source: APXvYqxnZg6RPg6VO6daf7utzCy42WOLd+7iXP9oNyDG2nShDNA9AlZSBFccJyj+axm8nnNgY756mw== X-Received: by 2002:ae9:e10e:: with SMTP id g14mr80913276qkm.430.1578228839798; Sun, 05 Jan 2020 04:53:59 -0800 (PST) Received: from redhat.com (bzq-79-183-34-164.red.bezeqint.net. [79.183.34.164]) by smtp.gmail.com with ESMTPSA id t3sm21769324qtc.8.2020.01.05.04.53.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 05 Jan 2020 04:53:59 -0800 (PST) Date: Sun, 5 Jan 2020 07:53:53 -0500 From: "Michael S. Tsirkin" To: Heyi Guo Subject: Re: [PATCH 2/2] arm/virt/acpi: remove _ADR from devices identified by _HID Message-ID: <20200105074308-mutt-send-email-mst@kernel.org> References: <20191219064759.35053-1-guoheyi@huawei.com> <20191219064759.35053-3-guoheyi@huawei.com> <20200105072504-mutt-send-email-mst@kernel.org> MIME-Version: 1.0 In-Reply-To: <20200105072504-mutt-send-email-mst@kernel.org> X-MC-Unique: wOooEyusMfapj_f5OHbMMw-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 205.139.110.61 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Corey Minyard , qemu-devel@nongnu.org, Shannon Zhao , qemu-arm@nongnu.org, Igor Mammedov , wanghaibin.wang@huawei.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Sun, Jan 05, 2020 at 07:34:01AM -0500, Michael S. Tsirkin wrote: > On Thu, Dec 19, 2019 at 02:47:59PM +0800, Heyi Guo wrote: > > According to ACPI spec, _ADR should be used for device which is on a > > bus that has a standard enumeration algorithm. It does not make sense > > to have a _ADR object for devices which already have _HID and will be > > enumerated by OSPM. > >=20 > > Signed-off-by: Heyi Guo >=20 > Are you sure? I would think this depends on the ID and the device > really. E.g. PCI devices all are expected to have _ADR and some of them > have a _HID. To clarify I am not commenting on patches. The spec says this: =096.1.5 _HID (Hardware ID) =09This object is used to supply OSPM with the device=E2=80=99s PNP ID or A= CPI ID. 1 =09When describing a platform, use of any _HID objects is optional. However= , a _HID object must be =09used to describe any device that will be enumerated by OSPM. OSPM only e= numerates a device =09when no bus enumerator can detect the device ID. For example, devices on= an ISA bus are =09enumerated by OSPM. Use the _ADR object to describe devices enumerated b= y bus enumerators =09other than OSPM. Note: "detect the device ID" not "enumerate the device" which I think means there's a driver matching this vendor/device ID. So it seems fine to have _ADR so device is enumerated, and still have _HID e.g. so ACPI driver can be loaded as fallback if there's no bus driver. Note I am not saying the patch itself is not correct. Maybe these devices are not on any standard bus and that is why they should not have _ADR? I have not looked. I am just saying that spec does not seem to imply _HID and _ADR can't coexist. > CC Corey who added a device with both HID and ADR to x86 recenly. >=20 > Apropos Corey, why was HID APP0005 chosen? >=20 > > --- > > Cc: Shannon Zhao > > Cc: Peter Maydell > > Cc: "Michael S. Tsirkin" > > Cc: Igor Mammedov > > Cc: qemu-arm@nongnu.org > > Cc: qemu-devel@nongnu.org > > --- > > hw/arm/virt-acpi-build.c | 8 -------- > > tests/data/acpi/virt/DSDT | Bin 18449 -> 18426 bytes > > tests/data/acpi/virt/DSDT.memhp | Bin 19786 -> 19763 bytes > > tests/data/acpi/virt/DSDT.numamem | Bin 18449 -> 18426 bytes > > 4 files changed, 8 deletions(-) > >=20 > > diff --git a/hw/arm/virt-acpi-build.c b/hw/arm/virt-acpi-build.c > > index 9f4c7d1889..be752c0ad8 100644 > > --- a/hw/arm/virt-acpi-build.c > > +++ b/hw/arm/virt-acpi-build.c > > @@ -78,11 +78,6 @@ static void acpi_dsdt_add_uart(Aml *scope, const Mem= MapEntry *uart_memmap, > > AML_EXCLUSIVE, &uart_irq, 1)); > > aml_append(dev, aml_name_decl("_CRS", crs)); > > =20 > > - /* The _ADR entry is used to link this device to the UART describe= d > > - * in the SPCR table, i.e. SPCR.base_address.address =3D=3D _ADR. > > - */ > > - aml_append(dev, aml_name_decl("_ADR", aml_int(uart_memmap->base)))= ; > > - > > aml_append(scope, dev); > > } > > =20 > > @@ -170,7 +165,6 @@ static void acpi_dsdt_add_pci(Aml *scope, const Mem= MapEntry *memmap, > > aml_append(dev, aml_name_decl("_CID", aml_string("PNP0A03"))); > > aml_append(dev, aml_name_decl("_SEG", aml_int(0))); > > aml_append(dev, aml_name_decl("_BBN", aml_int(0))); > > - aml_append(dev, aml_name_decl("_ADR", aml_int(0))); > > aml_append(dev, aml_name_decl("_UID", aml_string("PCI0"))); > > aml_append(dev, aml_name_decl("_STR", aml_unicode("PCIe 0 Device")= )); > > aml_append(dev, aml_name_decl("_CCA", aml_int(1))); > > @@ -334,7 +328,6 @@ static void acpi_dsdt_add_gpio(Aml *scope, const Me= mMapEntry *gpio_memmap, > > { > > Aml *dev =3D aml_device("GPO0"); > > aml_append(dev, aml_name_decl("_HID", aml_string("ARMH0061"))); > > - aml_append(dev, aml_name_decl("_ADR", aml_int(0))); > > aml_append(dev, aml_name_decl("_UID", aml_int(0))); > > =20 > > Aml *crs =3D aml_resource_template(); > > @@ -364,7 +357,6 @@ static void acpi_dsdt_add_power_button(Aml *scope) > > { > > Aml *dev =3D aml_device(ACPI_POWER_BUTTON_DEVICE); > > aml_append(dev, aml_name_decl("_HID", aml_string("PNP0C0C"))); > > - aml_append(dev, aml_name_decl("_ADR", aml_int(0))); > > aml_append(dev, aml_name_decl("_UID", aml_int(0))); > > aml_append(scope, dev); > > } > > diff --git a/tests/data/acpi/virt/DSDT b/tests/data/acpi/virt/DSDT >=20 >=20 > Please do not include binary changes in acpi patches. >=20 > See comment at the top of tests/bios-tables-test.c for documentation > on how to update these. >=20 > --=20 > MST