From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: qemu-devel@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>
Cc: "Kevin Wolf" <kwolf@redhat.com>, "Thomas Huth" <thuth@redhat.com>,
qemu-block@nongnu.org,
"Wainer dos Santos Moschetta" <wainersm@redhat.com>,
"Max Reitz" <mreitz@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>
Subject: [PATCH] tests/qemu-iotests: Update tests to recent desugarized -accel option
Date: Mon, 6 Jan 2020 14:09:51 +0100 [thread overview]
Message-ID: <20200106130951.29873-1-philmd@redhat.com> (raw)
Commit 6f6e1698a6 desugarized "-machine accel=" to a list
of "-accel" options. Since now "-machine accel" and "-accel"
became incompatible, update the iotests to the new format.
Error reported here:
https://gitlab.com/qemu-project/qemu/-/jobs/385801004#L3400
Reported-by: GitLab CI
Fixes: 6f6e1698a6 (vl: configure accelerators from -accel options)
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
tests/qemu-iotests/235 | 2 +-
tests/qemu-iotests/check | 6 +++---
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/tests/qemu-iotests/235 b/tests/qemu-iotests/235
index fedd111fd4..3d7533980d 100755
--- a/tests/qemu-iotests/235
+++ b/tests/qemu-iotests/235
@@ -49,7 +49,7 @@ qemu_img_create('-f', iotests.imgfmt, '-o', 'preallocation=metadata', disk,
str(size))
vm = QEMUMachine(iotests.qemu_prog)
-vm.add_args('-machine', 'accel=kvm:tcg')
+vm.add_args('-accel', 'kvm', '-accel', 'tcg')
if iotests.qemu_default_machine == 's390-ccw-virtio':
vm.add_args('-no-shutdown')
vm.add_args('-drive', 'id=src,file=' + disk)
diff --git a/tests/qemu-iotests/check b/tests/qemu-iotests/check
index 90970b0549..2890785a10 100755
--- a/tests/qemu-iotests/check
+++ b/tests/qemu-iotests/check
@@ -587,13 +587,13 @@ export QEMU_PROG="$(type -p "$QEMU_PROG")"
case "$QEMU_PROG" in
*qemu-system-arm|*qemu-system-aarch64)
- export QEMU_OPTIONS="-nodefaults -display none -machine virt,accel=qtest"
+ export QEMU_OPTIONS="-nodefaults -display none -machine virt -accel qtest"
;;
*qemu-system-tricore)
- export QEMU_OPTIONS="-nodefaults -display none -machine tricore_testboard,accel=qtest"
+ export QEMU_OPTIONS="-nodefaults -display none -machine tricore_testboard -accel qtest"
;;
*)
- export QEMU_OPTIONS="-nodefaults -display none -machine accel=qtest"
+ export QEMU_OPTIONS="-nodefaults -display none -accel qtest"
;;
esac
--
2.21.1
next reply other threads:[~2020-01-06 13:10 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-06 13:09 Philippe Mathieu-Daudé [this message]
2020-01-06 13:16 ` [PATCH] tests/qemu-iotests: Update tests to recent desugarized -accel option Max Reitz
2020-01-07 10:03 ` Priority of -accel (was: [PATCH] tests/qemu-iotests: Update tests to recent desugarized -accel option) Thomas Huth
2020-01-07 10:14 ` Paolo Bonzini
2020-01-07 12:18 ` Thomas Huth
2020-01-07 12:23 ` Paolo Bonzini
2020-01-07 12:54 ` Daniel P. Berrangé
2020-01-07 14:14 ` Thomas Huth
2020-01-07 14:20 ` Priority of -accel Philippe Mathieu-Daudé
2020-01-07 14:27 ` Daniel P. Berrangé
2020-01-07 14:35 ` Thomas Huth
2020-01-13 14:39 ` Markus Armbruster
2020-01-13 16:14 ` Christophe de Dinechin
2020-01-13 16:23 ` Paolo Bonzini
2020-01-07 14:26 ` Priority of -accel (was: [PATCH] tests/qemu-iotests: Update tests to recent desugarized -accel option) Daniel P. Berrangé
2020-01-08 10:39 ` Alex Bennée
2020-01-08 10:58 ` Thomas Huth
2020-01-08 12:41 ` Paolo Bonzini
2020-01-08 13:10 ` Daniel P. Berrangé
2020-01-08 13:24 ` Paolo Bonzini
2020-01-08 14:00 ` Priority of -accel Thomas Huth
2020-01-08 11:00 ` Priority of -accel (was: [PATCH] tests/qemu-iotests: Update tests to recent desugarized -accel option) Peter Maydell
2020-01-10 10:43 ` Peter Maydell
2020-01-07 12:29 ` Kevin Wolf
2020-01-07 12:34 ` Priority of -accel Philippe Mathieu-Daudé
2020-01-07 12:37 ` Philippe Mathieu-Daudé
2020-01-07 13:55 ` Priority of -accel (was: [PATCH] tests/qemu-iotests: Update tests to recent desugarized -accel option) Christophe de Dinechin
2020-01-07 14:37 ` Paolo Bonzini
2020-01-07 14:42 ` Thomas Huth
2020-01-07 17:43 ` Christophe de Dinechin
2020-01-07 17:53 ` Peter Maydell
2020-01-08 9:47 ` Kevin Wolf
2020-01-13 16:17 ` Priority of -accel Markus Armbruster
2020-01-13 16:25 ` Paolo Bonzini
2020-01-14 8:59 ` Markus Armbruster
2020-01-14 10:44 ` Paolo Bonzini
2020-01-14 17:49 ` Christophe de Dinechin
2020-01-14 17:59 ` Daniel P. Berrangé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200106130951.29873-1-philmd@redhat.com \
--to=philmd@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
--cc=wainersm@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).