* [PATCH] hw/timer/Kconfig: Intel 8254 PIT depends of ISA bus
@ 2020-01-06 17:19 Philippe Mathieu-Daudé
2020-01-07 8:17 ` Paolo Bonzini
0 siblings, 1 reply; 2+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-01-06 17:19 UTC (permalink / raw)
To: qemu-devel; +Cc: Paolo Bonzini, Philippe Mathieu-Daudé, Michael S. Tsirkin
Since i8254_common.c calls isa_register_ioport() from "hw/isa/isa.h"
we can not select it when ISA_BUS is disabled. Add a 'depends on'
clause.
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
hw/timer/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/timer/Kconfig b/hw/timer/Kconfig
index a990f9fe35..59b3f44d69 100644
--- a/hw/timer/Kconfig
+++ b/hw/timer/Kconfig
@@ -15,6 +15,7 @@ config HPET
config I8254
bool
+ depends on ISA_BUS
config ALTERA_TIMER
bool
--
2.21.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] hw/timer/Kconfig: Intel 8254 PIT depends of ISA bus
2020-01-06 17:19 [PATCH] hw/timer/Kconfig: Intel 8254 PIT depends of ISA bus Philippe Mathieu-Daudé
@ 2020-01-07 8:17 ` Paolo Bonzini
0 siblings, 0 replies; 2+ messages in thread
From: Paolo Bonzini @ 2020-01-07 8:17 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, qemu-devel; +Cc: Michael S. Tsirkin
On 06/01/20 18:19, Philippe Mathieu-Daudé wrote:
> Since i8254_common.c calls isa_register_ioport() from "hw/isa/isa.h"
> we can not select it when ISA_BUS is disabled. Add a 'depends on'
> clause.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> hw/timer/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/hw/timer/Kconfig b/hw/timer/Kconfig
> index a990f9fe35..59b3f44d69 100644
> --- a/hw/timer/Kconfig
> +++ b/hw/timer/Kconfig
> @@ -15,6 +15,7 @@ config HPET
>
> config I8254
> bool
> + depends on ISA_BUS
>
> config ALTERA_TIMER
> bool
>
Queued, thanks.
Paolo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-01-07 9:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-01-06 17:19 [PATCH] hw/timer/Kconfig: Intel 8254 PIT depends of ISA bus Philippe Mathieu-Daudé
2020-01-07 8:17 ` Paolo Bonzini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).