From: Peter Xu <peterx@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: QEMU Developers <qemu-devel@nongnu.org>,
Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [PATCH] tests/iothread: Always connect iothread GSource to a GMainContext
Date: Mon, 6 Jan 2020 13:01:29 -0500 [thread overview]
Message-ID: <20200106180129.GD219677@xz-x1> (raw)
In-Reply-To: <CAFEAcA89VHAyQKCeV6exxzDjLCEGUyg59um7w-VZ2K6s4ZV31g@mail.gmail.com>
On Mon, Jan 06, 2020 at 05:40:15PM +0000, Peter Maydell wrote:
[...]
> So we're OK to not do this because tests/iothread.c's
> main loop doesn't call g_main_loop_run(), and it doesn't
> provide an iothread_get_g_main_context() ?
>
> I'm kind of inclined towards being lazy and sticking with
> what this patch has, because:
> * it matches the real iothread.c, which reduces the possiblity
> of future surprise bugs due to things not matching up
> * it's already been reviewed
> * it saves me having to do a respin and retest
>
> But if people would prefer these bits deleted I'll stop
> being lazy :-)
Please feel free to be lazy and fix the test sooner (and that's why I
offered my r-b :).
Thanks,
--
Peter Xu
next prev parent reply other threads:[~2020-01-06 18:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-06 14:45 [PATCH] tests/iothread: Always connect iothread GSource to a GMainContext Peter Maydell
2020-01-06 15:22 ` Marc-André Lureau
2020-01-06 15:31 ` Peter Maydell
2020-01-06 17:28 ` Peter Xu
2020-01-06 17:40 ` Peter Maydell
2020-01-06 18:01 ` Peter Xu [this message]
2020-01-07 15:32 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200106180129.GD219677@xz-x1 \
--to=peterx@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).