From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 353FAC33C8C for ; Mon, 6 Jan 2020 18:46:43 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E9F7C207FF for ; Mon, 6 Jan 2020 18:46:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="HVMaOLRw" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E9F7C207FF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:58016 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ioXOj-0004Bj-9r for qemu-devel@archiver.kernel.org; Mon, 06 Jan 2020 13:46:41 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:45938) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ioX4b-0002lz-Jp for qemu-devel@nongnu.org; Mon, 06 Jan 2020 13:25:54 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ioX4a-0004dn-Ed for qemu-devel@nongnu.org; Mon, 06 Jan 2020 13:25:53 -0500 Received: from mail-qk1-x729.google.com ([2607:f8b0:4864:20::729]:42066) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ioX4a-0004dQ-B7; Mon, 06 Jan 2020 13:25:52 -0500 Received: by mail-qk1-x729.google.com with SMTP id z14so39015125qkg.9; Mon, 06 Jan 2020 10:25:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=9iBtM24gxNcAx1ejDUOR0GLhyehYr4GnSdxBSiFhd/U=; b=HVMaOLRwolx3rm3gwTHFVdu/toenkl+41BDqkp22iVBpe1ywA+YciHLQ78rv727D7z PMHWswFe8SfFERzoN/0pqtpZqfQvl5hokxyrYd8D+YPcuVWJE1c9JHSEmNZEryA+b1PU n0W30eed5E5JZ7teLKTvAmSIcPCtBPLuMsvzLG42vAyEbMyEtCrLjj26nUCf00ftheXQ NB2dUboTnsrtqBWLkTLY+5dANNFdDo2XyHnJa29lzLz0P/tOzF4PMYp0a/pUmxapllTk GCKuEeE/rbgXim+PbZmFhhBli/tYlZaxLerMH5maTXvPtq/EcssZ5yOXCvqHbVRn74o+ 88ew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=9iBtM24gxNcAx1ejDUOR0GLhyehYr4GnSdxBSiFhd/U=; b=AxZTRo8wcx+FzqJmc9ev/dM3IHs151/u+o6tQJZTx1hSyQ4z0db97nMc4m+0PbKQNa HP5a7TY1gYLUu1FSPLuGypOOf0JeM0osAULiJnT19XeJSWf4g+UcV1btnl0Kq8yrywBc J9Md15ZeKkmsx8yDrudHErBw9Ucq1jB8oGlb7Nah8gWFdCpPXsmr8V71hroullA600dM hELLgSxlD1EB9F2qsPglvp7lCwgGCQ99bttQSd8q7+yKhiSNLbtLESzGBL32oytxc1yL 5SafCCozMz+apcBc4a3Yef8Xz+s61iBTU7uWpGmN1x3Xumk0lFBTE+5WrB9aJpNB7JKi Pq6w== X-Gm-Message-State: APjAAAXy3awGKEQBbQshdNqZIBJHyxkpeYpOhd0RkXV+sj5sXYj4X1aM j5OR69TPx/uJNXLQV7JEHfUvCPN5 X-Google-Smtp-Source: APXvYqxNCdyCI+5IWqfjzBWWNSQlIUlqGLwOgwQRkwTxANsLrlC1DI4HIlMK5Abm1n7kSwyMxbCmyg== X-Received: by 2002:a05:620a:21d4:: with SMTP id h20mr79651642qka.468.1578335151684; Mon, 06 Jan 2020 10:25:51 -0800 (PST) Received: from rekt.ibmuc.com ([2804:431:c7c6:655b:9e1c:e865:3705:e1df]) by smtp.gmail.com with ESMTPSA id b81sm21026522qkc.135.2020.01.06.10.25.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jan 2020 10:25:51 -0800 (PST) From: Daniel Henrique Barboza To: qemu-devel@nongnu.org Subject: [PATCH v1 33/59] ipmi/ipmi_bmc_sim.c: remove unneeded labels Date: Mon, 6 Jan 2020 15:23:59 -0300 Message-Id: <20200106182425.20312-34-danielhb413@gmail.com> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20200106182425.20312-1-danielhb413@gmail.com> References: <20200106182425.20312-1-danielhb413@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::729 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, Daniel Henrique Barboza , Corey Minyard Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Label 'out' from ipmi_bmc_gen_event() and gen_event() can be replaced by 'return'. CC: Corey Minyard Signed-off-by: Daniel Henrique Barboza --- hw/ipmi/ipmi_bmc_sim.c | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/hw/ipmi/ipmi_bmc_sim.c b/hw/ipmi/ipmi_bmc_sim.c index 6670cf039d..1e06fd1de9 100644 --- a/hw/ipmi/ipmi_bmc_sim.c +++ b/hw/ipmi/ipmi_bmc_sim.c @@ -461,14 +461,12 @@ void ipmi_bmc_gen_event(IPMIBmc *b, uint8_t *evt, bool log) } if (ibs->msg_flags & IPMI_BMC_MSG_FLAG_EVT_BUF_FULL) { - goto out; + return; } memcpy(ibs->evtbuf, evt, 16); ibs->msg_flags |= IPMI_BMC_MSG_FLAG_EVT_BUF_FULL; k->set_atn(s, 1, attn_irq_enabled(ibs)); - out: - return; } static void gen_event(IPMIBmcSim *ibs, unsigned int sens_num, uint8_t deassert, uint8_t evd1, uint8_t evd2, uint8_t evd3) @@ -978,7 +976,7 @@ static void get_msg(IPMIBmcSim *ibs, if (QTAILQ_EMPTY(&ibs->rcvbufs)) { rsp_buffer_set_error(rsp, 0x80); /* Queue empty */ - goto out; + return; } rsp_buffer_push(rsp, 0); /* Channel 0 */ msg = QTAILQ_FIRST(&ibs->rcvbufs); @@ -993,9 +991,6 @@ static void get_msg(IPMIBmcSim *ibs, ibs->msg_flags &= ~IPMI_BMC_MSG_FLAG_RCV_MSG_QUEUE; k->set_atn(s, attn_set(ibs), attn_irq_enabled(ibs)); } - -out: - return; } static unsigned char -- 2.24.1