From: "Michael S. Tsirkin" <mst@redhat.com>
To: qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>,
David Hildenbrand <david@redhat.com>
Subject: [PULL v2 01/32] virtio: add ability to delete vq through a pointer
Date: Tue, 7 Jan 2020 02:35:13 -0500 [thread overview]
Message-ID: <20200107073451.298261-2-mst@redhat.com> (raw)
In-Reply-To: <20200107073451.298261-1-mst@redhat.com>
Devices tend to maintain vq pointers, allow deleting them trough a vq pointer.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Reviewed-by: David Hildenbrand <david@redhat.com>
Reviewed-by: David Hildenbrand <david@redhat.com>
---
include/hw/virtio/virtio.h | 2 ++
hw/virtio/virtio.c | 15 ++++++++++-----
2 files changed, 12 insertions(+), 5 deletions(-)
diff --git a/include/hw/virtio/virtio.h b/include/hw/virtio/virtio.h
index c32a815303..e18756d50d 100644
--- a/include/hw/virtio/virtio.h
+++ b/include/hw/virtio/virtio.h
@@ -183,6 +183,8 @@ VirtQueue *virtio_add_queue(VirtIODevice *vdev, int queue_size,
void virtio_del_queue(VirtIODevice *vdev, int n);
+void virtio_delete_queue(VirtQueue *vq);
+
void virtqueue_push(VirtQueue *vq, const VirtQueueElement *elem,
unsigned int len);
void virtqueue_flush(VirtQueue *vq, unsigned int count);
diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c
index 04716b5f6c..31dd140990 100644
--- a/hw/virtio/virtio.c
+++ b/hw/virtio/virtio.c
@@ -2330,17 +2330,22 @@ VirtQueue *virtio_add_queue(VirtIODevice *vdev, int queue_size,
return &vdev->vq[i];
}
+void virtio_delete_queue(VirtQueue *vq)
+{
+ vq->vring.num = 0;
+ vq->vring.num_default = 0;
+ vq->handle_output = NULL;
+ vq->handle_aio_output = NULL;
+ g_free(vq->used_elems);
+}
+
void virtio_del_queue(VirtIODevice *vdev, int n)
{
if (n < 0 || n >= VIRTIO_QUEUE_MAX) {
abort();
}
- vdev->vq[n].vring.num = 0;
- vdev->vq[n].vring.num_default = 0;
- vdev->vq[n].handle_output = NULL;
- vdev->vq[n].handle_aio_output = NULL;
- g_free(vdev->vq[n].used_elems);
+ virtio_delete_queue(&vdev->vq[n]);
}
static void virtio_set_isr(VirtIODevice *vdev, int value)
--
MST
next prev parent reply other threads:[~2020-01-07 7:56 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-07 7:35 [PULL v2 00/32] virtio, pci, pc: fixes, features Michael S. Tsirkin
2020-01-07 7:35 ` Michael S. Tsirkin [this message]
2020-01-07 7:35 ` [PULL v2 02/32] virtio: make virtio_delete_queue idempotent Michael S. Tsirkin
2020-01-07 7:35 ` [PULL v2 03/32] virtio-balloon: fix memory leak while attach virtio-balloon device Michael S. Tsirkin
2020-01-07 7:35 ` [PULL v2 04/32] virtio-serial-bus: fix memory leak while attach virtio-serial-bus Michael S. Tsirkin
2020-01-07 7:35 ` [PULL v2 05/32] virtio-input: convert to new virtio_delete_queue Michael S. Tsirkin
2020-01-07 7:35 ` [PULL v2 06/32] intel_iommu: fix bug to read DMAR_RTADDR_REG Michael S. Tsirkin
2020-01-07 7:35 ` [PULL v2 07/32] virtio: update queue size on guest write Michael S. Tsirkin
2020-01-07 7:35 ` [PULL v2 08/32] virtio-pci: disable vring processing when bus-mastering is disabled Michael S. Tsirkin
2020-01-07 7:35 ` [PULL v2 09/32] Implement backend program convention command for vhost-user-blk Michael S. Tsirkin
2020-01-07 7:35 ` [PULL v2 10/32] virtio: don't enable notifications during polling Michael S. Tsirkin
2020-01-07 7:36 ` [PULL v2 11/32] numa: Extend CLI to provide initiator information for numa nodes Michael S. Tsirkin
2020-01-07 7:36 ` [PULL v2 12/32] numa: Extend CLI to provide memory latency and bandwidth information Michael S. Tsirkin
2020-01-07 7:36 ` [PULL v2 13/32] numa: Extend CLI to provide memory side cache information Michael S. Tsirkin
2020-01-07 7:36 ` [PULL v2 14/32] hmat acpi: Build Memory Proximity Domain Attributes Structure(s) Michael S. Tsirkin
2020-01-07 7:36 ` [PULL v2 15/32] hmat acpi: Build System Locality Latency and Bandwidth Information Structure(s) Michael S. Tsirkin
2020-01-07 7:36 ` [PULL v2 16/32] hmat acpi: Build Memory Side Cache " Michael S. Tsirkin
2020-01-07 7:36 ` [PULL v2 17/32] tests/numa: Add case for QMP build HMAT Michael S. Tsirkin
2020-01-07 7:36 ` [PULL v2 18/32] tests/bios-tables-test: add test cases for ACPI HMAT Michael S. Tsirkin
2020-01-07 7:36 ` [PULL v2 19/32] ACPI: add expected files for HMAT tests (acpihmat) Michael S. Tsirkin
2020-01-07 7:36 ` [PULL v2 20/32] virtio-mmio: Clear v2 transport state on soft reset Michael S. Tsirkin
2020-01-07 7:36 ` [PULL v2 21/32] hw/pci/pci_host: Remove redundant PCI_DPRINTF() Michael S. Tsirkin
2020-01-07 7:37 ` [PULL v2 22/32] hw/pci/pci_host: Let pci_data_[read/write] use unsigned 'size' argument Michael S. Tsirkin
2020-01-07 7:37 ` [PULL v2 23/32] vhost-user: add VHOST_USER_RESET_DEVICE to reset devices Michael S. Tsirkin
2020-01-07 7:37 ` [PULL v2 24/32] vhost-user-scsi: reset the device if supported Michael S. Tsirkin
2020-01-07 7:37 ` [PULL v2 25/32] hw: fix using 4.2 compat in 5.0 machine types for i440fx/q35 Michael S. Tsirkin
2020-01-07 7:37 ` [PULL v2 26/32] virtio: make seg_max virtqueue size dependent Michael S. Tsirkin
2020-01-07 7:37 ` [PULL v2 27/32] tests: add virtio-scsi and virtio-blk seg_max_adjust test Michael S. Tsirkin
2020-01-07 7:37 ` [PULL v2 28/32] virtio-mmio: update queue size on guest write Michael S. Tsirkin
2020-01-07 7:37 ` [PULL v2 29/32] virtio: reset region cache when on queue deletion Michael S. Tsirkin
2020-01-07 7:37 ` [PULL v2 30/32] virtio-net: delete also control queue when TX/RX deleted Michael S. Tsirkin
2020-01-07 7:37 ` [PULL v2 31/32] intel_iommu: a fix to vtd_find_as_from_bus_num() Michael S. Tsirkin
2020-01-07 7:37 ` [PULL v2 32/32] intel_iommu: add present bit check for pasid table entries Michael S. Tsirkin
2020-01-07 17:08 ` [PULL v2 00/32] virtio, pci, pc: fixes, features Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200107073451.298261-2-mst@redhat.com \
--to=mst@redhat.com \
--cc=david@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).