From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 72FD4C33C8C for ; Tue, 7 Jan 2020 16:57:01 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 420AB206DB for ; Tue, 7 Jan 2020 16:57:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="ID3Mkw/g" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 420AB206DB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:53142 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iosA7-0004kg-Px for qemu-devel@archiver.kernel.org; Tue, 07 Jan 2020 11:56:59 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:50776) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iorqo-0006VK-US for qemu-devel@nongnu.org; Tue, 07 Jan 2020 11:37:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iorqn-0000mb-QC for qemu-devel@nongnu.org; Tue, 07 Jan 2020 11:37:02 -0500 Received: from us-smtp-2.mimecast.com ([205.139.110.61]:40706 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iorqn-0000ls-MJ for qemu-devel@nongnu.org; Tue, 07 Jan 2020 11:37:01 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1578415021; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=deIymBpJ8L5xzgOMqD2GOgswzjAkfpMPfhBZxWqwugw=; b=ID3Mkw/g4q+2p+94Thhg3byKkh18qtjcXt2EK5dkjdfUdNjzCC993mGn9hSppP1PwrbtZ9 0cslrYqJA+4eu8b+LpJBO1PBccgKhU3fGc47hghqi0sV+4R17VuSGbwKeRtNAoixipDCXU VgA0iyeKcTVRuBnIvo/9T6WIlOKsjzY= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-382-9w9yALg_PJeMMf_7H4lDzA-1; Tue, 07 Jan 2020 11:36:59 -0500 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 99B59801E6C; Tue, 7 Jan 2020 16:36:58 +0000 (UTC) Received: from work-vm (ovpn-117-52.ams2.redhat.com [10.36.117.52]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7078E10016EB; Tue, 7 Jan 2020 16:36:54 +0000 (UTC) Date: Tue, 7 Jan 2020 16:36:52 +0000 From: "Dr. David Alan Gilbert" To: Laurent Vivier Subject: Re: [PATCH] migration-test: ppc64: fix FORTH test program Message-ID: <20200107163652.GJ2732@work-vm> References: <20200107163437.52139-1-lvivier@redhat.com> MIME-Version: 1.0 In-Reply-To: <20200107163437.52139-1-lvivier@redhat.com> User-Agent: Mutt/1.13.0 (2019-11-30) X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-MC-Unique: 9w9yALg_PJeMMf_7H4lDzA-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Content-Disposition: inline X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 205.139.110.61 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Wei Huang , Thomas Huth , Juan Quintela , qemu-devel@nongnu.org, Paolo Bonzini , David Gibson Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" * Laurent Vivier (lvivier@redhat.com) wrote: > Commit e51e711b1bef has moved the initialization of start_address and > end_address after the definition of the command line argument, > where the nvramrc is initialized, and thus the loop is between 0 and 0 > rather than 1 MiB and 100 MiB. >=20 > It doesn't affect the result of the test if all the tests are run in > sequence because the two first tests don't run the loop, so the > values are correctly initialized when we actually need them. >=20 > But it hangs when we ask to run only one test, for instance: >=20 > QTEST_QEMU_BINARY=3Dppc64-softmmu/qemu-system-ppc64 \ > tests/migration-test -m=3Dquick -p /ppc64/migration/validate_uuid_err= or >=20 > Fixes: e51e711b1bef ("tests/migration: Add migration-test header file") > Cc: wei@redhat.com > Signed-off-by: Laurent Vivier Reviewed-by: Dr. David Alan Gilbert > --- > tests/migration-test.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/tests/migration-test.c b/tests/migration-test.c > index 53afec439522..341d19092214 100644 > --- a/tests/migration-test.c > +++ b/tests/migration-test.c > @@ -480,14 +480,14 @@ static int test_migrate_start(QTestState **from, QT= estState **to, > } else if (strcmp(arch, "ppc64") =3D=3D 0) { > machine_opts =3D "vsmt=3D8"; > memory_size =3D "256M"; > + start_address =3D PPC_TEST_MEM_START; > + end_address =3D PPC_TEST_MEM_END; > arch_source =3D g_strdup_printf("-nodefaults " > "-prom-env 'use-nvramrc?=3Dtrue' -= prom-env " > "'nvramrc=3Dhex .\" _\" begin %x %= x " > "do i c@ 1 + i c! 1000 +loop .\" B= \" 0 " > "until'", end_address, start_addre= ss); > arch_target =3D g_strdup(""); > - start_address =3D PPC_TEST_MEM_START; > - end_address =3D PPC_TEST_MEM_END; > } else if (strcmp(arch, "aarch64") =3D=3D 0) { > init_bootfile(bootpath, aarch64_kernel, sizeof(aarch64_kernel)); > machine_opts =3D "virt,gic-version=3Dmax"; > --=20 > 2.23.0 >=20 -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK