From: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
To: Igor Mammedov <imammedo@redhat.com>, Helge Deller <deller@gmx.de>,
Sven Schnelle <svens@stackframe.org>,
qemu-devel@nongnu.org
Cc: "Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"Richard Henderson" <rth@twiddle.net>
Subject: [PATCH v2 1/3] hw/hppa/machine: Correctly check the firmware is in PDC range
Date: Thu, 9 Jan 2020 01:05:23 +0100 [thread overview]
Message-ID: <20200109000525.24744-2-f4bug@amsat.org> (raw)
In-Reply-To: <20200109000525.24744-1-f4bug@amsat.org>
The firmware has to reside in the PDC range. If the Elf file
expects to load it below FIRMWARE_START, it is incorrect,
regardless the RAM size.
Acked-by: Helge Deller <deller@gmx.de>
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
hw/hppa/machine.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/hppa/machine.c b/hw/hppa/machine.c
index 5d0de26140..6775d879f8 100644
--- a/hw/hppa/machine.c
+++ b/hw/hppa/machine.c
@@ -155,7 +155,7 @@ static void machine_hppa_init(MachineState *machine)
qemu_log_mask(CPU_LOG_PAGE, "Firmware loaded at 0x%08" PRIx64
"-0x%08" PRIx64 ", entry at 0x%08" PRIx64 ".\n",
firmware_low, firmware_high, firmware_entry);
- if (firmware_low < ram_size || firmware_high >= FIRMWARE_END) {
+ if (firmware_low < FIRMWARE_START || firmware_high >= FIRMWARE_END) {
error_report("Firmware overlaps with memory or IO space");
exit(1);
}
--
2.21.1
next prev parent reply other threads:[~2020-01-09 0:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-09 0:05 [PATCH v2 0/3] hw/hppa/machine: Restrict the total memory size to 3GB Philippe Mathieu-Daudé
2020-01-09 0:05 ` Philippe Mathieu-Daudé [this message]
2020-01-09 0:05 ` [PATCH v2 2/3] " Philippe Mathieu-Daudé
2020-01-09 0:05 ` [PATCH v2 3/3] hw/hppa/machine: Map the PDC memory region with higher priority Philippe Mathieu-Daudé
2020-01-09 2:20 ` [PATCH v2 0/3] hw/hppa/machine: Restrict the total memory size to 3GB Richard Henderson
2020-01-09 6:48 ` Helge Deller
2020-01-17 1:03 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200109000525.24744-2-f4bug@amsat.org \
--to=f4bug@amsat.org \
--cc=deller@gmx.de \
--cc=imammedo@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
--cc=svens@stackframe.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).