From: "Michael S. Tsirkin" <mst@redhat.com>
To: "Dr. David Alan Gilbert (git)" <dgilbert@redhat.com>
Cc: jasowang@redhat.com, vkuznets@redhat.com, qemu-devel@nongnu.org
Subject: Re: [PATCH 1/2] vhost: Don't pass ram device sections
Date: Thu, 9 Jan 2020 06:45:19 -0500 [thread overview]
Message-ID: <20200109064425-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20200108135353.75471-2-dgilbert@redhat.com>
On Wed, Jan 08, 2020 at 01:53:52PM +0000, Dr. David Alan Gilbert (git) wrote:
> From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
>
> Don't pass RAM blocks that are marked as ram devices to vhost.
> There's normally something special about them and they're not
> normally just shared memory.
>
> Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
So I think this is good by itself.
> ---
> hw/virtio/vhost.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/hw/virtio/vhost.c b/hw/virtio/vhost.c
> index 4da0d5a6c5..c81f0be71b 100644
> --- a/hw/virtio/vhost.c
> +++ b/hw/virtio/vhost.c
> @@ -402,6 +402,7 @@ static bool vhost_section(struct vhost_dev *dev, MemoryRegionSection *section)
> bool log_dirty = memory_region_get_dirty_log_mask(section->mr) &
> ~(1 << DIRTY_MEMORY_MIGRATION);
> result = memory_region_is_ram(section->mr) &&
> + !memory_region_is_ram_device(section->mr) &&
> !memory_region_is_rom(section->mr);
>
> /* Vhost doesn't handle any block which is doing dirty-tracking other
> --
> 2.24.1
next prev parent reply other threads:[~2020-01-09 11:47 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-08 13:53 [PATCH 0/2] exclude hyperv synic sections from vhost Dr. David Alan Gilbert (git)
2020-01-08 13:53 ` [PATCH 1/2] vhost: Don't pass ram device sections Dr. David Alan Gilbert (git)
2020-01-09 11:45 ` Michael S. Tsirkin [this message]
2020-01-09 11:56 ` Michael S. Tsirkin
2020-01-09 12:38 ` Roman Kagan
2020-01-09 12:42 ` Michael S. Tsirkin
2020-01-08 13:53 ` [PATCH 2/2] hyperv/synic: Allocate as ram_device Dr. David Alan Gilbert (git)
2020-01-09 11:48 ` Michael S. Tsirkin
2020-01-09 12:08 ` Dr. David Alan Gilbert
2020-01-09 12:18 ` Michael S. Tsirkin
2020-01-09 12:22 ` Dr. David Alan Gilbert
2020-01-09 13:00 ` Vitaly Kuznetsov
2020-01-09 13:24 ` Roman Kagan
2020-01-09 13:28 ` Dr. David Alan Gilbert
2020-01-09 16:12 ` Roman Kagan
2020-01-09 16:27 ` Dr. David Alan Gilbert
2020-01-09 17:13 ` Roman Kagan
2020-01-09 13:06 ` Michael S. Tsirkin
2020-01-09 13:22 ` Dr. David Alan Gilbert
2020-01-09 13:27 ` Michael S. Tsirkin
2020-01-09 13:28 ` Michael S. Tsirkin
2020-01-09 13:40 ` Dr. David Alan Gilbert
2020-01-09 15:31 ` Paolo Bonzini
2020-01-09 15:38 ` Dr. David Alan Gilbert
2020-01-09 15:40 ` Vitaly Kuznetsov
2020-07-07 10:54 ` Paolo Bonzini
2020-01-09 13:03 ` Roman Kagan
2020-01-09 13:08 ` Dr. David Alan Gilbert
2020-01-08 14:26 ` [PATCH 0/2] exclude hyperv synic sections from vhost Vitaly Kuznetsov
2020-01-09 3:00 ` Jason Wang
2020-01-09 9:07 ` Vitaly Kuznetsov
2020-01-09 12:02 ` Dr. David Alan Gilbert
2020-01-09 12:14 ` Michael S. Tsirkin
2020-01-09 11:53 ` Roman Kagan
2020-01-09 12:16 ` Dr. David Alan Gilbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200109064425-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=dgilbert@redhat.com \
--cc=jasowang@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=vkuznets@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).