From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 53CE6C32771 for ; Thu, 9 Jan 2020 10:16:18 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 19FE7206ED for ; Thu, 9 Jan 2020 10:16:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="ek8wa77L" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 19FE7206ED Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:57870 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ipUrR-0004PG-0u for qemu-devel@archiver.kernel.org; Thu, 09 Jan 2020 05:16:17 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:54677) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ipUqb-0003qJ-IA for qemu-devel@nongnu.org; Thu, 09 Jan 2020 05:15:26 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ipUqa-000897-3A for qemu-devel@nongnu.org; Thu, 09 Jan 2020 05:15:25 -0500 Received: from us-smtp-1.mimecast.com ([207.211.31.81]:40580 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ipUqZ-00084D-Rf for qemu-devel@nongnu.org; Thu, 09 Jan 2020 05:15:23 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1578564922; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GFydeE9tiJJ4Nu5YQ2gI79VJvn4UrO7HowmYMgfM5MI=; b=ek8wa77L1QJBw6teOomg5dgujJKxwvJvddAruE8qTZ6crc0tFlTaEL1ifjHcRs9DBkZvOs y99v0a5Lle/04LjRJmkfzZLZ3W3gZhULPFM9e/1YRMWbSnbSa3BzrCMNhytK4fWQd+/4V6 e8R4tyxNWHBJZy81th317GHfhgiSySA= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-131-HJfWrHxDOlmb49fScwaHqg-1; Thu, 09 Jan 2020 05:15:19 -0500 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 0C5B8800D4E; Thu, 9 Jan 2020 10:15:18 +0000 (UTC) Received: from localhost (unknown [10.43.2.114]) by smtp.corp.redhat.com (Postfix) with ESMTP id 8DC2D60BE0; Thu, 9 Jan 2020 10:15:16 +0000 (UTC) Date: Thu, 9 Jan 2020 11:15:14 +0100 From: Igor Mammedov To: Philippe =?UTF-8?B?TWF0aGlldS1EYXVkw6k=?= Subject: Re: [PATCH 2/3] hw/hppa/machine: Do not limit the RAM to 3840MB Message-ID: <20200109111514.3ab4396a@redhat.com> In-Reply-To: <20200108181425.21485-3-f4bug@amsat.org> References: <20200108181425.21485-1-f4bug@amsat.org> <20200108181425.21485-3-f4bug@amsat.org> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-MC-Unique: HJfWrHxDOlmb49fScwaHqg-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 207.211.31.81 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Helge Deller , Sven Schnelle , qemu-devel@nongnu.org, Richard Henderson Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Wed, 8 Jan 2020 19:14:24 +0100 Philippe Mathieu-Daud=C3=A9 wrote: > The hardware expects DIMM slots of 1 or 2 GB, allowing up to > 4 GB of memory. Accept the same amount of memory the hardware > can deal with. >=20 > The CPU doesn't have access to the RAM mapped in the > [0xf0000000 - 0xf1000000] range because this is the PDC area > (Processor Dependent Code) where the firmware is loaded. > To keep this region with higher priority than the RAM, lower > the RAM priority. The PDC will overlap it. >=20 > Signed-off-by: Philippe Mathieu-Daud=C3=A9 Looks good to me (since board doesn't fix up ram_size and uses whatever user specified, proper support for 4Gb could be done on top later)= . > --- > hw/hppa/machine.c | 11 +++++------ > 1 file changed, 5 insertions(+), 6 deletions(-) >=20 > diff --git a/hw/hppa/machine.c b/hw/hppa/machine.c > index 6775d879f8..d10c967d06 100644 > --- a/hw/hppa/machine.c > +++ b/hw/hppa/machine.c > @@ -90,16 +90,15 @@ static void machine_hppa_init(MachineState *machine) > g_free(name); > } > =20 > - /* Limit main memory. */ > - if (ram_size > FIRMWARE_START) { > - machine->ram_size =3D ram_size =3D FIRMWARE_START; > - } > - > /* Main memory region. */ > + if (machine->ram_size > 4 * GiB) { Could it break a build on 32-bit mingw host? (machine->ram_size is 32-bit on that host and condition would be always false, tripping -Werror) that's why I've worked around it using local uint64_t in the last version "[PATCH v3 43/86] hppa: allow max ram size upto 4Gb" coincidentally that would get rid of global ram_size usage and leave only machine->ram_size on this board. > + error_report("RAM size of 4GB or more is not supported"); > + exit(EXIT_FAILURE); > + } > ram_region =3D g_new(MemoryRegion, 1); > memory_region_allocate_system_memory(ram_region, OBJECT(machine), > "ram", ram_size); > - memory_region_add_subregion(addr_space, 0, ram_region); > + memory_region_add_subregion_overlap(addr_space, 0, ram_region, -1); > =20 > /* Init Dino (PCI host bus chip). */ > pci_bus =3D dino_init(addr_space, &rtc_irq, &serial_irq);