From: Kevin Wolf <kwolf@redhat.com>
To: Alberto Garcia <berto@igalia.com>
Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org,
Max Reitz <mreitz@redhat.com>
Subject: Re: [PATCH 3/3] qcow2: Use BDRV_SECTOR_SIZE instead of the hardcoded value
Date: Thu, 9 Jan 2020 13:19:00 +0100 [thread overview]
Message-ID: <20200109121900.GF9504@linux.fritz.box> (raw)
In-Reply-To: <f6dcb0d7b17cddb475e3a018a5b802490c7bc21d.1578505678.git.berto@igalia.com>
Am 08.01.2020 um 18:49 hat Alberto Garcia geschrieben:
> This replaces all remaining instances in the qcow2 code.
>
> Signed-off-by: Alberto Garcia <berto@igalia.com>
> diff --git a/block/qcow2.c b/block/qcow2.c
> index e8ce966f7f..6427c75409 100644
> --- a/block/qcow2.c
> +++ b/block/qcow2.c
> @@ -2175,7 +2175,7 @@ static coroutine_fn int qcow2_co_preadv_task(BlockDriverState *bs,
> offset, bytes, qiov, qiov_offset);
>
> case QCOW2_CLUSTER_NORMAL:
> - if ((file_cluster_offset & 511) != 0) {
> + if ((file_cluster_offset % BDRV_SECTOR_SIZE) != 0) {
> return -EIO;
> }
Hm, unrelated to your change, but why do we test for 512 byte alignment
here? file_cluster_offset should certainly be cluster aligned for normal
clusters. And if the check fails, that's actually an image corruption
and not just an I/O error. Am I missing something?
Kevin
next prev parent reply other threads:[~2020-01-09 12:20 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-08 17:49 [PATCH 0/3] qcow2: Misc BDRV_SECTOR_SIZE updates Alberto Garcia
2020-01-08 17:49 ` [PATCH 1/3] qcow2: Require that the virtual size is a multiple of the sector size Alberto Garcia
2020-01-08 19:46 ` Nir Soffer
2020-01-09 12:13 ` Kevin Wolf
2020-01-09 12:36 ` Alberto Garcia
2020-01-08 17:49 ` [PATCH 2/3] qcow2: Don't round the L1 table allocation up to " Alberto Garcia
2020-01-08 17:49 ` [PATCH 3/3] qcow2: Use BDRV_SECTOR_SIZE instead of the hardcoded value Alberto Garcia
2020-01-08 19:33 ` Nir Soffer
2020-01-09 12:19 ` Kevin Wolf [this message]
2020-01-09 12:30 ` Alberto Garcia
2020-01-09 12:43 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200109121900.GF9504@linux.fritz.box \
--to=kwolf@redhat.com \
--cc=berto@igalia.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).