From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Tong Ho <tong.ho@xilinx.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [PATCH] crypto: fix getter of a QCryptoSecret's property
Date: Fri, 10 Jan 2020 09:35:15 +0000 [thread overview]
Message-ID: <20200110093515.GC3423494@redhat.com> (raw)
In-Reply-To: <1578600598-335744-1-git-send-email-tong.ho@xilinx.com>
On Thu, Jan 09, 2020 at 12:09:58PM -0800, Tong Ho wrote:
> This fixes the condition-check done by the "loaded" property
> getter, such that the property returns true even when the
> secret is loaded by the 'file' option.
>
> Signed-off-by: Tong Ho <tong.ho@xilinx.com>
> ---
> Pre-existing getter returns true only when the secret is loaded
> by the 'data' option.
>
> crypto/secret.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Added to my pending queue
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
prev parent reply other threads:[~2020-01-10 9:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-09 20:09 [PATCH] crypto: fix getter of a QCryptoSecret's property Tong Ho
2020-01-10 9:35 ` Daniel P. Berrangé [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200110093515.GC3423494@redhat.com \
--to=berrange@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=tong.ho@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).