From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7F0DC33CA2 for ; Fri, 10 Jan 2020 09:36:12 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9959C20721 for ; Fri, 10 Jan 2020 09:36:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="cfRGJG4V" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9959C20721 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:43102 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ipqiB-0003cc-Js for qemu-devel@archiver.kernel.org; Fri, 10 Jan 2020 04:36:11 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:55786) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ipqhQ-0002vt-LZ for qemu-devel@nongnu.org; Fri, 10 Jan 2020 04:35:25 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ipqhP-0004DL-I0 for qemu-devel@nongnu.org; Fri, 10 Jan 2020 04:35:24 -0500 Received: from us-smtp-2.mimecast.com ([205.139.110.61]:43672 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ipqhP-0004As-CO for qemu-devel@nongnu.org; Fri, 10 Jan 2020 04:35:23 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1578648922; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xFhxeMUjTXhcRcV5HAseFSxOv/MgJKw0dU5MmlIiR+E=; b=cfRGJG4VQnP6k4dg7Awq4E6+sh/KCatx95CqhOcVlTr7QYR8P2XTGtGW9mtWaZ5G8GbKXg vYWMqIUyDTh+0ytyaC8XMitQFPjomhV8XJbbEJdwT1FI6LDJ2et6dl1tCJkNmnosCXw8p1 atC8HI11ftfnXrKW4FuFBWVgrwQeiMM= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-130-ohu6aOKwOL23AI6lS1HRnQ-1; Fri, 10 Jan 2020 04:35:21 -0500 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 2ECCE477; Fri, 10 Jan 2020 09:35:20 +0000 (UTC) Received: from redhat.com (ovpn-112-65.ams2.redhat.com [10.36.112.65]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 2CB2886CCA; Fri, 10 Jan 2020 09:35:18 +0000 (UTC) Date: Fri, 10 Jan 2020 09:35:15 +0000 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Tong Ho Subject: Re: [PATCH] crypto: fix getter of a QCryptoSecret's property Message-ID: <20200110093515.GC3423494@redhat.com> References: <1578600598-335744-1-git-send-email-tong.ho@xilinx.com> MIME-Version: 1.0 In-Reply-To: <1578600598-335744-1-git-send-email-tong.ho@xilinx.com> User-Agent: Mutt/1.12.1 (2019-06-15) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-MC-Unique: ohu6aOKwOL23AI6lS1HRnQ-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 205.139.110.61 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Cc: qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Thu, Jan 09, 2020 at 12:09:58PM -0800, Tong Ho wrote: > This fixes the condition-check done by the "loaded" property > getter, such that the property returns true even when the > secret is loaded by the 'file' option. >=20 > Signed-off-by: Tong Ho > --- > Pre-existing getter returns true only when the secret is loaded > by the 'data' option. >=20 > crypto/secret.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) Reviewed-by: Daniel P. Berrang=C3=A9 Added to my pending queue Regards, Daniel --=20 |: https://berrange.com -o- https://www.flickr.com/photos/dberrange= :| |: https://libvirt.org -o- https://fstop138.berrange.com= :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange= :|