From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D700C33CAD for ; Mon, 13 Jan 2020 12:38:10 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0771A20CC7 for ; Mon, 13 Jan 2020 12:38:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="U8BO576I" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0771A20CC7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:49534 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iqyyv-0000S5-71 for qemu-devel@archiver.kernel.org; Mon, 13 Jan 2020 07:38:09 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:35241) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iqyy5-00080o-OQ for qemu-devel@nongnu.org; Mon, 13 Jan 2020 07:37:19 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iqyy3-0005P8-1N for qemu-devel@nongnu.org; Mon, 13 Jan 2020 07:37:16 -0500 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:49988 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iqyy2-0005MJ-Fd for qemu-devel@nongnu.org; Mon, 13 Jan 2020 07:37:14 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1578919033; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PPc1Xk2yvy7/cs1SbtCSLT4g2uYuUuhz/paLpBUWttM=; b=U8BO576IzktRoak1AXNRY6UWoG18o6G7HK3SEGSUI2V+Culwrf6c17NJ+rbzBs/lku9icR kazTXkCzHo8fSmI6cwQzkR0GTbeE34p+oyeVDI71mFtr/XPzvOI82L0uhF/tSBzCl8UbDd ELxDLwJ+B6qAnZE+jmZprE6HZKvmCc0= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-192-5wh9VXhqM22ttng1CfXbBQ-1; Mon, 13 Jan 2020 07:37:12 -0500 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 2EF6F2EE3; Mon, 13 Jan 2020 12:37:11 +0000 (UTC) Received: from localhost (unknown [10.43.2.114]) by smtp.corp.redhat.com (Postfix) with ESMTP id C1A4087EC6; Mon, 13 Jan 2020 12:37:04 +0000 (UTC) Date: Mon, 13 Jan 2020 13:37:02 +0100 From: Igor Mammedov To: Heyi Guo Subject: Re: [PATCH 1/2] arm/virt/acpi: remove meaningless sub device "PR0" from PCI0 Message-ID: <20200113133702.1dea867b@redhat.com> In-Reply-To: <20191219064759.35053-2-guoheyi@huawei.com> References: <20191219064759.35053-1-guoheyi@huawei.com> <20191219064759.35053-2-guoheyi@huawei.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-MC-Unique: 5wh9VXhqM22ttng1CfXbBQ-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 205.139.110.120 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , "Michael S. Tsirkin" , Julia Suvorova , qemu-devel@nongnu.org, Shannon Zhao , qemu-arm@nongnu.org, wanghaibin.wang@huawei.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Thu, 19 Dec 2019 14:47:58 +0800 Heyi Guo wrote: > The sub device "PR0" under PCI0 in ACPI/DSDT does not make any sense, > so simply remote it. Could you make commit message more concrete so it would say why it doesn't make any sense. It seems to be there to describe root port, I'd rather have PCI folk ack if it's ok to remove it. > > Signed-off-by: Heyi Guo > > --- > Cc: Peter Maydell > Cc: "Michael S. Tsirkin" > Cc: Igor Mammedov > Cc: Shannon Zhao > Cc: qemu-arm@nongnu.org > Cc: qemu-devel@nongnu.org > --- > hw/arm/virt-acpi-build.c | 4 ---- > tests/data/acpi/virt/DSDT | Bin 18462 -> 18449 bytes > tests/data/acpi/virt/DSDT.memhp | Bin 19799 -> 19786 bytes > tests/data/acpi/virt/DSDT.numamem | Bin 18462 -> 18449 bytes > 4 files changed, 4 deletions(-) > > diff --git a/hw/arm/virt-acpi-build.c b/hw/arm/virt-acpi-build.c > index bd5f771e9b..9f4c7d1889 100644 > --- a/hw/arm/virt-acpi-build.c > +++ b/hw/arm/virt-acpi-build.c > @@ -317,10 +317,6 @@ static void acpi_dsdt_add_pci(Aml *scope, const MemMapEntry *memmap, > aml_append(method, aml_return(buf)); > aml_append(dev, method); > > - Aml *dev_rp0 = aml_device("%s", "RP0"); > - aml_append(dev_rp0, aml_name_decl("_ADR", aml_int(0))); > - aml_append(dev, dev_rp0); > - > Aml *dev_res0 = aml_device("%s", "RES0"); > aml_append(dev_res0, aml_name_decl("_HID", aml_string("PNP0C02"))); > crs = aml_resource_template(); > diff --git a/tests/data/acpi/virt/DSDT b/tests/data/acpi/virt/DSDT > index d0f3afeb134fdf1c11f64cd06dbcdd30be603b80..b5895cb22446860a0b9be3d32ec856feb388be4c 100644 > GIT binary patch > delta 39 > vcmbO?fpOvlMlP3Nmk>b@1_q`B6S<_Bdg?Z+cXBfI+}XT|v(|R9jr$`2@RSW) > > delta 50 > zcmbO@fpOjhMlP3Nmk>D*1_q{tiCof5o%I{lJ2{y;?{412S!>J19TZ>?&k^tF5;R%I > G{V4!>hYx%J > > diff --git a/tests/data/acpi/virt/DSDT.memhp b/tests/data/acpi/virt/DSDT.memhp > index 41ccc6431b917252bcbaac86c33b340c796be5ce..69ad844f65d047973a3e55198beecd45a35b8fce 100644 > GIT binary patch > delta 40 > wcmcaUi}BPfMlP3Nmk=*s1_q}3iCof5t(P{ccXBfI+}XT|v(|RAjk`1(02g)*ivR!s > > delta 51 > zcmX>#i}Cs_MlP3NmymE@1_mbiiCof5O_w*ScXBdy-rc;3v(}c2J1D>)o+IATC1|sb > HyBr$;t7;Fc > > diff --git a/tests/data/acpi/virt/DSDT.numamem b/tests/data/acpi/virt/DSDT.numamem > index d0f3afeb134fdf1c11f64cd06dbcdd30be603b80..b5895cb22446860a0b9be3d32ec856feb388be4c 100644 > GIT binary patch > delta 39 > vcmbO?fpOvlMlP3Nmk>b@1_q`B6S<_Bdg?Z+cXBfI+}XT|v(|R9jr$`2@RSW) > > delta 50 > zcmbO@fpOjhMlP3Nmk>D*1_q{tiCof5o%I{lJ2{y;?{412S!>J19TZ>?&k^tF5;R%I > G{V4!>hYx%J >