From: Kevin Wolf <kwolf@redhat.com>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: marcandre.lureau@gmail.com, qemu-devel@nongnu.org,
qemu-block@nongnu.org, armbru@redhat.com
Subject: Re: [PATCH 2/4] block: Mark 'block_resize' as coroutine
Date: Mon, 13 Jan 2020 18:10:09 +0100 [thread overview]
Message-ID: <20200113171009.GH5549@linux.fritz.box> (raw)
In-Reply-To: <20200113165648.GD103384@stefanha-x1.localdomain>
[-- Attachment #1: Type: text/plain, Size: 1082 bytes --]
Am 13.01.2020 um 17:56 hat Stefan Hajnoczi geschrieben:
> On Thu, Jan 09, 2020 at 07:35:43PM +0100, Kevin Wolf wrote:
> > block_resize is safe to run in a coroutine, so use it as an example for
> > the new 'coroutine': true annotation in the QAPI schema.
> >
> > Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> > ---
> > qapi/block-core.json | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/qapi/block-core.json b/qapi/block-core.json
> > index 7ff5e5edaf..1dbb2a9901 100644
> > --- a/qapi/block-core.json
> > +++ b/qapi/block-core.json
> > @@ -1341,7 +1341,8 @@
> > { 'command': 'block_resize',
> > 'data': { '*device': 'str',
> > '*node-name': 'str',
> > - 'size': 'int' } }
> > + 'size': 'int' },
> > + 'coroutine': true }
> >
> > ##
> > # @NewImageMode:
>
> coroutine_fn is missing on
> blockdev.c:void qmp_block_resize(bool has_device, const char *device,
It wouldn't even be true until after patch 4. Should I reorder the
patches so I can add coroutine_fn?
Kevin
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
next prev parent reply other threads:[~2020-01-13 17:11 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-09 18:35 [PATCH 0/4] qmp: Optionally run handlers in coroutines Kevin Wolf
2020-01-09 18:35 ` [PATCH 1/4] qapi: Add a 'coroutine' flag for commands Kevin Wolf
2020-01-10 19:00 ` Eric Blake
2020-01-13 10:46 ` Kevin Wolf
2020-01-09 18:35 ` [PATCH 2/4] block: Mark 'block_resize' as coroutine Kevin Wolf
2020-01-13 16:56 ` Stefan Hajnoczi
2020-01-13 17:10 ` Kevin Wolf [this message]
2020-01-14 16:30 ` Stefan Hajnoczi
2020-01-09 18:35 ` [PATCH 3/4] vl: Initialise main loop earlier Kevin Wolf
2020-01-09 18:35 ` [PATCH 4/4] qmp: Move dispatcher to a coroutine Kevin Wolf
2020-01-13 7:00 ` [PATCH 0/4] qmp: Optionally run handlers in coroutines Marc-André Lureau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200113171009.GH5549@linux.fritz.box \
--to=kwolf@redhat.com \
--cc=armbru@redhat.com \
--cc=marcandre.lureau@gmail.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).