Re: [PATCH v2 1/1] s390x/event-facility.c: remove unneeded labels

[Cornelia Huck <cohuck@redhat.com>]

On Wed,  8 Jan 2020 11:46:07 -0300
Daniel Henrique Barboza <danielhb413@gmail.com> wrote:

> 'out' label from write_event_mask() and and write_event_data()

s/and and/and/

> can be replaced by 'return'.
> 
> The 'out' label from read_event_data() can also be replaced.
> However, as suggested by Cornelia Huck, instead of simply
> replacing the 'out' label, let's also change the code flow
> a bit to make it clearer that sccb events are always handled
> regardless of the mask for unconditional reads, while selective
> reads are handled if the mask is valid.
> 
> CC: Cornelia Huck <cohuck@redhat.com>
> CC: Thomas Huth <thuth@redhat.com>
> CC: Halil Pasic <pasic@linux.ibm.com>
> CC: Christian Borntraeger <borntraeger@de.ibm.com>
> Signed-off-by: Daniel Henrique Barboza <danielhb413@gmail.com>
> ---
> 
> This is the v2 of patch 37 sent in the series:
> 
> https://patchwork.kernel.org/cover/11319771/
> 
> after this review from Cornelia:
> 
> https://patchwork.kernel.org/patch/11319847/#23088037
> 
>  hw/s390x/event-facility.c | 33 ++++++++++++---------------------
>  1 file changed, 12 insertions(+), 21 deletions(-)

Thanks, applied.