From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7E54C33CB3 for ; Thu, 16 Jan 2020 10:45:31 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A81A02077B for ; Thu, 16 Jan 2020 10:45:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="HLFpTaAy" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A81A02077B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:39654 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1is2eY-0005aL-Oq for qemu-devel@archiver.kernel.org; Thu, 16 Jan 2020 05:45:30 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:48825) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1is2ds-00059w-Rl for qemu-devel@nongnu.org; Thu, 16 Jan 2020 05:44:49 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1is2dp-000848-9U for qemu-devel@nongnu.org; Thu, 16 Jan 2020 05:44:48 -0500 Received: from us-smtp-1.mimecast.com ([207.211.31.81]:60920 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1is2dp-00083P-59 for qemu-devel@nongnu.org; Thu, 16 Jan 2020 05:44:45 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1579171484; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=AtCeJ0Csack3tJv9RQ0iunfDJjP3QtH4z4TjL/5aBzQ=; b=HLFpTaAyzCvBSFjmQjlWytc3392aKjhmN5u8tKnmLL6/zQ+H6IB9uaYSrv59YmB/spfE2b eVa3IHT2Cu3MmIejk8aGtPymaulauQ/i2idksnwQ4JGVLGCH8GtPgIDUczrlqPRvBgQHPP 9AZcRqlEiiUbHDtAhUYJEfH90FI+MfE= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-225-fo-pwvUMNHmHrVDxJVOUWA-1; Thu, 16 Jan 2020 05:44:41 -0500 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 5239310054E3; Thu, 16 Jan 2020 10:44:40 +0000 (UTC) Received: from localhost (unknown [10.43.2.114]) by smtp.corp.redhat.com (Postfix) with ESMTP id D4FEAA4B60; Thu, 16 Jan 2020 10:44:36 +0000 (UTC) Date: Thu, 16 Jan 2020 11:44:35 +0100 From: Igor Mammedov To: Keqian Zhu Subject: Re: [PATCH] hw/arm: Adjust some coding styles about memory hotplug Message-ID: <20200116114435.189402e6@redhat.com> In-Reply-To: <20200116074029.45952-1-zhukeqian1@huawei.com> References: <20200116074029.45952-1-zhukeqian1@huawei.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-MC-Unique: fo-pwvUMNHmHrVDxJVOUWA-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 207.211.31.81 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: wanghaibin.wang@huawei.com, qemu-devel@nongnu.org, Shameer Kolothum , "Michael S. Tsirkin" Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Thu, 16 Jan 2020 15:40:29 +0800 Keqian Zhu wrote: > From: zhukeqian > > There is extra indent in ACPI GED plug cb. And we can use > existing helper function to trigger hotplug handler plug. > > Signed-off-by: Keqian Zhu > Cc: Shameer Kolothum > Cc: "Michael S. Tsirkin" > Cc: Igor Mammedov Reviewed-by: Igor Mammedov > --- > hw/acpi/generic_event_device.c | 2 +- > hw/arm/virt.c | 6 +++--- > 2 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/hw/acpi/generic_event_device.c b/hw/acpi/generic_event_device.c > index 9cee90cc70..55eb29d80a 100644 > --- a/hw/acpi/generic_event_device.c > +++ b/hw/acpi/generic_event_device.c > @@ -175,7 +175,7 @@ static void acpi_ged_device_plug_cb(HotplugHandler *hotplug_dev, > AcpiGedState *s = ACPI_GED(hotplug_dev); > > if (object_dynamic_cast(OBJECT(dev), TYPE_PC_DIMM)) { > - acpi_memory_plug_cb(hotplug_dev, &s->memhp_state, dev, errp); > + acpi_memory_plug_cb(hotplug_dev, &s->memhp_state, dev, errp); > } else { > error_setg(errp, "virt: device plug request for unsupported device" > " type: %s", object_get_typename(OBJECT(dev))); > diff --git a/hw/arm/virt.c b/hw/arm/virt.c > index 39ab5f47e0..656b0081c2 100644 > --- a/hw/arm/virt.c > +++ b/hw/arm/virt.c > @@ -1934,7 +1934,6 @@ static void virt_memory_pre_plug(HotplugHandler *hotplug_dev, DeviceState *dev, > static void virt_memory_plug(HotplugHandler *hotplug_dev, > DeviceState *dev, Error **errp) > { > - HotplugHandlerClass *hhc; > VirtMachineState *vms = VIRT_MACHINE(hotplug_dev); > Error *local_err = NULL; > > @@ -1943,8 +1942,9 @@ static void virt_memory_plug(HotplugHandler *hotplug_dev, > goto out; > } > > - hhc = HOTPLUG_HANDLER_GET_CLASS(vms->acpi_dev); > - hhc->plug(HOTPLUG_HANDLER(vms->acpi_dev), dev, &error_abort); > + hotplug_handler_plug(HOTPLUG_HANDLER(vms->acpi_dev), > + dev, &error_abort); > + > out: > error_propagate(errp, local_err); > }