From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF724C33CAF for ; Thu, 16 Jan 2020 17:11:00 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 79A6C2468A for ; Thu, 16 Jan 2020 17:11:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="UOvjlgQK" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 79A6C2468A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:45564 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1is8fb-0004yJ-Im for qemu-devel@archiver.kernel.org; Thu, 16 Jan 2020 12:10:59 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:55263) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1is8eu-0004FY-5N for qemu-devel@nongnu.org; Thu, 16 Jan 2020 12:10:20 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1is8ep-0002lt-Bs for qemu-devel@nongnu.org; Thu, 16 Jan 2020 12:10:15 -0500 Received: from us-smtp-1.mimecast.com ([205.139.110.61]:22993 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1is8ep-0002l8-4N for qemu-devel@nongnu.org; Thu, 16 Jan 2020 12:10:11 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1579194609; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=p+YK8qYKOtZxmyeDoFXqKuKE3uRsglNGylMKmX4bJrA=; b=UOvjlgQK+Aq6k2CFCcI8PWah6iAoU15gews1KVpCWgCEu7LWvem++xqQYm4fBc4/+BGJpe h5oVuVAqS1tnaRHxevDKGJ4KK74h18Wi7UeEKHpJhmsPJq59M6OpH8GqAshtG9BVxIi1EZ z/hEbHFI0Hc+GHYgtq5wQR8hXzM8b7A= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-146-HELCeKoBP-G5n1O61nEeoA-1; Thu, 16 Jan 2020 12:10:06 -0500 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id A9AB7800EBF; Thu, 16 Jan 2020 17:10:05 +0000 (UTC) Received: from localhost (unknown [10.43.2.114]) by smtp.corp.redhat.com (Postfix) with ESMTP id 7E9CB858B4; Thu, 16 Jan 2020 17:10:01 +0000 (UTC) Date: Thu, 16 Jan 2020 18:10:00 +0100 From: Igor Mammedov To: Thomas Huth Subject: Re: [PATCH v2 85/86] numa: make exit() usage consistent Message-ID: <20200116181000.7ab83443@redhat.com> In-Reply-To: References: <1579100861-73692-1-git-send-email-imammedo@redhat.com> <1579100861-73692-86-git-send-email-imammedo@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-MC-Unique: HELCeKoBP-G5n1O61nEeoA-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 205.139.110.61 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Laurent Vivier , Peter Maydell , ehabkost@redhat.com, Riku Voipio , qemu-devel@nongnu.org, David Gibson , Philippe =?UTF-8?B?TWF0aGlldS1EYXVkw6k=?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Thu, 16 Jan 2020 17:43:30 +0100 Thomas Huth wrote: > On 15/01/2020 16.07, Igor Mammedov wrote: > > Signed-off-by: Igor Mammedov > > --- > > CC: ehabkost@redhat.com > > --- > > hw/core/numa.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/hw/core/numa.c b/hw/core/numa.c > > index 3177066..47d5ea1 100644 > > --- a/hw/core/numa.c > > +++ b/hw/core/numa.c > > @@ -718,7 +718,7 @@ void numa_complete_configuration(MachineState *ms) > > /* Report large node IDs first, to make mistakes easier to spot */ > > if (!numa_info[i].present) { > > error_report("numa: Node ID missing: %d", i); > > - exit(1); > > + exit(EXIT_FAILURE); > > } > > } > > > > @@ -759,7 +759,7 @@ void numa_complete_configuration(MachineState *ms) > > error_report("total memory for NUMA nodes (0x%" PRIx64 ")" > > " should equal RAM size (0x" RAM_ADDR_FMT ")", > > numa_total, ram_size); > > - exit(1); > > + exit(EXIT_FAILURE); > > } > > > > if (!numa_uses_legacy_mem()) { > > Please don't. We've had exit(1) vs. exit(EXIT_FAILURE) discussions in > the past already, and IIRC there was no clear conclusion which one we > want to use. There are examples of changes to the numeric value in our > git history (see d54e4d7659ebecd0e1fa7ffc3e954197e09f8a1f for example), > and example of the other way round (see 4d1275c24d5d64d22ec4a30ce1b6a0 > for example). > > Your patch series here is already big enough, so I suggest to drop this > patch from the series. If you want to change this, please suggest an > update to CODING_STYLE.rst first so that we agree upon one style for > exit() ... otherwise somebody else might change this back into numeric > values in a couple of months just because they have a different taste. Ok, will do. There are other patches that introduce new exit(EXIT_FAILURE), is it fine to use that or should I stick to the style used in nearby code? > > Thomas