qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
To: qemu-devel@nongnu.org
Cc: pbonzini@redhat.com, vkuznets@redhat.com, jasowang@redhat.com,
	mst@redhat.com
Subject: Re: [PATCH v3 0/2] Fix hyperv synic on vhost
Date: Fri, 17 Jan 2020 12:47:07 +0000	[thread overview]
Message-ID: <20200117124707.GG3209@work-vm> (raw)
In-Reply-To: <157922066484.433.7316108748419062411@197193fa8d23>

* no-reply@patchew.org (no-reply@patchew.org) wrote:
> Patchew URL: https://patchew.org/QEMU/20200116202414.157959-1-dgilbert@redhat.com/
> 
> 
> 
> Hi,
> 
> This series seems to have some coding style problems. See output below for
> more information:
> 
> Message-id: 20200116202414.157959-1-dgilbert@redhat.com
> Type: series
> Subject: [PATCH v3 0/2] Fix hyperv synic on vhost
> 
> === TEST SCRIPT BEGIN ===
> #!/bin/bash
> git rev-parse base > /dev/null || exit 0
> git config --local diff.renamelimit 0
> git config --local diff.renames True
> git config --local diff.algorithm histogram
> ./scripts/checkpatch.pl --mailback base..
> === TEST SCRIPT END ===
> 
> From https://github.com/patchew-project/qemu
>  * [new tag]         patchew/20200116202414.157959-1-dgilbert@redhat.com -> patchew/20200116202414.157959-1-dgilbert@redhat.com
> Switched to a new branch 'test'
> f7aeff2 vhost: Only align sections for vhost-user
> 5bb467f vhost: Add names to section rounded warning
> 
> === OUTPUT BEGIN ===
> 1/2 Checking commit 5bb467f4ac3b (vhost: Add names to section rounded warning)
> 2/2 Checking commit f7aeff24a99a (vhost: Only align sections for vhost-user)
> ERROR: trailing whitespace
> #45: FILE: hw/virtio/vhost.c:554:
> +    if (dev->vhost_ops->backend_type == VHOST_BACKEND_TYPE_USER) {   $
> 
> WARNING: line over 80 characters
> #60: FILE: hw/virtio/vhost.c:569:
> +        trace_vhost_region_add_section_aligned(section->mr->name, mrs_gpa, mrs_size,
> 
> total: 1 errors, 1 warnings, 43 lines checked

Oops, minor whitespace; easy to fix if people actually like this fix.

Dave

> Patch 2/2 has style problems, please review.  If any of these errors
> are false positives report them to the maintainer, see
> CHECKPATCH in MAINTAINERS.
> 
> === OUTPUT END ===
> 
> Test command exited with code: 1
> 
> 
> The full log is available at
> http://patchew.org/logs/20200116202414.157959-1-dgilbert@redhat.com/testing.checkpatch/?type=message.
> ---
> Email generated automatically by Patchew [https://patchew.org/].
> Please send your feedback to patchew-devel@redhat.com
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK



      reply	other threads:[~2020-01-17 12:48 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-16 20:24 [PATCH v3 0/2] Fix hyperv synic on vhost Dr. David Alan Gilbert (git)
2020-01-16 20:24 ` [PATCH v3 1/2] vhost: Add names to section rounded warning Dr. David Alan Gilbert (git)
2020-01-16 20:24 ` [PATCH v3 2/2] vhost: Only align sections for vhost-user Dr. David Alan Gilbert (git)
2020-01-17 12:52   ` Paolo Bonzini
2020-01-17 13:40     ` Michael S. Tsirkin
2020-01-17 13:58       ` Paolo Bonzini
2020-01-17 14:25         ` Michael S. Tsirkin
2020-01-17 15:06           ` Paolo Bonzini
2020-01-17 15:10         ` Dr. David Alan Gilbert
2020-01-17  0:24 ` [PATCH v3 0/2] Fix hyperv synic on vhost no-reply
2020-01-17 12:47   ` Dr. David Alan Gilbert [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200117124707.GG3209@work-vm \
    --to=dgilbert@redhat.com \
    --cc=jasowang@redhat.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=vkuznets@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).