From: KJ Liew <liewkj@yahoo.com>
To: qemu-devel@nongnu.org
Subject: [PATCH] audio/sdl2: fix unrecognized audio format
Date: Sun, 19 Jan 2020 18:44:22 -0800 [thread overview]
Message-ID: <20200120024422.GA686@PC-SEANJYE> (raw)
In-Reply-To: 20200120024422.GA686.ref@PC-SEANJYE
On Windows/SDL2, SDL_OpenAudio() may obtain audio format different from
requested format.
QEMU trace:
sdl: sdl_open: req.fmt = 0x8010 obt.fmt = 0x8120
sdl: Unrecognized SDL audio format 33056
sdl: SDL_OpenAudio failed
The easiest fix is to force audio format conversion internal to SDL2.
diff -ru ../orig/qemu-4.2.0/audio/sdlaudio.c ../qemu-4.2.0/audio/sdlaudio.c
--- ../orig/qemu-4.2.0/audio/sdlaudio.c 2019-12-12 10:20:47.000000000 -0800
+++ ../qemu-4.2.0/audio/sdlaudio.c 2020-01-15 15:56:25.059841600 -0800
@@ -147,10 +147,11 @@
}
#endif
- status = SDL_OpenAudio (req, obt);
+ status = SDL_OpenAudio (req, NULL);
if (status) {
sdl_logerr ("SDL_OpenAudio failed\n");
}
+ memcpy(obt, req, sizeof(SDL_AudioSpec));
#ifndef _WIN32
err = pthread_sigmask (SIG_SETMASK, &old, NULL);
parent reply other threads:[~2020-01-20 2:45 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20200120024422.GA686.ref@PC-SEANJYE>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200120024422.GA686@PC-SEANJYE \
--to=liewkj@yahoo.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).