* [PATCH] audio/oss: fix buffer pos calculation
@ 2020-01-20 10:18 Gerd Hoffmann
2020-01-20 11:12 ` Philippe Mathieu-Daudé
0 siblings, 1 reply; 2+ messages in thread
From: Gerd Hoffmann @ 2020-01-20 10:18 UTC (permalink / raw)
To: qemu-devel; +Cc: Gerd Hoffmann, Kővágó Zoltán
Fixes: 3ba4066d085f ("ossaudio: port to the new audio backend api")
Reported-by: ziming zhang <ezrakiez@gmail.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
audio/ossaudio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/audio/ossaudio.c b/audio/ossaudio.c
index c43faeeea4aa..94564916fbf0 100644
--- a/audio/ossaudio.c
+++ b/audio/ossaudio.c
@@ -420,7 +420,7 @@ static size_t oss_write(HWVoiceOut *hw, void *buf, size_t len)
size_t to_copy = MIN(len, hw->size_emul - hw->pos_emul);
memcpy(hw->buf_emul + hw->pos_emul, buf, to_copy);
- hw->pos_emul = (hw->pos_emul + to_copy) % hw->pos_emul;
+ hw->pos_emul = (hw->pos_emul + to_copy) % hw->size_emul;
buf += to_copy;
len -= to_copy;
}
--
2.18.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] audio/oss: fix buffer pos calculation
2020-01-20 10:18 [PATCH] audio/oss: fix buffer pos calculation Gerd Hoffmann
@ 2020-01-20 11:12 ` Philippe Mathieu-Daudé
0 siblings, 0 replies; 2+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-01-20 11:12 UTC (permalink / raw)
To: Gerd Hoffmann, qemu-devel; +Cc: Kővágó Zoltán
On 1/20/20 11:18 AM, Gerd Hoffmann wrote:
> Fixes: 3ba4066d085f ("ossaudio: port to the new audio backend api")
> Reported-by: ziming zhang <ezrakiez@gmail.com>
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
> audio/ossaudio.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/audio/ossaudio.c b/audio/ossaudio.c
> index c43faeeea4aa..94564916fbf0 100644
> --- a/audio/ossaudio.c
> +++ b/audio/ossaudio.c
> @@ -420,7 +420,7 @@ static size_t oss_write(HWVoiceOut *hw, void *buf, size_t len)
> size_t to_copy = MIN(len, hw->size_emul - hw->pos_emul);
> memcpy(hw->buf_emul + hw->pos_emul, buf, to_copy);
>
> - hw->pos_emul = (hw->pos_emul + to_copy) % hw->pos_emul;
> + hw->pos_emul = (hw->pos_emul + to_copy) % hw->size_emul;
Interestingly oss_put_buffer_out() is correct.
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> buf += to_copy;
> len -= to_copy;
> }
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-01-20 11:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-01-20 10:18 [PATCH] audio/oss: fix buffer pos calculation Gerd Hoffmann
2020-01-20 11:12 ` Philippe Mathieu-Daudé
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).