From: minyard@acm.org
To: QEMU Developers <qemu-devel@nongnu.org>
Cc: "Philippe Mathieu-Daudé" <philmd@redhat.com>
Subject: [PATCH 4/5] hw/i2c/Kconfig: Add an entry for the SMBus
Date: Mon, 20 Jan 2020 11:07:24 -0600 [thread overview]
Message-ID: <20200120170725.24935-5-minyard@acm.org> (raw)
In-Reply-To: <20200120170725.24935-1-minyard@acm.org>
From: Philippe Mathieu-Daudé <philmd@redhat.com>
The System Management Bus is more or less a derivative of the I2C
bus, thus the Kconfig entry depends of I2C.
Not all boards providing an I2C bus support SMBus.
Use two different Kconfig entries to be able to select I2C without
selecting SMBus.
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-Id: <20191231183216.6781-6-philmd@redhat.com>
---
hw/i2c/Kconfig | 8 ++++++--
hw/i2c/Makefile.objs | 3 ++-
2 files changed, 8 insertions(+), 3 deletions(-)
diff --git a/hw/i2c/Kconfig b/hw/i2c/Kconfig
index 2bbd395813..09642a6dcb 100644
--- a/hw/i2c/Kconfig
+++ b/hw/i2c/Kconfig
@@ -1,9 +1,13 @@
config I2C
bool
+config SMBUS
+ bool
+ select I2C
+
config SMBUS_EEPROM
bool
- depends on I2C
+ select SMBUS
config VERSATILE_I2C
bool
@@ -11,7 +15,7 @@ config VERSATILE_I2C
config ACPI_SMBUS
bool
- select I2C
+ select SMBUS
config BITBANG_I2C
bool
diff --git a/hw/i2c/Makefile.objs b/hw/i2c/Makefile.objs
index d7073a401f..cbbc8507a3 100644
--- a/hw/i2c/Makefile.objs
+++ b/hw/i2c/Makefile.objs
@@ -1,4 +1,5 @@
-common-obj-$(CONFIG_I2C) += core.o smbus_slave.o smbus_master.o
+common-obj-$(CONFIG_I2C) += core.o
+common-obj-$(CONFIG_SMBUS) += smbus_slave.o smbus_master.o
common-obj-$(CONFIG_SMBUS_EEPROM) += smbus_eeprom.o
common-obj-$(CONFIG_VERSATILE_I2C) += versatile_i2c.o
common-obj-$(CONFIG_ACPI_X86_ICH) += smbus_ich9.o
--
2.17.1
next prev parent reply other threads:[~2020-01-20 17:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-20 17:07 [PATCH 0/5] IPMI patch queue minyard
2020-01-20 17:07 ` [PATCH 1/5] ipmi: Add man page pieces for the IPMI PCI devices minyard
2020-01-20 17:07 ` [PATCH 2/5] smbus-eeprom: remove PROP_PTR minyard
2020-01-20 17:07 ` [PATCH 3/5] ipmi: add SET_SENSOR_READING command minyard
2020-01-20 17:07 ` minyard [this message]
2020-01-20 17:07 ` [PATCH 5/5] i386:acpi: Remove _HID from the SMBus ACPI entry minyard
2020-01-22 5:37 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200120170725.24935-5-minyard@acm.org \
--to=minyard@acm.org \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).