From: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
To: qemu-devel@nongnu.org
Cc: "Sarah Harris" <S.E.Harris@kent.ac.uk>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"Michael Rolnik" <mrolnik@gmail.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Aleksandar Markovic" <aleksandar.m.mail@gmail.com>,
"Richard Henderson" <rth@twiddle.net>
Subject: [PATCH v4 09/18] hw/char: Rename avr_usart -> atmel_usart
Date: Mon, 20 Jan 2020 23:00:58 +0100 [thread overview]
Message-ID: <20200120220107.17825-10-f4bug@amsat.org> (raw)
In-Reply-To: <20200120220107.17825-1-f4bug@amsat.org>
AVR is the architecture, Atmel the manufacturer.
Suggested-by: Aleksandar Markovic <aleksandar.m.mail@gmail.com>
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
!squash
---
include/hw/char/{avr_usart.h => atmel_usart.h} | 10 +++++-----
hw/avr/sample.c | 2 +-
hw/char/{avr_usart.c => atmel_usart.c} | 4 ++--
MAINTAINERS | 4 ++--
hw/avr/Kconfig | 2 +-
hw/char/Kconfig | 2 +-
hw/char/Makefile.objs | 2 +-
7 files changed, 13 insertions(+), 13 deletions(-)
rename include/hw/char/{avr_usart.h => atmel_usart.h} (93%)
rename hw/char/{avr_usart.c => atmel_usart.c} (99%)
diff --git a/include/hw/char/avr_usart.h b/include/hw/char/atmel_usart.h
similarity index 93%
rename from include/hw/char/avr_usart.h
rename to include/hw/char/atmel_usart.h
index 467e97e8c0..fd35feac60 100644
--- a/include/hw/char/avr_usart.h
+++ b/include/hw/char/atmel_usart.h
@@ -1,5 +1,5 @@
/*
- * AVR USART
+ * Atmel AVR USART
*
* Copyright (c) 2018 University of Kent
* Author: Sarah Harris
@@ -19,8 +19,8 @@
* <http://www.gnu.org/licenses/lgpl-2.1.html>
*/
-#ifndef HW_AVR_USART_H
-#define HW_AVR_USART_H
+#ifndef HW_CHAR_ATMEL_USART_H
+#define HW_CHAR_ATMEL_USART_H
#include "hw/sysbus.h"
#include "chardev/char-fe.h"
@@ -56,7 +56,7 @@
#define USART_CSRC_CSZ1 (1 << 2)
#define USART_CSRC_CSZ0 (1 << 1)
-#define TYPE_AVR_USART "avr-usart"
+#define TYPE_AVR_USART "atmel-usart"
#define AVR_USART(obj) \
OBJECT_CHECK(AVRUsartState, (obj), TYPE_AVR_USART)
@@ -90,4 +90,4 @@ typedef struct {
qemu_irq dre_irq;
} AVRUsartState;
-#endif /* HW_AVR_USART_H */
+#endif /* HW_CHAR_ATMEL_USART_H */
diff --git a/hw/avr/sample.c b/hw/avr/sample.c
index 95094a8d6c..ca67c11233 100644
--- a/hw/avr/sample.c
+++ b/hw/avr/sample.c
@@ -44,7 +44,7 @@
#include "qemu/error-report.h"
#include "exec/address-spaces.h"
#include "include/hw/sysbus.h"
-#include "include/hw/char/avr_usart.h"
+#include "include/hw/char/atmel_usart.h"
#include "include/hw/timer/avr_timer16.h"
#include "include/hw/misc/avr_mask.h"
#include "elf.h"
diff --git a/hw/char/avr_usart.c b/hw/char/atmel_usart.c
similarity index 99%
rename from hw/char/avr_usart.c
rename to hw/char/atmel_usart.c
index becdb87847..a7004c212a 100644
--- a/hw/char/avr_usart.c
+++ b/hw/char/atmel_usart.c
@@ -1,5 +1,5 @@
/*
- * AVR USART
+ * Atmel AVR USART
*
* Copyright (c) 2018 University of Kent
* Author: Sarah Harris
@@ -20,7 +20,7 @@
*/
#include "qemu/osdep.h"
-#include "hw/char/avr_usart.h"
+#include "hw/char/atmel_usart.h"
#include "qemu/log.h"
#include "hw/irq.h"
#include "hw/qdev-properties.h"
diff --git a/MAINTAINERS b/MAINTAINERS
index 4998fee99a..f2e01a6d16 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -896,8 +896,8 @@ M: Michael Rolnik <mrolnik@gmail.com>
R: Sarah Harris <S.E.Harris@kent.ac.uk>
S: Maintained
F: hw/avr/
-F: hw/char/avr_usart.c
-F: include/hw/char/avr_usart.h
+F: hw/char/atmel_usart.c
+F: include/hw/char/atmel_usart.h
F: hw/timer/avr_timer16.c
F: include/hw/timer/avr_timer16.h
F: hw/misc/avr_mask.c
diff --git a/hw/avr/Kconfig b/hw/avr/Kconfig
index 92aa1e6afb..8084a73176 100644
--- a/hw/avr/Kconfig
+++ b/hw/avr/Kconfig
@@ -1,6 +1,6 @@
config AVR_SAMPLE
bool
select AVR_TIMER16
- select AVR_USART
+ select ATMEL_USART
select AVR_MASK
select UNIMP
diff --git a/hw/char/Kconfig b/hw/char/Kconfig
index 331b20983f..5a27681884 100644
--- a/hw/char/Kconfig
+++ b/hw/char/Kconfig
@@ -47,5 +47,5 @@ config SCLPCONSOLE
config TERMINAL3270
bool
-config AVR_USART
+config ATMEL_USART
bool
diff --git a/hw/char/Makefile.objs b/hw/char/Makefile.objs
index f05c1f5667..c23ad3b4a7 100644
--- a/hw/char/Makefile.objs
+++ b/hw/char/Makefile.objs
@@ -21,7 +21,7 @@ obj-$(CONFIG_PSERIES) += spapr_vty.o
obj-$(CONFIG_DIGIC) += digic-uart.o
obj-$(CONFIG_STM32F2XX_USART) += stm32f2xx_usart.o
obj-$(CONFIG_RASPI) += bcm2835_aux.o
-common-obj-$(CONFIG_AVR_USART) += avr_usart.o
+common-obj-$(CONFIG_ATMEL_USART) += atmel_usart.o
common-obj-$(CONFIG_CMSDK_APB_UART) += cmsdk-apb-uart.o
common-obj-$(CONFIG_ETRAXFS) += etraxfs_ser.o
--
2.21.1
next prev parent reply other threads:[~2020-01-20 22:09 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-20 22:00 [PATCH v4 00/18] hw/avr: Introduce few Arduino boards Philippe Mathieu-Daudé
2020-01-20 22:00 ` [PATCH v4 01/18] MAINTAINERS: Move machine test to the machine section (not ARCH one) Philippe Mathieu-Daudé
2020-01-20 22:00 ` [PATCH v4 02/18] MAINTAINERS: Move the AVR machines in new section (not within ARM) Philippe Mathieu-Daudé
2020-01-20 22:00 ` [PATCH v4 03/18] tests/acceptance: Do not set the machine type manually Philippe Mathieu-Daudé
2020-01-20 22:00 ` [PATCH v4 04/18] tests/acceptance: Keep multilines comment consistent with other tests Philippe Mathieu-Daudé
2020-01-20 22:00 ` [PATCH v4 05/18] hw/char/avr: Reduce USART I/O size Philippe Mathieu-Daudé
2020-01-20 22:00 ` [PATCH v4 06/18] hw/timer/avr_timer16: Rename memory region debugging name Philippe Mathieu-Daudé
2020-01-20 22:00 ` [PATCH v4 07/18] hw/misc/avr_mask: Remove unused include Philippe Mathieu-Daudé
2020-01-20 22:00 ` [PATCH v4 08/18] hw/avr/Makefile: Use CONFIG_AVR_SAMPLE variable Philippe Mathieu-Daudé
2020-01-20 22:00 ` Philippe Mathieu-Daudé [this message]
2020-01-20 22:00 ` [PATCH v4 10/18] hw/timer: Rename avr_timer16 -> atmel_timer16 Philippe Mathieu-Daudé
2020-01-20 22:01 ` [PATCH v4 11/18] hw/misc: Rename avr_mask -> atmel_power Philippe Mathieu-Daudé
2020-01-20 22:01 ` [PATCH v4 12/18] hw/avr: Introduce ATMEL_ATMEGA_MCU config Philippe Mathieu-Daudé
2020-01-20 22:01 ` [PATCH v4 13/18] hw/avr: Add some ATmega microcontrollers Philippe Mathieu-Daudé
2020-01-20 22:01 ` [PATCH v4 14/18] hw/avr: Add some Arduino boards Philippe Mathieu-Daudé
2020-01-20 22:01 ` [PATCH v4 15/18] tests/boot-serial-test: Test some Arduino boards (AVR based) Philippe Mathieu-Daudé
2020-01-21 6:11 ` Thomas Huth
2020-01-20 22:01 ` [PATCH v4 16/18] tests/acceptance: Test the Arduino MEGA2560 board Philippe Mathieu-Daudé
2020-01-20 22:01 ` [PATCH v4 17/18] hw/avr: Remove the unrealistic AVR 'sample' board Philippe Mathieu-Daudé
2020-01-20 22:01 ` [PATCH v4 18/18] .travis.yml: Run the AVR acceptance tests Philippe Mathieu-Daudé
2020-01-20 23:30 ` [PATCH v4 00/18] hw/avr: Introduce few Arduino boards Philippe Mathieu-Daudé
2020-01-21 19:25 ` Michael Rolnik
2020-01-21 21:23 ` Philippe Mathieu-Daudé
2020-01-22 20:46 ` Richard Henderson
2020-01-22 21:56 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200120220107.17825-10-f4bug@amsat.org \
--to=f4bug@amsat.org \
--cc=S.E.Harris@kent.ac.uk \
--cc=aleksandar.m.mail@gmail.com \
--cc=marcandre.lureau@redhat.com \
--cc=mrolnik@gmail.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).