From: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
To: qemu-devel@nongnu.org
Cc: "Sarah Harris" <S.E.Harris@kent.ac.uk>,
"Michael Rolnik" <mrolnik@gmail.com>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"Aleksandar Markovic" <aleksandar.m.mail@gmail.com>,
"Richard Henderson" <rth@twiddle.net>
Subject: [PATCH v4 10/18] hw/timer: Rename avr_timer16 -> atmel_timer16
Date: Mon, 20 Jan 2020 23:00:59 +0100 [thread overview]
Message-ID: <20200120220107.17825-11-f4bug@amsat.org> (raw)
In-Reply-To: <20200120220107.17825-1-f4bug@amsat.org>
AVR is the architecture, Atmel the manufacturer.
Suggested-by: Aleksandar Markovic <aleksandar.m.mail@gmail.com>
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
!squash
---
include/hw/timer/{avr_timer16.h => atmel_timer16.h} | 10 +++++-----
hw/avr/sample.c | 2 +-
hw/timer/{avr_timer16.c => atmel_timer16.c} | 4 ++--
MAINTAINERS | 4 ++--
hw/avr/Kconfig | 2 +-
hw/timer/Kconfig | 2 +-
hw/timer/Makefile.objs | 2 +-
7 files changed, 13 insertions(+), 13 deletions(-)
rename include/hw/timer/{avr_timer16.h => atmel_timer16.h} (92%)
rename hw/timer/{avr_timer16.c => atmel_timer16.c} (99%)
diff --git a/include/hw/timer/avr_timer16.h b/include/hw/timer/atmel_timer16.h
similarity index 92%
rename from include/hw/timer/avr_timer16.h
rename to include/hw/timer/atmel_timer16.h
index 4ae0c64a34..f0516c41cf 100644
--- a/include/hw/timer/avr_timer16.h
+++ b/include/hw/timer/atmel_timer16.h
@@ -1,5 +1,5 @@
/*
- * AVR 16 bit timer
+ * Atmel AVR 16 bit timer
*
* Copyright (c) 2018 University of Kent
* Author: Ed Robbins
@@ -25,8 +25,8 @@
* On ATmega640/V-1280/V-1281/V-2560/V-2561/V timers 1, 3, 4 and 5 are 16 bit
*/
-#ifndef AVR_TIMER16_H
-#define AVR_TIMER16_H
+#ifndef HW_TIMER_ATMEL_TIMER16_H
+#define HW_TIMER_ATMEL_TIMER16_H
#include "hw/sysbus.h"
#include "qemu/timer.h"
@@ -40,7 +40,7 @@ enum NextInterrupt {
CAPT
};
-#define TYPE_AVR_TIMER16 "avr-timer16"
+#define TYPE_AVR_TIMER16 "atmel-timer16"
#define AVR_TIMER16(obj) \
OBJECT_CHECK(AVRTimer16State, (obj), TYPE_AVR_TIMER16)
@@ -91,4 +91,4 @@ typedef struct AVRTimer16State {
enum NextInterrupt next_interrupt;
} AVRTimer16State;
-#endif /* AVR_TIMER16_H */
+#endif /* HW_TIMER_ATMEL_TIMER16_H */
diff --git a/hw/avr/sample.c b/hw/avr/sample.c
index ca67c11233..19e9f56f3b 100644
--- a/hw/avr/sample.c
+++ b/hw/avr/sample.c
@@ -45,7 +45,7 @@
#include "exec/address-spaces.h"
#include "include/hw/sysbus.h"
#include "include/hw/char/atmel_usart.h"
-#include "include/hw/timer/avr_timer16.h"
+#include "include/hw/timer/atmel_timer16.h"
#include "include/hw/misc/avr_mask.h"
#include "elf.h"
#include "hw/misc/unimp.h"
diff --git a/hw/timer/avr_timer16.c b/hw/timer/atmel_timer16.c
similarity index 99%
rename from hw/timer/avr_timer16.c
rename to hw/timer/atmel_timer16.c
index a27933a18a..3b06d6e4e5 100644
--- a/hw/timer/avr_timer16.c
+++ b/hw/timer/atmel_timer16.c
@@ -1,5 +1,5 @@
/*
- * AVR 16 bit timer
+ * Atmel AVR 16 bit timer
*
* Copyright (c) 2018 University of Kent
* Author: Ed Robbins
@@ -32,7 +32,7 @@
*/
#include "qemu/osdep.h"
-#include "hw/timer/avr_timer16.h"
+#include "hw/timer/atmel_timer16.h"
#include "qemu/log.h"
#include "hw/irq.h"
#include "hw/qdev-properties.h"
diff --git a/MAINTAINERS b/MAINTAINERS
index f2e01a6d16..a98d164bc1 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -898,8 +898,8 @@ S: Maintained
F: hw/avr/
F: hw/char/atmel_usart.c
F: include/hw/char/atmel_usart.h
-F: hw/timer/avr_timer16.c
-F: include/hw/timer/avr_timer16.h
+F: hw/timer/atmel_timer16.c
+F: include/hw/timer/atmel_timer16.h
F: hw/misc/avr_mask.c
F: include/hw/misc/avr_mask.h
F: tests/acceptance/machine_avr6.py
diff --git a/hw/avr/Kconfig b/hw/avr/Kconfig
index 8084a73176..45c7025f09 100644
--- a/hw/avr/Kconfig
+++ b/hw/avr/Kconfig
@@ -1,6 +1,6 @@
config AVR_SAMPLE
bool
- select AVR_TIMER16
+ select ATMEL_TIMER16
select ATMEL_USART
select AVR_MASK
select UNIMP
diff --git a/hw/timer/Kconfig b/hw/timer/Kconfig
index 2521056dc8..cc66b60ef1 100644
--- a/hw/timer/Kconfig
+++ b/hw/timer/Kconfig
@@ -36,5 +36,5 @@ config CMSDK_APB_DUALTIMER
bool
select PTIMER
-config AVR_TIMER16
+config ATMEL_TIMER16
bool
diff --git a/hw/timer/Makefile.objs b/hw/timer/Makefile.objs
index af0913ca3b..08a8a5cee9 100644
--- a/hw/timer/Makefile.objs
+++ b/hw/timer/Makefile.objs
@@ -36,4 +36,4 @@ common-obj-$(CONFIG_CMSDK_APB_DUALTIMER) += cmsdk-apb-dualtimer.o
common-obj-$(CONFIG_MSF2) += mss-timer.o
common-obj-$(CONFIG_RASPI) += bcm2835_systmr.o
-obj-$(CONFIG_AVR_TIMER16) += avr_timer16.o
+obj-$(CONFIG_ATMEL_TIMER16) += atmel_timer16.o
--
2.21.1
next prev parent reply other threads:[~2020-01-20 22:12 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-20 22:00 [PATCH v4 00/18] hw/avr: Introduce few Arduino boards Philippe Mathieu-Daudé
2020-01-20 22:00 ` [PATCH v4 01/18] MAINTAINERS: Move machine test to the machine section (not ARCH one) Philippe Mathieu-Daudé
2020-01-20 22:00 ` [PATCH v4 02/18] MAINTAINERS: Move the AVR machines in new section (not within ARM) Philippe Mathieu-Daudé
2020-01-20 22:00 ` [PATCH v4 03/18] tests/acceptance: Do not set the machine type manually Philippe Mathieu-Daudé
2020-01-20 22:00 ` [PATCH v4 04/18] tests/acceptance: Keep multilines comment consistent with other tests Philippe Mathieu-Daudé
2020-01-20 22:00 ` [PATCH v4 05/18] hw/char/avr: Reduce USART I/O size Philippe Mathieu-Daudé
2020-01-20 22:00 ` [PATCH v4 06/18] hw/timer/avr_timer16: Rename memory region debugging name Philippe Mathieu-Daudé
2020-01-20 22:00 ` [PATCH v4 07/18] hw/misc/avr_mask: Remove unused include Philippe Mathieu-Daudé
2020-01-20 22:00 ` [PATCH v4 08/18] hw/avr/Makefile: Use CONFIG_AVR_SAMPLE variable Philippe Mathieu-Daudé
2020-01-20 22:00 ` [PATCH v4 09/18] hw/char: Rename avr_usart -> atmel_usart Philippe Mathieu-Daudé
2020-01-20 22:00 ` Philippe Mathieu-Daudé [this message]
2020-01-20 22:01 ` [PATCH v4 11/18] hw/misc: Rename avr_mask -> atmel_power Philippe Mathieu-Daudé
2020-01-20 22:01 ` [PATCH v4 12/18] hw/avr: Introduce ATMEL_ATMEGA_MCU config Philippe Mathieu-Daudé
2020-01-20 22:01 ` [PATCH v4 13/18] hw/avr: Add some ATmega microcontrollers Philippe Mathieu-Daudé
2020-01-20 22:01 ` [PATCH v4 14/18] hw/avr: Add some Arduino boards Philippe Mathieu-Daudé
2020-01-20 22:01 ` [PATCH v4 15/18] tests/boot-serial-test: Test some Arduino boards (AVR based) Philippe Mathieu-Daudé
2020-01-21 6:11 ` Thomas Huth
2020-01-20 22:01 ` [PATCH v4 16/18] tests/acceptance: Test the Arduino MEGA2560 board Philippe Mathieu-Daudé
2020-01-20 22:01 ` [PATCH v4 17/18] hw/avr: Remove the unrealistic AVR 'sample' board Philippe Mathieu-Daudé
2020-01-20 22:01 ` [PATCH v4 18/18] .travis.yml: Run the AVR acceptance tests Philippe Mathieu-Daudé
2020-01-20 23:30 ` [PATCH v4 00/18] hw/avr: Introduce few Arduino boards Philippe Mathieu-Daudé
2020-01-21 19:25 ` Michael Rolnik
2020-01-21 21:23 ` Philippe Mathieu-Daudé
2020-01-22 20:46 ` Richard Henderson
2020-01-22 21:56 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200120220107.17825-11-f4bug@amsat.org \
--to=f4bug@amsat.org \
--cc=S.E.Harris@kent.ac.uk \
--cc=aleksandar.m.mail@gmail.com \
--cc=mrolnik@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).