From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E27BBC2D0CE for ; Tue, 21 Jan 2020 13:30:57 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AF49E217F4 for ; Tue, 21 Jan 2020 13:30:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="iWHq+fYI" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AF49E217F4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:53848 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ittcO-0000pD-LM for qemu-devel@archiver.kernel.org; Tue, 21 Jan 2020 08:30:56 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:52928) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1itsiJ-0003yO-6i for qemu-devel@nongnu.org; Tue, 21 Jan 2020 07:33:03 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1itsiE-00053d-Ua for qemu-devel@nongnu.org; Tue, 21 Jan 2020 07:32:59 -0500 Received: from us-smtp-1.mimecast.com ([205.139.110.61]:29938 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1itsiE-00053V-QV for qemu-devel@nongnu.org; Tue, 21 Jan 2020 07:32:54 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1579609974; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=BXvdQUhT25fEokO+91yJZNZHXsX1sCtbQ6dSjDej4j8=; b=iWHq+fYIjIHXF7PpBI2Qs9mkK5vLHyoNTFLM7gRTLQfRvAzq5+yl4UT0VZnQM0oMV+CLFs 2fimhxf82qnH4gmSVVFlbGIrigJ5AEyVJOlzGl2NZyz/Btjqg/isEaHapMg2z3EOX91G7a NfVeJtzhNsk78cHf9yseVKIos9a13BQ= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-212-MD6non1hN0efprRX2ZUQbw-1; Tue, 21 Jan 2020 07:32:53 -0500 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 0C2B4107ACC9; Tue, 21 Jan 2020 12:32:52 +0000 (UTC) Received: from dgilbert-t580.localhost (unknown [10.36.118.32]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4FCAB60BE0; Tue, 21 Jan 2020 12:32:50 +0000 (UTC) From: "Dr. David Alan Gilbert (git)" To: qemu-devel@nongnu.org, stefanha@redhat.com, vgoyal@redhat.com, berrange@redhat.com, slp@redhat.com, philmd@redhat.com Subject: [PATCH v2 105/109] virtiofsd: add --thread-pool-size=NUM option Date: Tue, 21 Jan 2020 12:24:29 +0000 Message-Id: <20200121122433.50803-106-dgilbert@redhat.com> In-Reply-To: <20200121122433.50803-1-dgilbert@redhat.com> References: <20200121122433.50803-1-dgilbert@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-MC-Unique: MD6non1hN0efprRX2ZUQbw-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 205.139.110.61 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: m.mizuma@jp.fujitsu.com, misono.tomohiro@jp.fujitsu.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" From: Stefan Hajnoczi Add an option to control the size of the thread pool. Requests are now processed in parallel by default. Signed-off-by: Stefan Hajnoczi Reviewed-by: Daniel P. Berrang=C3=A9 Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- tools/virtiofsd/fuse_i.h | 1 + tools/virtiofsd/fuse_lowlevel.c | 7 ++++++- tools/virtiofsd/fuse_virtio.c | 5 +++-- 3 files changed, 10 insertions(+), 3 deletions(-) diff --git a/tools/virtiofsd/fuse_i.h b/tools/virtiofsd/fuse_i.h index 1447d86866..4e47e5880d 100644 --- a/tools/virtiofsd/fuse_i.h +++ b/tools/virtiofsd/fuse_i.h @@ -72,6 +72,7 @@ struct fuse_session { int vu_listen_fd; int vu_socketfd; struct fv_VuDev *virtio_dev; + int thread_pool_size; }; =20 struct fuse_chan { diff --git a/tools/virtiofsd/fuse_lowlevel.c b/tools/virtiofsd/fuse_lowleve= l.c index 8ae45d9c58..2ce3e739fd 100644 --- a/tools/virtiofsd/fuse_lowlevel.c +++ b/tools/virtiofsd/fuse_lowlevel.c @@ -27,6 +27,7 @@ #include #include =20 +#define THREAD_POOL_SIZE 64 =20 #define OFFSET_MAX 0x7fffffffffffffffLL =20 @@ -2521,6 +2522,7 @@ static const struct fuse_opt fuse_ll_opts[] =3D { LL_OPTION("allow_root", deny_others, 1), LL_OPTION("--socket-path=3D%s", vu_socket_path, 0), LL_OPTION("--fd=3D%d", vu_listen_fd, 0), + LL_OPTION("--thread-pool-size=3D%d", thread_pool_size, 0), FUSE_OPT_END }; =20 @@ -2541,7 +2543,9 @@ void fuse_lowlevel_help(void) " -o allow_root allow access by root\n" " --socket-path=3DPATH path for the vhost-user socket\n= " " --fd=3DFDNUM fd number of vhost-user socket\n= " - " -o auto_unmount auto unmount on process terminatio= n\n"); + " -o auto_unmount auto unmount on process terminatio= n\n" + " --thread-pool-size=3DNUM thread pool size limit (default = %d)\n", + THREAD_POOL_SIZE); } =20 void fuse_session_destroy(struct fuse_session *se) @@ -2595,6 +2599,7 @@ struct fuse_session *fuse_session_new(struct fuse_arg= s *args, } se->fd =3D -1; se->vu_listen_fd =3D -1; + se->thread_pool_size =3D THREAD_POOL_SIZE; se->conn.max_write =3D UINT_MAX; se->conn.max_readahead =3D UINT_MAX; =20 diff --git a/tools/virtiofsd/fuse_virtio.c b/tools/virtiofsd/fuse_virtio.c index 0dcf2ef57a..9f6582343c 100644 --- a/tools/virtiofsd/fuse_virtio.c +++ b/tools/virtiofsd/fuse_virtio.c @@ -572,10 +572,11 @@ static void *fv_queue_thread(void *opaque) struct fv_QueueInfo *qi =3D opaque; struct VuDev *dev =3D &qi->virtio_dev->dev; struct VuVirtq *q =3D vu_get_queue(dev, qi->qidx); + struct fuse_session *se =3D qi->virtio_dev->se; GThreadPool *pool; =20 - pool =3D g_thread_pool_new(fv_queue_worker, qi, 1 /* TODO max_threads = */, - TRUE, NULL); + pool =3D g_thread_pool_new(fv_queue_worker, qi, se->thread_pool_size, = TRUE, + NULL); if (!pool) { fuse_log(FUSE_LOG_ERR, "%s: g_thread_pool_new failed\n", __func__)= ; return NULL; --=20 2.24.1