From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7EABDC2D0CE for ; Tue, 21 Jan 2020 12:40:45 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4805F24653 for ; Tue, 21 Jan 2020 12:40:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="UjBueYGT" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4805F24653 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:53202 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1itspo-0003XX-1u for qemu-devel@archiver.kernel.org; Tue, 21 Jan 2020 07:40:44 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:51162) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1itsbV-0005xN-8u for qemu-devel@nongnu.org; Tue, 21 Jan 2020 07:25:58 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1itsbR-0001zr-AX for qemu-devel@nongnu.org; Tue, 21 Jan 2020 07:25:57 -0500 Received: from us-smtp-1.mimecast.com ([207.211.31.81]:35448 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1itsbR-0001zn-6k for qemu-devel@nongnu.org; Tue, 21 Jan 2020 07:25:53 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1579609552; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=E7v4YzWpKMP1akwTle/wQyB8MLuZbEjM2jo9ES72v0Y=; b=UjBueYGTtDKfCNLqpbMCcQgVBzY3gP3q0fAp7AIpjX/X0dKRrc9bV06xzepv9uastJJJ8Z vzCX35LtzEM6EoPm4IEtkNFxlqkySmaF4dBoYvMVMZhELqZjYbUVuazozbVdXkaDLgdLQo Rbx2MNaQJZCsHkj46lBk3YEhFoGdJBw= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-241-ph40QVLwO76T686jgZd1mg-1; Tue, 21 Jan 2020 07:25:51 -0500 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 4A0731005510; Tue, 21 Jan 2020 12:25:50 +0000 (UTC) Received: from dgilbert-t580.localhost (unknown [10.36.118.32]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0766B60BE0; Tue, 21 Jan 2020 12:25:45 +0000 (UTC) From: "Dr. David Alan Gilbert (git)" To: qemu-devel@nongnu.org, stefanha@redhat.com, vgoyal@redhat.com, berrange@redhat.com, slp@redhat.com, philmd@redhat.com Subject: [PATCH v2 014/109] virtiofsd: Make fsync work even if only inode is passed in Date: Tue, 21 Jan 2020 12:22:58 +0000 Message-Id: <20200121122433.50803-15-dgilbert@redhat.com> In-Reply-To: <20200121122433.50803-1-dgilbert@redhat.com> References: <20200121122433.50803-1-dgilbert@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-MC-Unique: ph40QVLwO76T686jgZd1mg-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 207.211.31.81 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: m.mizuma@jp.fujitsu.com, misono.tomohiro@jp.fujitsu.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" From: Vivek Goyal If caller has not sent file handle in request, then using inode, retrieve the fd opened using O_PATH and use that to open file again and issue fsync. This will be needed when dax_flush() calls fsync. At that time we only have inode information (and not file). Signed-off-by: Vivek Goyal Reviewed-by: Daniel P. Berrang=C3=A9 --- tools/virtiofsd/fuse_lowlevel.c | 6 +++++- tools/virtiofsd/passthrough_ll.c | 28 ++++++++++++++++++++++++++-- 2 files changed, 31 insertions(+), 3 deletions(-) diff --git a/tools/virtiofsd/fuse_lowlevel.c b/tools/virtiofsd/fuse_lowleve= l.c index efba1066a1..861a0b6c31 100644 --- a/tools/virtiofsd/fuse_lowlevel.c +++ b/tools/virtiofsd/fuse_lowlevel.c @@ -1076,7 +1076,11 @@ static void do_fsync(fuse_req_t req, fuse_ino_t node= id, const void *inarg) fi.fh =3D arg->fh; =20 if (req->se->op.fsync) { - req->se->op.fsync(req, nodeid, datasync, &fi); + if (fi.fh =3D=3D (uint64_t)-1) { + req->se->op.fsync(req, nodeid, datasync, NULL); + } else { + req->se->op.fsync(req, nodeid, datasync, &fi); + } } else { fuse_reply_err(req, ENOSYS); } diff --git a/tools/virtiofsd/passthrough_ll.c b/tools/virtiofsd/passthrough= _ll.c index e1f76170f6..3a8d5497c6 100644 --- a/tools/virtiofsd/passthrough_ll.c +++ b/tools/virtiofsd/passthrough_ll.c @@ -902,10 +902,34 @@ static void lo_fsync(fuse_req_t req, fuse_ino_t ino, = int datasync, { int res; (void)ino; + int fd; + char *buf; + + fuse_log(FUSE_LOG_DEBUG, "lo_fsync(ino=3D%" PRIu64 ", fi=3D0x%p)\n", i= no, + (void *)fi); + + if (!fi) { + res =3D asprintf(&buf, "/proc/self/fd/%i", lo_fd(req, ino)); + if (res =3D=3D -1) { + return (void)fuse_reply_err(req, errno); + } + + fd =3D open(buf, O_RDWR); + free(buf); + if (fd =3D=3D -1) { + return (void)fuse_reply_err(req, errno); + } + } else { + fd =3D fi->fh; + } + if (datasync) { - res =3D fdatasync(fi->fh); + res =3D fdatasync(fd); } else { - res =3D fsync(fi->fh); + res =3D fsync(fd); + } + if (!fi) { + close(fd); } fuse_reply_err(req, res =3D=3D -1 ? errno : 0); } --=20 2.24.1